| :: |
| Author |
Message |
mikeysun
Joined: 12 Aug 2007
Posts: 9
|
 Posted: Sat Aug 18, 2007 11:41 am Post subject: advanced rewrite phpbb3 global announcements links |
|
|
Hi,
It appears that advanced rewrite for phpbb3 does not rewrite global announcements links.
these are still displayed in a format of viewtopic.php?f=1&t=15 instead of announcement/title-whatever.html
Is this a know bug?
Thanks,
Mike |
|
|
| Back to top |
|
 |
|
|
SeO
Administrateur - Site Admin
Joined: 15 Mar 2006
Posts: 3691
|
|
| Back to top |
|
|
mikeysun
Joined: 12 Aug 2007
Posts: 9
|
| Posted: Sat Aug 18, 2007 12:10 pm Post subject: Re: advanced rewrite phpbb3 global announcements links |
|
|
ahem, well... http://forum.nowhere.us/freestuff-f1/ check it yourself, the first on the top link points to viewtopic.php... what that might be?
there is one more thing ...<base href="http://forum.nowhere.us/"> does cause some link being redirected to the index.php (root /)...not sure if you are aware of this... e.g. http://forum.nowhere.us/#wrap
| Quote: | By the way, welcome  |
Cheers  |
Last edited by mikeysun on Sun Oct 28, 2007 10:54 am; edited 1 time in total |
|
| Back to top |
|
|
SeO
Administrateur - Site Admin
Joined: 15 Mar 2006
Posts: 3691
|
| Posted: Sat Aug 18, 2007 12:37 pm Post subject: Re: advanced rewrite phpbb3 global announcements links |
|
|
The #wrap link is fixed in 0.4.0RC1 as well as few more small bugs.
This fix is :
| Code: |
#
#-----[ OPEN ]------------------------------------------
#
styles/prosilver/template/viewtopic_body.html
#
#-----[ FIND ]------------------------------------------
#
<a href="#wrap" class="top" title="{L_BACK_TO_TOP}">
#
#-----[REPLACE WITH ]------------------------------------------
#
<a href="{U_VIEW_TOPIC}#wrap" class="top" title="{L_BACK_TO_TOP}"> |
The announcement bug could be a typo while installing, the zero duplicate is redirecting properly though.
We'll investigate a bit more. By then, you can check the install, just check all the part dealing with :
| Code: | | $phpbb_seo->seo_opt['topic_type'] |
In phpBB files.
Talking about your forum, you may consider that HTTPS is not really bot friendly, I've not looked deeply into it, but the best would probably be to only use it for logged in users, and to let public content available with HTTP.
The phpbb_seo_class.php part would be pretty easy to tweak for this, but requires some checks with phpBB.
As well, do not forget about the last touch
cheers. |
_________________
phpBB SEO || SEO Forum || Forum Référencement
GYM Sitemap & RSS for phpBB3 has been released ! || GYM Sitemap & RSS for phpBB3 est disponible ! |
|
| Back to top |
|
|
mikeysun
Joined: 12 Aug 2007
Posts: 9
|
| Posted: Sat Aug 18, 2007 8:50 pm Post subject: Re: advanced rewrite phpbb3 global announcements links |
|
|
SeO, mate you know what...
There is one more thing... some non ASCII symbols (e.g.: accented characters) are not being changed to their ASCII replacements, here is how I would solve this.
It might be ugly and everything, but I am sysadmin not a programmer...so as long as it does the trick for me I am happy w/this
| Code: |
#
#-----[ OPEN ]------------------------------------------
#
phpbb_seo/phpbb_seo_class.php
#
#-----[ FIND ]------------------------------------------
#
$url = htmlentities($url, ENT_COMPAT, $this->encoding);
#
#-----[ AFTER, ADD]------------------------------------------
#
$url = preg_replace( '`ą`i', 'a', $url );
$url = preg_replace( '`ć`i', 'c', $url );
$url = preg_replace( '`ę`i', 'e', $url );
$url = preg_replace( '`ł`i', 'l', $url );
$url = preg_replace( '`ń`i', 'n', $url );
$url = preg_replace( '`ó`i', 'o', $url );
$url = preg_replace( '`ś`i', 's', $url );
$url = preg_replace( '`ż`i', 'z', $url );
$url = preg_replace( '`ź`i', 'z', $url );
|
| SeO wrote: |
We'll investigate a bit more. By then, you can check the install, just check all the part dealing with :
| Code: | | $phpbb_seo->seo_opt['topic_type'] |
|
I applied all the mods again to a fresh source, then did a diff against the working version on my forum, and it doesn't look like I missed anything. So would be great if you could investigate this issue some more.
EDIT: the list above contains all the Polish non ASCII national characters. |
|
|
| Back to top |
|
|
dcz
Administrateur - Site Admin
Joined: 28 Apr 2006
Posts: 15135
|
| Posted: Sun Aug 19, 2007 2:29 pm Post subject: Re: advanced rewrite phpbb3 global announcements links |
|
|
The thing is many characters only have a decimal html/xml entity, but it's still faster to use the single preg_replace call for the others.
And these extra filtering are not useful to everybody.
We of course care about it, but obviously need reports about such exceptions for language we do not use ourselves. We already started to implement a bit more universal and optimised way to do this type of thing for Slovak and Turkish.
Adding Polish is just great
It's starting in this post : http://www.phpbb-seo.com/boards/advanced-seo-url/discussions-vt1229-15.html#9596
Doing it the way you do it is a bit heavier and is not fully universal, since depending on your OS char-sets, you may not be able to use these chars and paste them properly.
As well, filtering them after the htmlentities() call is not the best place, we'd rather do this when UTF-8 chars are left untouched.
So you confirm these are all the required chars for a proper Polish title injection in URLs ?
would be greatly useful to post a new thread and find out how to bets deal with these.
The global announce rewriting bug is strange. I cannot reproduce the bug.
I suggest we wait until the next version is released before we really start to investigate further, unless off course you find more clues about it.
++ |
_________________
Useful links :
SEO Forum || SEO Directory || SEO phpBB || SEO phpBB3 || Search
____________________
Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Référencement phpBB3 || Recherche |
|
| Back to top |
|
|
mikeysun
Joined: 12 Aug 2007
Posts: 9
|
| Posted: Wed Aug 22, 2007 10:28 pm Post subject: Re: advanced rewrite phpbb3 global announcements links |
|
|
| dcz wrote: |
I suggest we wait until the next version is released before we really start to investigate further, unless off course you find more clues about it. |
Hi,
I only upgraded and the issue seems to persist, any idea?
More over after installing the last ver I am unable to login to adm/ I got redirected to index.php after specifying my password. |
|
|
| Back to top |
|
|
dcz
Administrateur - Site Admin
Joined: 28 Apr 2006
Posts: 15135
|
|
| Back to top |
|
|
mikeysun
Joined: 12 Aug 2007
Posts: 9
|
| Posted: Mon Aug 27, 2007 8:04 pm Post subject: Re: advanced rewrite phpbb3 global announcements links |
|
|
Hi,
I managed to apply everything again on phpbbRC5 and it seems to be all ok... will try to investigate the problem I had with phpbbRC4 on weekend.
thanks |
|
|
| Back to top |
|
|
dcz
Administrateur - Site Admin
Joined: 28 Apr 2006
Posts: 15135
|
|
| Back to top |
|
|
|
|
