| |
|
| :: |
| Author |
Message |
tybi
Joined: 04 Nov 2007
Posts: 28
|
|
| Back to top |
|
 |
|
|
dcz
Administrateur - Site Admin
Joined: 28 Apr 2006
Posts: 15242
|
|
| Back to top |
|
|
tybi
Joined: 04 Nov 2007
Posts: 28
|
 Posted: Mon Dec 24, 2007 12:52 pm Post subject: Re: The pagination links don't work |
|
|
Arrrrrr  , I forgot to do that 
Thanks. |
|
|
| Back to top |
|
|
TomaS
PR2
Joined: 08 Jun 2007
Posts: 226
|
|
| Back to top |
|
|
SeO
Administrateur - Site Admin
Joined: 15 Mar 2006
Posts: 4006
|
|
| Back to top |
|
|
TomaS
PR2
Joined: 08 Jun 2007
Posts: 226
|
| Posted: Tue Dec 25, 2007 7:17 pm Post subject: Re: The pagination links don't work |
|
|
no it doesnt. I have brand new instalation becuase som problem whit update so i need it install again.Everythinks work perfeckt but only for example here
http://www.phpbb3.sk/forum/phpbb3-podpora.html when you cluick on pagination show 404 error so i dnot know where can be mistake.I have looked again on viewforum code wich i have added but it is ok just like in install guide so that is coreckt is it possible that in installation is error in viewforum pagination?Try this someone else?In viewtopic works good only in viewforum
thx for help and some idea how to fix it |
_________________
phpBB podpora-slovak phpBB support
slovenský preklad pre phpbb3-slovak translate for phpBB3
predaj a kupa domeny, marketing a internetove podnikanie- Slovak domain center |
|
| Back to top |
|
|
dcz
Administrateur - Site Admin
Joined: 28 Apr 2006
Posts: 15242
|
|
| Back to top |
|
|
TomaS
PR2
Joined: 08 Jun 2007
Posts: 226
|
| Posted: Wed Dec 26, 2007 4:40 pm Post subject: Re: The pagination links don't work |
|
|
No everythink looks fine
| Code: | #
#-----[ FIND ]------------------------------------------
#
/**
* Generate topic pagination
*/
function topic_generate_pagination($replies, $url)
{
global $config, $user;
#
#-----[ AFTER, ADD ]------------------------------------------
#
// www.phpBB-SEO.com SEO TOOLKIT BEGIN
global $phpbb_seo, $phpEx;
// www.phpBB-SEO.com SEO TOOLKIT END |
and | Code: | #
#-----[ FIND ]------------------------------------------
#
function generate_pagination($base_url, $num_items, $per_page, $start_item, $add_prevnext_text = false, $tpl_prefix = '')
{
global $template, $user;
#
#-----[ AFTER, ADD]------------------------------------------
#
// www.phpBB-SEO.com SEO TOOLKIT BEGIN
global $phpbb_seo, $phpEx;
// www.phpBB-SEO.com SEO TOOLKIT END |
this is coreckt
only here | Code: | #
#-----[ FIND ]------------------------------------------
#
}
else
{
$pagination = '';
}
#
#-----[ BEFORE, ADD ]------------------------------------------
#
// www.phpBB-SEO.com SEO TOOLKIT BEGIN
if (is_object($phpbb_seo) && strpos($pagination, '.' . $phpEx) === FALSE) {
static $pagin_find = array( '`(\.[a-z0-9]+)([\w\#$%&~.\-;:=,?@+]*)&start=([0-9]+)`i', '`/([\w\#$%&~.\-;:=,?@+]*)&start=([0-9]+)`i' );
static $pagin_replace = array();
if (empty($pagin_replace)) {
$pagin_replace = array( $phpbb_seo->seo_delim['start'] . '\\3\\1\\2', '/' . $phpbb_seo->seo_static['pagination'] . '\\2' . $phpbb_seo->seo_ext['pagination'] .'\\1' );
}
$pagination = str_replace( '&start=0', '', $pagination );
$pagination = preg_replace( $pagin_find, $pagin_replace, $pagination );
}
// www.phpBB-SEO.com SEO TOOLKIT END |
if i add it too close to }
else
{ show me error so i added there one line |
_________________
phpBB podpora-slovak phpBB support
slovenský preklad pre phpbb3-slovak translate for phpBB3
predaj a kupa domeny, marketing a internetove podnikanie- Slovak domain center |
|
| Back to top |
|
|
TomaS
PR2
Joined: 08 Jun 2007
Posts: 226
|
| Posted: Thu Dec 27, 2007 10:52 pm Post subject: Re: The pagination links don't work |
|
|
| i have copied files (function and functions_display.php) from your premod pack but it is same.No change.I think mistake must be here in those 2 files but where?DCZ did you try it this situation if is it work?on viewforum? |
_________________
phpBB podpora-slovak phpBB support
slovenský preklad pre phpbb3-slovak translate for phpBB3
predaj a kupa domeny, marketing a internetove podnikanie- Slovak domain center |
|
| Back to top |
|
|
dcz
Administrateur - Site Admin
Joined: 28 Apr 2006
Posts: 15242
|
| Posted: Fri Dec 28, 2007 10:00 am Post subject: Re: The pagination links don't work |
|
|
Grr, this is indeed a bug !!
It was tricky to find out, because it only conserns domains with ".php" in it, such as -www.phpbb3.sk or phpbb3.phpbb-seo.net !
I had not tested pagination on such domains, my fault, sorry.
Anyway, here is the fix, which will lead us to an update very soon :
| Code: |
#
#-----[ OPEN ]------------------------------------------
#
includes/functions.php
#
#-----[ FIND ]------------------------------------------
#
// www.phpBB-SEO.com SEO TOOLKIT BEGIN
$prev = ($on_page == 1) ? '' : $base_url . "{$url_delim}start=" . (($on_page - 2) * $per_page);
$next = ($on_page == $total_pages) ? '' : $base_url . "{$url_delim}start=" . ($on_page * $per_page);
if (is_object($phpbb_seo) && strpos($page_string, '.' . $phpEx) === FALSE) {
static $pagin_find = array();
static $pagin_replace = array();
static $prev_find = array();
if (empty($pagin_replace)) {
$pagin_find = array('`(\.[a-z0-9]+)([\w\#$%&~\-;:=,?@+]*)(&|\?)start=([0-9]+)`i', '`/([\w\#$%&~\-;:=,?@+]*)(&|\?)start=([0-9]+)`i' );
$pagin_replace = array( $phpbb_seo->seo_delim['start'] . '\\4\\1\\2', '/' . $phpbb_seo->seo_static['pagination'] . '\\3' . $phpbb_seo->seo_ext['pagination'] . '\\1' );
$prev_find = array($phpbb_seo->seo_delim['start'] . '0', $phpbb_seo->seo_static['pagination'] . '0' . $phpbb_seo->seo_ext['pagination']);
}
$page_string = str_replace($url_delim . 'start=0', '', $page_string);
$page_string = preg_replace($pagin_find, $pagin_replace, $page_string);
$prev = preg_replace($pagin_find, $pagin_replace, $prev);
$prev = str_replace($prev_find, '', $prev);
$next = preg_replace( $pagin_find, $pagin_replace, $next);
}
$template->assign_vars(array(
$tpl_prefix . 'BASE_URL' => $base_url,
'A_' . $tpl_prefix . 'BASE_URL' => addslashes($base_url),
$tpl_prefix . 'PER_PAGE' => $per_page,
$tpl_prefix . 'PREVIOUS_PAGE' => $prev,
$tpl_prefix . 'NEXT_PAGE' => $next,
$tpl_prefix . 'TOTAL_PAGES' => $total_pages)
);
// www.phpBB-SEO.com SEO TOOLKIT END
#
#-----[ REPLACE WITH ]------------------------------------------
#
// www.phpBB-SEO.com SEO TOOLKIT BEGIN
$prev = ($on_page == 1) ? '' : $base_url . "{$url_delim}start=" . (($on_page - 2) * $per_page);
$next = ($on_page == $total_pages) ? '' : $base_url . "{$url_delim}start=" . ($on_page * $per_page);
if (is_object($phpbb_seo)) {
static $pagin_find = array();
static $pagin_replace = array();
static $prev_find = array();
if (empty($pagin_replace)) {
$pagin_find = array('`(\.(?!' . $phpEx . ')[a-z0-9]+)([\w\#$%&~\-;:=,?@+]*)(&|\?)start=([0-9]+)`i', '`/([\w\#$%&~\-;:=,?@+]*)(&|\?)start=([0-9]+)`i' );
$pagin_replace = array( $phpbb_seo->seo_delim['start'] . '\\4\\1\\2', '/' . $phpbb_seo->seo_static['pagination'] . '\\3' . $phpbb_seo->seo_ext['pagination'] . '\\1' );
$prev_find = array($phpbb_seo->seo_delim['start'] . '0', $phpbb_seo->seo_static['pagination'] . '0' . $phpbb_seo->seo_ext['pagination']);
}
$page_string = str_replace($url_delim . 'start=0', '', $page_string);
$page_string = preg_replace($pagin_find, $pagin_replace, $page_string);
$prev = preg_replace($pagin_find, $pagin_replace, $prev);
$prev = str_replace($prev_find, '', $prev);
$next = preg_replace( $pagin_find, $pagin_replace, $next);
}
$template->assign_vars(array(
$tpl_prefix . 'BASE_URL' => $base_url,
'A_' . $tpl_prefix . 'BASE_URL' => addslashes($base_url),
$tpl_prefix . 'PER_PAGE' => $per_page,
$tpl_prefix . 'PREVIOUS_PAGE' => $prev,
$tpl_prefix . 'NEXT_PAGE' => $next,
$tpl_prefix . 'TOTAL_PAGES' => $total_pages)
);
// www.phpBB-SEO.com SEO TOOLKIT END
#
#-----[ OPEN ]------------------------------------------
#
includes/functions_display.php
#
#-----[ FIND ]------------------------------------------
#
// www.phpBB-SEO.com SEO TOOLKIT BEGIN
if (is_object($phpbb_seo) && strpos($pagination, '.' . $phpEx) === FALSE) {
static $pagin_find = array( '`(\.[a-z0-9]+)([\w\#$%&~.\-;:=,?@+]*)&start=([0-9]+)`i', '`/([\w\#$%&~.\-;:=,?@+]*)&start=([0-9]+)`i' );
static $pagin_replace = array();
if (empty($pagin_replace)) {
$pagin_replace = array( $phpbb_seo->seo_delim['start'] . '\\3\\1\\2', '/' . $phpbb_seo->seo_static['pagination'] . '\\2' . $phpbb_seo->seo_ext['pagination'] .'\\1' );
}
$pagination = str_replace( '&start=0', '', $pagination );
$pagination = preg_replace( $pagin_find, $pagin_replace, $pagination );
}
// www.phpBB-SEO.com SEO TOOLKIT END
#
#-----[ REPLACE WITH ]------------------------------------------
#
// www.phpBB-SEO.com SEO TOOLKIT BEGIN
if (is_object($phpbb_seo) ) {
static $pagin_find = array();
static $pagin_replace = array();
if (empty($pagin_find)) {
$pagin_find = array( '`(\.(?!' . $phpEx . ')[a-z0-9]+)([\w\#$%&~\-;:=,?@+]*)&start=([0-9]+)`i', '`/([\w\#$%&~\-;:=,?@+]*)&start=([0-9]+)`i' );
$pagin_replace = array( $phpbb_seo->seo_delim['start'] . '\\3\\1\\2', '/' . $phpbb_seo->seo_static['pagination'] . '\\2' . $phpbb_seo->seo_ext['pagination'] .'\\1' );
}
$pagination = str_replace( '&start=0', '', $pagination );
$pagination = preg_replace( $pagin_find, $pagin_replace, $pagination );
}
// www.phpBB-SEO.com SEO TOOLKIT END |
Sorry for that.
++ |
_________________
Useful links :
SEO Forum || SEO Directory || SEO phpBB || SEO phpBB3 || Search
____________________
Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Référencement phpBB3 || Recherche |
|
| Back to top |
|
|
TomaS
PR2
Joined: 08 Jun 2007
Posts: 226
|
| Posted: Fri Dec 28, 2007 11:25 am Post subject: Re: The pagination links don't work |
|
|
first:thx for fix that dcz now it is working great it is a such fantastic mod 
second:it you have not to excuse to me  i found only little bugsik in you great mod and one member show that wasnt work.But it was only little mistake and everythink now look fine  |
_________________
phpBB podpora-slovak phpBB support
slovenský preklad pre phpbb3-slovak translate for phpBB3
predaj a kupa domeny, marketing a internetove podnikanie- Slovak domain center |
|
| Back to top |
|
|
dcz
Administrateur - Site Admin
Joined: 28 Apr 2006
Posts: 15242
|
|
| Back to top |
|
|
TomaS
PR2
Joined: 08 Jun 2007
Posts: 226
|
|
| Back to top |
|
|
dcz
Administrateur - Site Admin
Joined: 28 Apr 2006
Posts: 15242
|
|
| Back to top |
|
|
|
|
| Navigation |
Similar Topics |
|
|
|
|
|
|
|
