| :: |
| Author |
Message |
Joerg
Joined: 10 May 2007
Posts: 24
|
 Posted: Mon Jun 04, 2007 7:18 pm Post subject: Re: No *.xml files |
|
|
Hi i insert your line in teh .htaccess and delete the old sitempa over the
ACP but it is the same result.
Regards Jörg |
|
|
| Back to top |
|
 |
|
|
dcz
Administrateur - Site Admin
Joined: 28 Apr 2006
Posts: 15242
|
|
| Back to top |
|
|
Joerg
Joined: 10 May 2007
Posts: 24
|
| Posted: Tue Jun 05, 2007 10:03 pm Post subject: Re: No *.xml files |
|
|
No not more.
i deinstalled the mod and use now the simple sub-mod.
Regards Jörg |
|
|
| Back to top |
|
|
dcz
Administrateur - Site Admin
Joined: 28 Apr 2006
Posts: 15242
|
| Posted: Wed Jun 06, 2007 6:59 pm Post subject: Re: No *.xml files |
|
|
So the sitemapindex works, as well as the forums sitemaps (http://forum.bulldog-bt1100.de/forum-sitemap.xml.gz) but not the forum sitemaps (the one listing topics).
The .htaccess is ok, the link works, but you get an 500 error (did that to make sure bots would understand, unlike with the regular error handler):
| Code: | 500 Internal Server Error :
Information
Invalid Sitemap |
So, this could mean a lot of things. Since you first tried with CH, it could come from left others in the db. Like if CH did not maintain the forum_last_post_id or the auth_view & auth_read fields the way phpBB does normally, thing like that.
Because this message means the code fails when performing this query in mx_ggsitemaps/includes/google_forum.php
| Code: | $sql = "SELECT f.*, p.post_time
FROM ". FORUMS_TABLE ." AS f, " . POSTS_TABLE . " AS p
WHERE f.forum_id = " . $this->actions['list_id'] . "
AND p.post_id = f.forum_last_post_id"; |
Or right after, when checking auth :
| Code: | if ( empty($forum_data) || ( $forum_data['auth_view'] != 0 ) || ( $forum_data['auth_read'] != 0 ) || (in_array($forum_id, $this->output_data['exclude_list'])) ) {
$this->mx_sitemaps_message_die(GENERAL_MESSAGE, 'Invalid Sitemap');
} |
So I'm not sure about how to fully uninstall CH and go back to the genuine phpBB db structure, nor if it is required, but the problem comes from there.
You could try to overwrite you google_forum.php file with a fresh one, just in case, before starting to find out more about how to fully remove CH.
In case everything fails, you could replace this particular query with one not using the post table, would only get rid of the last mod time for the forum url in topic listing, not very important :
| Code: | $sql = "SELECT .*
FROM ". FORUMS_TABLE ."
WHERE f.forum_id = " . $this->actions['list_id'];
|
And then add (just to keep providing a lastmod date, basically current time - 10 to 1000 second in this example for the forum links) :
| Code: | | $forum_data['post_time'] = time() - rand(10, 1000); |
After :
| Code: | if ( empty($forum_data) || ( $forum_data['auth_view'] != 0 ) || ( $forum_data['auth_read'] != 0 ) || (in_array($forum_id, $this->output_data['exclude_list'])) ) {
$this->mx_sitemaps_message_die(GENERAL_MESSAGE, 'Invalid Sitemap');
} |
If not enough, this means the problem comes from the auth, and then it most likely means as well you'll experience problems elsewhere, make sure private forums cannot be browsed by guest or logged user with not enough auth for example.
You could still try to comment this line :
| Code: | | $this->mx_sitemaps_message_die(GENERAL_MESSAGE, 'Invalid Sitemap'); |
Just to see if the topic are listed ok.
We would still be able to manage a quick fix, but in all cases, the best would be to make sure your phpBB db is well structured.
Do not submit your sitemap before it's fully operational.
++ |
_________________
Useful links :
SEO Forum || SEO Directory || SEO phpBB || SEO phpBB3 || Search
____________________
Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Référencement phpBB3 || Recherche |
|
| Back to top |
|
|
Joerg
Joined: 10 May 2007
Posts: 24
|
| Posted: Sat Jun 16, 2007 12:59 am Post subject: Re: No *.xml files |
|
|
Hi, sorry for my late replay.
| dcz wrote: |
You could still try to comment this line :
| Code: | | $this->mx_sitemaps_message_die(GENERAL_MESSAGE, 'Invalid Sitemap'); |
++ |
With this comment ist worknow i see the list.
Regards Jörg |
|
|
| Back to top |
|
|
dcz
Administrateur - Site Admin
Joined: 28 Apr 2006
Posts: 15242
|
|
| Back to top |
|
|
Joerg
Joined: 10 May 2007
Posts: 24
|
| Posted: Fri Jun 22, 2007 12:03 pm Post subject: Re: No *.xml files |
|
|
The forum are mixed some parts are public and some not.
But that i dont understand why the forum so runs well.
Regards jörg |
|
|
| Back to top |
|
|
dcz
Administrateur - Site Admin
Joined: 28 Apr 2006
Posts: 15242
|
| Posted: Fri Jun 22, 2007 1:24 pm Post subject: Re: No *.xml files |
|
|
Given that you un-installed the CH mod, it's hard to tell, I assume some SQL should be used while doing it, but I never tried so far.
To try to understand a bit more, you can try to replace :
| Code: | if ( empty($forum_data) || ( $forum_data['auth_view'] != 0 ) || ( $forum_data['auth_read'] != 0 ) || (in_array($forum_id, $this->output_data['exclude_list'])) ) {
$this->mx_sitemaps_message_die(GENERAL_MESSAGE, 'Invalid Sitemap');
} |
with :
| Code: | if ( empty($forum_data) || (in_array($forum_id, $this->output_data['exclude_list'])) ) {
$this->mx_sitemaps_message_die(GENERAL_MESSAGE, 'Invalid Sitemap');
} |
And tell me how it goes for a public forum sitemap.
And then, if it loaded correctly, try :
| Code: | if ( empty($forum_data) || ( $forum_data['auth_read'] != 0 ) || (in_array($forum_id, $this->output_data['exclude_list'])) ) {
$this->mx_sitemaps_message_die(GENERAL_MESSAGE, 'Invalid Sitemap');
} |
and :
| Code: | if ( empty($forum_data) || ( $forum_data['auth_view'] != 0 ) || (in_array($forum_id, $this->output_data['exclude_list'])) ) {
$this->mx_sitemaps_message_die(GENERAL_MESSAGE, 'Invalid Sitemap');
} |
and tell me if one of the two is working.
As well, could you post here the values stored in the phpbb_forums table, for a public forum (there is no secret in it) to check how auth are handled.
++ |
_________________
Useful links :
SEO Forum || SEO Directory || SEO phpBB || SEO phpBB3 || Search
____________________
Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Référencement phpBB3 || Recherche |
|
| Back to top |
|
|
Joerg
Joined: 10 May 2007
Posts: 24
|
| Posted: Mon Jul 02, 2007 8:53 pm Post subject: Re: No *.xml files |
|
|
both entrys work well.
Regards Jörg |
|
|
| Back to top |
|
|
dcz
Administrateur - Site Admin
Joined: 28 Apr 2006
Posts: 15242
|
| Posted: Tue Jul 03, 2007 3:57 pm Post subject: Re: No *.xml files |
|
|
Well if all the three cases I suggested do work, it means that most of your forum do have different values for auth_view and auth_read.
Browsing your forum as guest should not allow you to see all forums and content.
What you need to make sure the most is are the forum listed in the sitemaps accessible by guests. If so, and if all of them are listed, then it's ok. You could only use one of the two auth fields checks (auth_view and auth_read) and keep the one that shows all public forums.
At least, you should keep the first version proposed, to be able to manually exclude the private forums in ACP :
| Code: | if ( empty($forum_data) || (in_array($forum_id, $this->output_data['exclude_list'])) ) {
$this->mx_sitemaps_message_die(GENERAL_MESSAGE, 'Invalid Sitemap');
} |
++ |
_________________
Useful links :
SEO Forum || SEO Directory || SEO phpBB || SEO phpBB3 || Search
____________________
Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Référencement phpBB3 || Recherche |
|
| Back to top |
|
|
Joerg
Joined: 10 May 2007
Posts: 24
|
| Posted: Wed Jul 04, 2007 7:18 am Post subject: Re: No *.xml files |
|
|
Ok i will check the auth , and hope that i found the problem.......
because in the moment i run the google_forum.php with this part:
| Code: | if ( empty($forum_data) || (in_array($forum_id, $this->output_data['exclude_list'])) ) {
$this->mx_sitemaps_message_die(GENERAL_MESSAGE, 'Invalid Sitemap');
} |
REgards Jörg |
|
|
| Back to top |
|
|
dcz
Administrateur - Site Admin
Joined: 28 Apr 2006
Posts: 15242
|
|
| Back to top |
|
|
|
|
