phpBB mod Rewrite : mixed rewrite mod and persian UTF-8 encoding

mixed rewrite mod and persian UTF-8 encoding
Goto page Previous 1, 2, 3, 4, 5 Next

phpBB SEO » SEO Forum » phpBB mod Rewrite

Author

Message

AmirAbbas
phpBB SEO Team

Joined: 11 May 2006
Posts: 529
Location: IRAN

Posted: Thu Aug 03, 2006 4:30 am Post subject: Re: mixed rewrite mod and persian UTF-8 encoding

thanks a lot and my friend found another bug in advance rewrite mod (UTF- version when you search something , in result page all topic URLs have persian words in URL. please see this picture i think i must add format_url() somewhere again
_________________ چهار گوش - طراحی وب - مجله طراحی وب

dcz
Administrateur - Site Admin

Joined: 28 Apr 2006
Posts: 15129

Posted: Thu Aug 03, 2006 8:26 am Post subject: Re: mixed rewrite mod and persian UTF-8 encoding

Actually, this was a typo in the install I gave you.

The correct change for search.php are obviously -I forgot to pas the new code in this one) :

Code:

#
#-----[ OPEN ]------------------------------------------
#
#

search.php

#
#-----[ FIND ]------------------------------------------
#

   for($i = 0; $i < count($searchset); $i++)
   {

#
#-----[ AFTER, ADD ]------------------------------------------
#

      // www.phpBB-SEO.com SEO TOOLKIT BEGIN
      $seo_topic_name = format($searchset[$i]['topic_title']);
      $seo_forum_name = format($searchset[$i]['forum_name']);
      // www.phpBB-SEO.com SEO TOOLKIT END

We are close to something stable it seems Very Happy

_________________
Useful links :
SEO Forum || SEO Directory || SEO phpBB || SEO phpBB3 || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Référencement phpBB3 || Recherche

AmirAbbas
phpBB SEO Team

Joined: 11 May 2006
Posts: 529
Location: IRAN

Posted: Thu Aug 03, 2006 8:45 am Post subject: Re: mixed rewrite mod and persian UTF-8 encoding

Code:

// www.phpBB-SEO.com SEO TOOLKIT BEGIN
$seo_topic_name = format($searchset[$i]['topic_title']);
$seo_forum_name = format($searchset[$i]['forum_name']);
// www.phpBB-SEO.com SEO TOOLKIT END

i think you forgot _url
i add this part. it works Wink

DCZ wrote:

We are close to something stable it seems Very Happy

we are not close
we reached Wink

it completely stable. im using it Smile

_________________
چهار گوش - طراحی وب - مجله طراحی وب

dcz
Administrateur - Site Admin

Joined: 28 Apr 2006
Posts: 15129

Posted: Thu Aug 03, 2006 9:18 am Post subject: Re: mixed rewrite mod and persian UTF-8 encoding

amir abbas wrote:

i think you forgot _url
i add this part. it works Wink

Jeeeeezzz, I can't believe myself sometime. The hardest seems to write down install scripts Laughing

Anyway, good to hear.

I am glad I'll soon be able to release utf-8 version Very Happy

I'll do it while upgrading 0.0.2 phpBB mod rewrites. I am now designing standard to allow for many more mods support (smartor, some linkdb scripts ...), so I am thinking about how to best plug those.
Besides the 0.0.3 core base won't change much from what you have now Very Happy

AmirAbbas
phpBB SEO Team

Joined: 11 May 2006
Posts: 529
Location: IRAN

Posted: Wed Aug 16, 2006 8:47 am Post subject: Re: mixed rewrite mod and persian UTF-8 encoding

another part without format_url

Code:

// www.phpBB-SEO.com SEO TOOLKIT BEGIN
$seo_cat_name = $category_rows[$i]['cat_title'];
// www.phpBB-SEO.com SEO TOOLKIT END

im using aphrodite style. this style doesn't have category link. im designing a template for my self i found it yesterday

i think the utf package is complete now
i have installed it on two forum
there isn't any problem Wink

_________________
چهار گوش - طراحی وب - مجله طراحی وب

Last edited by AmirAbbas on Wed Aug 16, 2006 9:02 am; edited 1 time in total

dcz
Administrateur - Site Admin

Joined: 28 Apr 2006
Posts: 15129

Posted: Wed Aug 16, 2006 8:49 am Post subject: Re: mixed rewrite mod and persian UTF-8 encoding

amir abbas wrote:

i think the utf package is complete know
i have installed it on two forum
there isn't any problem Wink

Wonderful

AmirAbbas
phpBB SEO Team

Joined: 11 May 2006
Posts: 529
Location: IRAN

Posted: Thu Aug 17, 2006 6:08 am Post subject: Re: mixed rewrite mod and persian UTF-8 encoding

between all members of this community i think im the happiest one see this picture i have installed advance rewrite mod (utf-8 version) form 2nd august in only two week i have a link in first page of search result in google for mybb SEO i think this mod is definitely more effective that simple rewrite mod
_________________ چهار گوش - طراحی وب - مجله طراحی وب

dcz
Administrateur - Site Admin

Joined: 28 Apr 2006
Posts: 15129

Posted: Thu Aug 17, 2006 9:35 am Post subject: Re: mixed rewrite mod and persian UTF-8 encoding

Cool And yes, keyword injection is the best for sure ++
_________________ Useful links : SEO Forum \|\| SEO Directory \|\| SEO phpBB \|\| SEO phpBB3 \|\| Search ____________________ Liens Utiles : Forum référencement \|\| Annuaire référencement \|\| Référencement phpBB \|\| Référencement phpBB3 \|\| Recherche

AmirAbbas
phpBB SEO Team

Joined: 11 May 2006
Posts: 529
Location: IRAN

Posted: Sun Oct 29, 2006 3:20 pm Post subject: Re: mixed rewrite mod and persian UTF-8 encoding

i think i found another bug
see this part of code
in this topic http://forum.persia-cms.com/topic-vt81.html

Code:

pay attention to href part
the keywords are all the same
this problem is exist in all of my topics
you can check it online of forum.persia-cms.com and forum.irani.ch

i have some page indexed in yahoo in this way
the keyword in URLs is the same and just vt-XX numbers are different

_________________
چهار گوش - طراحی وب - مجله طراحی وب

dcz
Administrateur - Site Admin

Joined: 28 Apr 2006
Posts: 15129

Posted: Sun Oct 29, 2006 3:28 pm Post subject: Re: mixed rewrite mod and persian UTF-8 encoding

Sorry, this one was missed by quite some of us it seems. Anyway, I PM you the Zero duplicate code right now so this will get fixed in no time ++
_________________ Useful links : SEO Forum \|\| SEO Directory \|\| SEO phpBB \|\| SEO phpBB3 \|\| Search ____________________ Liens Utiles : Forum référencement \|\| Annuaire référencement \|\| Référencement phpBB \|\| Référencement phpBB3 \|\| Recherche

AmirAbbas
phpBB SEO Team

Joined: 11 May 2006
Posts: 529
Location: IRAN

Posted: Fri Nov 03, 2006 3:50 am Post subject: Re: mixed rewrite mod and persian UTF-8 encoding

Code:

its a first time is see this codes
you sent me advance rewrite mod UTF-8 and it wasn't included in that PM Smile

and there is a problem

when you haven't any english word in title of forums and topics the system will use word "empty" instead of words "topic" or "forum"

for example

Code:

and second problem

subforums has problem and the keywords are wrong for them
for example

Code:

these two forums are subforum. the keyword for first one must be "site-weblog" and for second one must be "topic" but as you can see they have problem

_________________
چهار گوش - طراحی وب - مجله طراحی وب

dcz
Administrateur - Site Admin

Joined: 28 Apr 2006
Posts: 15129

Posted: Fri Nov 03, 2006 10:29 am Post subject: Re: mixed rewrite mod and persian UTF-8 encoding

oups, true.

So first, simple sub forum updated which gives, for the UTF-8 version :

Code:

#
#-----[ OPEN ]------------------------------------------
#
includes/functions.php

#
#-----[ FIND ]------------------------------------------
#
//
// Add an array to $nav_links for the Mozilla navigation bar.
// 'chapter' and 'forum' can create multiple items, therefore we are using a nested array.
//
$nav_links['chapter forum'][$forum_rows[$k]['forum_id']] = array (
'url' => append_sid("viewforum.$phpEx?" . POST_FORUM_URL . "=" . $forum_rows[$k]['forum_id']),
'title' => $forum_rows[$k]['forum_name']
);

#
#-----[ REPLACE WITH ]------------------------------------------
#

//
// Add an array to $nav_links for the Mozilla navigation bar.
// 'chapter' and 'forum' can create multiple items, therefore we are using a nested array.
//
// www.phpBB-SEO.com SEO TOOLKIT BEGIN
$seo_forum_name = format_url($forum_rows[$k]['forum_name']);
// www.phpBB-SEO.com SEO TOOLKIT END
$nav_links['chapter forum'][$forum_rows[$k]['forum_id']] = array (
'url' => append_sid("viewforum.$phpEx?" . POST_FORUM_URL . "=" . $forum_rows[$k]['forum_id']),
'title' => $forum_rows[$k]['forum_name']
);

You could do the same with the regular nav links :

Code:

// www.phpBB-SEO.com SEO TOOLKIT BEGIN
$seo_forum_name = format_url($forum_rows[$j]['forum_name']);
// www.phpBB-SEO.com SEO TOOLKIT END
$nav_links['chapter forum'][$forum_rows[$j]['forum_id']] = array (

'url' => append_sid("viewforum.$phpEx?" . POST_FORUM_URL . "=" . $forum_rows[$j]['forum_id']),

Instead of :

Code:

$nav_links['chapter forum'][$forum_rows[$j]['forum_id']] = array (
// www.phpBB-SEO.com SEO TOOLKIT BEGIN
//'url' => append_sid("viewforum.$phpEx?" . POST_FORUM_URL . "=" . $forum_rows[$j]['forum_id']),
'url' => append_sid(format_url($forum_rows[$j]['forum_name']) . "-vf" . $forum_rows[$j]['forum_id'] . ".html") ,
// www.phpBB-SEO.com SEO TOOLKIT END

I think we sorted out everything now Very Happy

And don't worry, the zero dupe is with us Wink

AmirAbbas
phpBB SEO Team

Joined: 11 May 2006
Posts: 529
Location: IRAN

Posted: Fri Nov 03, 2006 1:08 pm Post subject: Re: mixed rewrite mod and persian UTF-8 encoding

it doesn't work

this code

Code:

doesn't any affect

and after applying this part:

Code:

all nav link will lose keywords again (keywords came back to wrong form shape)

_________________
چهار گوش - طراحی وب - مجله طراحی وب

dcz
Administrateur - Site Admin

Joined: 28 Apr 2006
Posts: 15129

Posted: Sat Nov 04, 2006 8:42 am Post subject: Re: mixed rewrite mod and persian UTF-8 encoding

Let's try the Global trick before I go for another method for utf-8 :

In the same file find :

Code:

function make_jumpbox_ref($action, $match_forum_id, &$forums_list)
{
// End Simple Subforums MOD
global $template, $userdata, $lang, $db, $nav_links, $phpEx, $SID;

And replace with :

Code:

function make_jumpbox_ref($action, $match_forum_id, &$forums_list)
{
// End Simple Subforums MOD
global $template, $userdata, $lang, $db, $nav_links, $phpEx, $SID, $seo_forum_name;

AmirAbbas
phpBB SEO Team

Joined: 11 May 2006
Posts: 529
Location: IRAN

Posted: Mon Nov 06, 2006 3:43 am Post subject: Re: mixed rewrite mod and persian UTF-8 encoding

thanks

i applied this one

Code:

#
#-----[ OPEN ]------------------------------------------
#

includes/function.php

#
#-----[ FIND ]------------------------------------------
#

$nav_links['chapter forum'][$forum_rows[$j]['forum_id']] = array (
'url' => append_sid("viewforum.$phpEx?" . POST_FORUM_URL . "=" . $forum_rows[$j]['forum_id']),

#
#-----[ BEFORE ADD ]------------------------------------------
#

// www.phpBB-SEO.com SEO TOOLKIT BEGIN
$seo_forum_name = format_url($forum_rows[$j]['forum_name']);
// www.phpBB-SEO.com SEO TOOLKIT END

#
#-----[ FIND ]------------------------------------------
#
//
// Add an array to $nav_links for the Mozilla navigation bar.
// 'chapter' and 'forum' can create multiple items, therefore we are using a nested array.
//
$nav_links['chapter forum'][$forum_rows[$k]['forum_id']] = array (
'url' => append_sid("viewforum.$phpEx?" . POST_FORUM_URL . "=" . $forum_rows[$k]['forum_id']),
'title' => $forum_rows[$k]['forum_name']
);

#
#-----[ REPLACE WITH ]------------------------------------------
#

//
// Add an array to $nav_links for the Mozilla navigation bar.
// 'chapter' and 'forum' can create multiple items, therefore we are using a nested array.
//
// www.phpBB-SEO.com SEO TOOLKIT BEGIN
$seo_forum_name = format_url($forum_rows[$k]['forum_name']);
// www.phpBB-SEO.com SEO TOOLKIT END
$nav_links['chapter forum'][$forum_rows[$k]['forum_id']] = array (
'url' => append_sid("viewforum.$phpEx?" . POST_FORUM_URL . "=" . $forum_rows[$k]['forum_id']),
'title' => $forum_rows[$k]['forum_name']
);

#
#-----[ FIND ]------------------------------------------
#

function make_jumpbox_ref($action, $match_forum_id, &$forums_list)
{
// End Simple Subforums MOD
global $template, $userdata, $lang, $db, $nav_links, $phpEx, $SID;

#
#-----[ REPLACE WITH ]------------------------------------------
#

function make_jumpbox_ref($action, $match_forum_id, &$forums_list)
{
// End Simple Subforums MOD
global $template, $userdata, $lang, $db, $nav_links, $phpEx, $SID, $seo_forum_name;

#
#-----[ OPEN ]------------------------------------------
#

viewtopic.php

#
#-----[ FIND ]------------------------------------------
#

$view_prev_topic_url = append_sid("viewtopic.$phpEx?" . POST_TOPIC_URL . "=$topic_id&view=previous");
$view_next_topic_url = append_sid("viewtopic.$phpEx?" . POST_TOPIC_URL . "=$topic_id&view=next");

//
// Mozilla navigation bar
//
$nav_links['prev'] = array(
'url' => $view_prev_topic_url,
'title' => $lang['View_previous_topic']
);
$nav_links['next'] = array(
'url' => $view_next_topic_url,
'title' => $lang['View_next_topic']
);

#
#-----[ REPLACE WITH ]------------------------------------------
#
// www.phpBB-SEO.com SEO TOOLKIT BEGIN
if ($userdata['session_logged_in']) {
$view_prev_topic_url = append_sid("viewtopic.$phpEx?" . POST_TOPIC_URL . "=$topic_id&view=previous");
$view_next_topic_url = append_sid("viewtopic.$phpEx?" . POST_TOPIC_URL . "=$topic_id&view=next");

//
// Mozilla navigation bar
//
$nav_links['prev'] = array(
'url' => $view_prev_topic_url,
'title' => $lang['View_previous_topic']
);
$nav_links['next'] = array(
'url' => $view_next_topic_url,
'title' => $lang['View_next_topic']
);
}
// www.phpBB-SEO.com SEO TOOLKIT END

it works

_________________
چهار گوش - طراحی وب - مجله طراحی وب

Display posts from previous:

	phpBB SEO » SEO Forum » phpBB mod Rewrite
Page 4 of 5	Goto page Previous 1, 2, 3, 4, 5 Next

Navigation