| :: |
| Author |
Message |
angelus
Joined: 10 Nov 2007 Posts: 20
|
Posted: Sat Dec 22, 2007 8:32 am Post subject: Topic evaluation Mod and Rewrite |
|
|
Hi
my english very bad..
phpBB3 mod Rewrite and Topic evaluation Mod integration please
thank you
generate evaluation link but 404 Not found
/resim-t21.html&evaluation=2 |
|
|
| Back to top |
|
 |
|
 |
SeO Administrateur - Site Admin

Joined: 15 Mar 2006 Posts: 3103
|
Posted: Sat Dec 22, 2007 9:07 am Post subject: Re: Topic evaluation Mod and Rewrite |
|
|
Open :
Find :
| Code: | | window.location.href = "'.append_sid($phpbb_root_path.'viewtopic.'.$phpEx, 'f='.$topic_data['forum_id'].'&t='.$topic_data['topic_id'].'&start='.intval($start)).'&evaluation="+value; |
Replace with :
| Code: | | window.location.href = "'.append_sid($phpbb_root_path.'viewtopic.'.$phpEx, 'f='.$topic_data['forum_id'].'&t='.$topic_data['topic_id'].'&start='.intval($start)).'?evaluation="+value; |
Assuming the use of & vs & was intended.
I don't fully get the why of this new coding fashion which keeps vars outside of the append_sid() function, but ... should do it
 |
_________________
Last edited by SeO on Sat Dec 22, 2007 11:26 am; edited 1 time in total |
|
| Back to top |
|
 |
angelus
Joined: 10 Nov 2007 Posts: 20
|
Posted: Sat Dec 22, 2007 10:43 am Post subject: Re: Topic evaluation Mod and Rewrite |
|
|
Thank you Seo
| Code: |
Parse error: syntax error, unexpected $end in /hosta/10052/mysite.net/htdocs/mods/viewtopic.php on line 109 |
109 line : ?> |
|
|
| Back to top |
|
 |
SeO Administrateur - Site Admin

Joined: 15 Mar 2006 Posts: 3103
|
Posted: Sat Dec 22, 2007 11:26 am Post subject: Re: Topic evaluation Mod and Rewrite |
|
|
Sorry my fault, I missed the JS part of the evaluation var.
Post edited, should work now. |
_________________
|
|
| Back to top |
|
 |
angelus
Joined: 10 Nov 2007 Posts: 20
|
Posted: Sat Dec 22, 2007 1:28 pm Post subject: Re: Topic evaluation Mod and Rewrite |
|
|
thank you Seo
| Code: | [phpBB Debug] PHP Notice: in file /phpbb_seo/phpbb_seo_class.php on line 265: parse_url(/portal.php?http://www.mysite.net/yonetim-f178/resim-t21.htmlevaluation=2&month=-1) [function.parse-url]: Unable to parse URL
[phpBB Debug] PHP Notice: in file /phpbb_seo/phpbb_seo_class.php on line 265: parse_url(/portal.php?http://www.mysite.net/yonetim-f178/resim-t21.htmlevaluation=2&month=1) [function.parse-url]: Unable to parse URL
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3535: Cannot modify header information - headers already sent by (output started at /includes/functions.php:2954)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3537: Cannot modify header information - headers already sent by (output started at /includes/functions.php:2954)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3538: Cannot modify header information - headers already sent by (output started at /includes/functions.php:2954)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3539: Cannot modify header information - headers already sent by (output started at /includes/functions.php:2954)
|
phpbb_seo_class.php on line 265: $parsed_url = parse_url($this->url); |
|
|
| Back to top |
|
 |
dcz Administrateur - Site Admin

Joined: 28 Apr 2006 Posts: 13354
|
|
| Back to top |
|
 |
angelus
Joined: 10 Nov 2007 Posts: 20
|
Posted: Sat Dec 22, 2007 1:49 pm Post subject: Re: Topic evaluation Mod and Rewrite |
|
|
hi dcz , thank you
last request
| Code: |
Parse error: syntax error, unexpected ',' in /hosta/10052/mysite.net/htdocs/mods/viewtopic.php on line 79 |
line 79: window.location.href = "'. ( strpos($eval_url = append_sid($phpbb_root_path.'viewtopic.'.$phpEx, |
|
|
| Back to top |
|
 |
dcz Administrateur - Site Admin

Joined: 28 Apr 2006 Posts: 13354
|
|
| Back to top |
|
 |
angelus
Joined: 10 Nov 2007 Posts: 20
|
Posted: Sat Dec 22, 2007 2:09 pm Post subject: Re: Topic evaluation Mod and Rewrite |
|
|
thank you dcz
waiting or uninstall this mod  |
|
|
| Back to top |
|
 |
dcz Administrateur - Site Admin

Joined: 28 Apr 2006 Posts: 13354
|
|
| Back to top |
|
 |
angelus
Joined: 10 Nov 2007 Posts: 20
|
Posted: Sat Dec 22, 2007 2:23 pm Post subject: Re: Topic evaluation Mod and Rewrite |
|
|
| dcz wrote: | | angelus wrote: |
waiting or uninstall this mod  |
What do you mean ? |
Topic evaluation Mod = uninstall ...
Thank you, dcz |
|
|
| Back to top |
|
 |
dcz Administrateur - Site Admin

Joined: 28 Apr 2006 Posts: 13354
|
|
| Back to top |
|
 |
angelus
Joined: 10 Nov 2007 Posts: 20
|
Posted: Sat Dec 22, 2007 2:47 pm Post subject: Re: Topic evaluation Mod and Rewrite |
|
|
| dcz wrote: | | But, is the last fix working in the end ? |
sorry dcz my english very bad but..
portal.php
| Code: | [phpBB Debug] PHP Notice: in file /phpbb_seo/phpbb_seo_class.php on line 265: parse_url(/portal.php?http://www.mysite.net/yonetim-f178/resim-t21.htmlevaluation=2&month=-1) [function.parse-url]: Unable to parse URL
[phpBB Debug] PHP Notice: in file /phpbb_seo/phpbb_seo_class.php on line 265: parse_url(/portal.php?http://www.mysite.net/yonetim-f178/resim-t21.htmlevaluation=2&month=1) [function.parse-url]: Unable to parse URL |
-http://www.mysite.net/?http://www.mysite.net/yonetim-f178/resim-t21.htmlevaluation=2
Viewtopic page
Topic evaluate link (star image) : mouse click = redirect portal.php |
|
|
| Back to top |
|
 |
dcz Administrateur - Site Admin

Joined: 28 Apr 2006 Posts: 13354
|
|
| Back to top |
|
 |
angelus
Joined: 10 Nov 2007 Posts: 20
|
Posted: Sun Dec 23, 2007 9:09 am Post subject: Re: Topic evaluation Mod and Rewrite |
|
|
| dcz wrote: | Erf, I gave a try on installing this one on 3.0.0, and failed
Will try again later, keep faith  |
ok, thank you dcz  |
|
|
| Back to top |
|
 |
|
|