phpBB SEO
Boards
Directory  
SEO  
Downloads
  phpBB SEO : Search Engine Optimization, Directory, Forums  
Index
Forums
Annuaire
Référencement
Télécharger
 
  Search Rechercher
    Register
Username :  Password :  Log me on automatically each visit  
S'enregistrer  
 
   
Topic evaluate mod in Portal XL 4.0

 
Post new topic   Reply to topic    phpBB SEO » SEO Forum  » phpBB3 mod Rewrite
::  
Author Message
DaMysterious



Joined: 10 Mar 2008
Posts: 9
Location: The Netherlands

Topic evaluate mod in Portal XL 4.0Posted: Sat Mar 29, 2008 9:09 am    Post subject: Topic evaluate mod in Portal XL 4.0

A problem did arise with our internal Topic evaluate mod.

When visiting a topic eg. http://damysterious.xs4all.nl/plusxl40/how-to-show-articles-in-kb-index-page-t1420.html and try to evaluate a topic the page will open with http://damysterious.xs4all.nl/plusxl40/how-to-show-articles-in-kb-index-page-t1420.html&evaluation=5 which causes a 404 error.

Any thoughts about how to solve or bypass this?
Back to top
dcz
Administrateur - Site Admin
Administrateur - Site Admin


Joined: 28 Apr 2006
Posts: 13354

Topic evaluate mod in Portal XL 4.0Posted: Mon Mar 31, 2008 8:53 am    Post subject: Re: Topic evaluate mod in Portal XL 4.0

That's the odd habit within phpBB3 code, many times, append_sid is often not used to pass all variables.

Things like :
Code:
$viewtopic_url = append_sid(blabla);

and later :
Code:
$some_action_url = $viewtopic_url . '&var=' . $val;

Of course, doing this cas save some calls to append_sid, but IMHO, the code should still at least check if the url contains a question mark or not before using the &.

To fix these type of links, you can either use the full story again, eg :

Code:
$some_action_url = append_sid(blabla . '&var=' . $val);


or just check the question mark :
Code:
$some_action_url = $viewtopic_url . (strpos($viewtopic_url, '?') !== false ? '&' : '?') . 'var=' . $val;


You should be able to easily find the guilty link in the code looking for "evaluation=" within the php files involved.

++

_________________
Useful links :
SEO Forum || SEO Directory || SEO phpBB || SEO phpBB3 || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Référencement phpBB3 || Recherche
Back to top
Visit poster's website
angelus



Joined: 10 Nov 2007
Posts: 20

Topic evaluate mod in Portal XL 4.0Posted: Tue Apr 01, 2008 8:55 pm    Post subject: Re: Topic evaluate mod in Portal XL 4.0

http://www.phpbb-seo.com/boards/phpbb3-mod-rewrite/discussions-vt1908.html#13350
Back to top
DaMysterious



Joined: 10 Mar 2008
Posts: 9
Location: The Netherlands

Topic evaluate mod in Portal XL 4.0Posted: Sat Apr 05, 2008 6:43 am    Post subject: Re: Topic evaluate mod in Portal XL 4.0

Thanks both of you, problem could be solved.
Back to top
Display posts from previous:   
Post new topic   Reply to topic    phpBB SEO » SEO Forum  » phpBB3 mod Rewrite
Page 1 of 1

Navigation Similar Topics

Jump to: