phpBB SEO
Boards
Directory  
SEO  
Downloads
  phpBB SEO : Search Engine Optimization, Directory, Forums  
Index
Forums
Annuaire
Référencement
Télécharger
 
  Search Rechercher
    Register
Username :  Password :  Log me on automatically each visit  
S'enregistrer  
 
   
0.4.0 bug with mark topic for guest

 
Post new topic   Reply to topic    phpBB SEO » SEO Forum  » phpBB3 SEO TooLKit  » phpBB3 Zero duplicate
::  
Author Message
zenek



Joined: 22 Dec 2007
Posts: 3

0.4.0 bug with mark topic for guestPosted: Tue Dec 25, 2007 12:50 pm    Post subject: 0.4.0 bug with mark topic for guest

viewforum.php?f=1&mark=topics doesn't work for guests after installing this mod
Back to top
SeO
Administrateur - Site Admin
Administrateur - Site Admin


Joined: 15 Mar 2006
Posts: 3301

0.4.0 bug with mark topic for guestPosted: Tue Dec 25, 2007 3:29 pm    Post subject: Re: 0.4.0 bug with mark topic for guest

Are guest supposed to be able to mark topics ?

Here, the mods redirect these for guest for such links to still matter for bots in the good way, but, this behaviour could be customized in case you need it.

_________________
phpBB SEO || SEO Forum || Forum Référencement
GYM Sitemap & RSS for phpBB3 has been released ! || GYM Sitemap & RSS for phpBB3 est disponible !
Back to top
zenek



Joined: 22 Dec 2007
Posts: 3

0.4.0 bug with mark topic for guestPosted: Tue Dec 25, 2007 6:07 pm    Post subject: Re: 0.4.0 bug with mark topic for guest

Quote:
Are guest supposed to be able to mark topics ?

yes, guests can mark topics in phpbb3 if it's enabled in admin control panel
Back to top
dcz
Administrateur - Site Admin
Administrateur - Site Admin


Joined: 28 Apr 2006
Posts: 13607

0.4.0 bug with mark topic for guestPosted: Tue Dec 25, 2007 7:04 pm    Post subject: Re: 0.4.0 bug with mark topic for guest

I did not look at this thoroughly, but I did not find how guest could watch a topic.
function watch_topic_forum refers to $can_watch to build the link, but it seems to only be true for logged in users.

++

_________________
Useful links :
SEO Forum || SEO Directory || SEO phpBB || SEO phpBB3 || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Référencement phpBB3 || Recherche
Back to top
Visit poster's website
zenek



Joined: 22 Dec 2007
Posts: 3

0.4.0 bug with mark topic for guestPosted: Wed Dec 26, 2007 11:27 am    Post subject: Re: 0.4.0 bug with mark topic for guest

there is an option in adm/index.php?i=board&mode=load

Enable topic marking for guests:
Stores read/unread status information for guests. If disabled posts are always read for guests.
Back to top
dcz
Administrateur - Site Admin
Administrateur - Site Admin


Joined: 28 Apr 2006
Posts: 13607

0.4.0 bug with mark topic for guestPosted: Wed Dec 26, 2007 3:22 pm    Post subject: Re: 0.4.0 bug with mark topic for guest

All right, missed it, and got it now.

In viewforum.php, just replace :

Code:
// www.phpBB-SEO.com SEO TOOLKIT BEGIN -> Zero dupe
if ($forum_data['forum_topics_per_page']) {
   $config['topics_per_page'] = $forum_data['forum_topics_per_page'];
}
$phpbb_seo->seo_opt['zero_dupe']['start'] = $phpbb_seo->seo_chk_start( $start, $config['topics_per_page'] );
$phpbb_seo->page_url = str_replace('&', '&', append_sid("viewforum.$phpEx", "f=$forum_id&st=$sort_days&sk=$sort_key&sd=$sort_dir&start=" . $phpbb_seo->seo_opt['zero_dupe']['start'] . (!empty($_SID) ? '&sid=' . $_SID : '')));
if ( $user->data['is_registered'] ) {
   $phpbb_seo->seo_cond( !isset($_GET['explain']) || $mark_read != 'topics' || $mark_read != 'forums');
   $phpbb_seo->seo_cond( (utf8_strpos($phpbb_seo->seo_path['uri'], 'watch=') === FALSE) );
   $phpbb_seo->seo_cond( (utf8_strpos($phpbb_seo->seo_path['uri'], 'mark=') === FALSE) );
}
if ( !$phpbb_seo->seo_opt['zero_dupe']['strict'] ) { // strict mode is here a bit faster
   if ( !$user->data['is_registered'] ) {
      $phpbb_seo->seo_cond( isset($_GET['explain']) || $mark_read == 'topics' || $mark_read == 'forums', false, 'do' );
      $phpbb_seo->seo_cond( (utf8_strpos($phpbb_seo->seo_path['uri'], 'watch=') !== FALSE), false, 'do');
      $phpbb_seo->seo_cond( (utf8_strpos($phpbb_seo->seo_path['uri'], 'mark=') !== FALSE), false, 'do');
   }
}
$phpbb_seo->seo_chk_dupe($phpbb_seo->seo_path['uri'], $phpbb_seo->page_url);
// www.phpBB-SEO.com SEO TOOLKIT END -> Zero dupe


with :

Code:
// www.phpBB-SEO.com SEO TOOLKIT BEGIN -> Zero dupe
if ($forum_data['forum_topics_per_page']) {
   $config['topics_per_page'] = $forum_data['forum_topics_per_page'];
}
$phpbb_seo->seo_opt['zero_dupe']['start'] = $phpbb_seo->seo_chk_start( $start, $config['topics_per_page'] );
$phpbb_seo->page_url = str_replace('&', '&', append_sid("viewforum.$phpEx", "f=$forum_id&st=$sort_days&sk=$sort_key&sd=$sort_dir&start=" . $phpbb_seo->seo_opt['zero_dupe']['start'] . (!empty($_SID) ? '&sid=' . $_SID : '')));
$seo_mark = ($mark_read == 'topics' || $mark_read == 'forums');
if ( $user->data['is_registered'] ) {
   $phpbb_seo->seo_cond( !isset($_GET['explain']) || $seo_mark);
   $phpbb_seo->seo_cond( (utf8_strpos($phpbb_seo->seo_path['uri'], 'watch=') === FALSE) );
   $phpbb_seo->seo_cond( !$seo_mark );
} elseif ( $config['load_anon_lastread'] ) {
   $phpbb_seo->seo_cond( !$seo_mark );
} else {
   $phpbb_seo->seo_cond( $seo_mark, false, 'do' );
}
if ( !$phpbb_seo->seo_opt['zero_dupe']['strict'] ) { // strict mode is here a bit faster
   if ( !$user->data['is_registered'] ) {
      $phpbb_seo->seo_cond( isset($_GET['explain']), false, 'do' );
      if ( $config['load_anon_lastread'] ) {
         $phpbb_seo->seo_cond( !$seo_mark );
      } else {
         $phpbb_seo->seo_cond( $seo_mark, false, 'do' );
      }
      $phpbb_seo->seo_cond( (utf8_strpos($phpbb_seo->seo_path['uri'], 'watch=') !== FALSE), false, 'do');
   }
}
$phpbb_seo->seo_chk_dupe($phpbb_seo->seo_path['uri'], $phpbb_seo->page_url);
// www.phpBB-SEO.com SEO TOOLKIT END -> Zero dupe


should be our fix Wink

++

_________________
Useful links :
SEO Forum || SEO Directory || SEO phpBB || SEO phpBB3 || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Référencement phpBB3 || Recherche
Back to top
Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    phpBB SEO » SEO Forum  » phpBB3 SEO TooLKit  » phpBB3 Zero duplicate
Page 1 of 1

Navigation Similar Topics

Jump to: