I don't use prosilver, I am using subsilver2 (broken images)

phpBB3 SEO Advanced mod Rewrite support forum.
This mods performs URL rewriting for phpBB, injecting forums and topic titles in their URLs.

Moderator: Moderators

I don't use prosilver, I am using subsilver2 (broken images)

Postby tom11011 » Tue Jun 05, 2007 6:31 pm

I use the subsilver2 template, how do I complete the mod since the directions specify prosilver??

I have refreshed my template and the rankings and avatars have a broken link.

thanks.
Last edited by tom11011 on Wed Jun 06, 2007 11:55 am, edited 1 time in total.
tom11011
 
Posts: 9
Joined: Tue Jun 05, 2007 6:28 pm

Advertisement

Postby tom11011 » Wed Jun 06, 2007 12:43 am

hi, please look at www.decisionheight.com/forums into the posts to see that the avatar and rank gifs are broken links. How do I fix these now?
tom11011
 
Posts: 9
Joined: Tue Jun 05, 2007 6:28 pm

Postby tom11011 » Wed Jun 06, 2007 12:47 am

After choosing "Bump Topic" the avatar and rank images displayed momentarily but when I went back in the regular way, they were broken images again.
tom11011
 
Posts: 9
Joined: Tue Jun 05, 2007 6:28 pm

Postby dcz » Wed Jun 06, 2007 7:13 pm

Try to edit your message next time, no real need to reply to yourself.

Anyway, this does not come from the template, it's an genuine bug you've found out.

And here is the fix, open :

Code: Select all
includes/function_display.php


Find :
Code: Select all
function get_user_rank($user_rank, $user_posts, &$rank_title, &$rank_img, &$rank_img_src)
{
   global $ranks, $config;


After add :
Code: Select all
   // www.phpBB-SEO.com SEO TOOLKIT BEGIN
   global $phpbb_seo;
   // www.phpBB-SEO.com SEO TOOLKIT END


Find :
Code: Select all
      $rank_img = (!empty($ranks['special'][$user_rank]['rank_image'])) ? '<img src="' . $config['ranks_path'] . '/' . $ranks['special'][$user_rank]['rank_image'] . '" alt="' . $ranks['special'][$user_rank]['rank_title'] . '" title="' . $ranks['special'][$user_rank]['rank_title'] . '" />' : '';
      $rank_img_src = (!empty($ranks['special'][$user_rank]['rank_image'])) ? $config['ranks_path'] . '/' . $ranks['special'][$user_rank]['rank_image'] : '';


Replace with :
Code: Select all
      // www.phpBB-SEO.com SEO TOOLKIT BEGIN
      $rank_img = (!empty($ranks['special'][$user_rank]['rank_image'])) ? '<img src="' . $phpbb_seo->seo_path['phpbb_url']. trim($config['ranks_path'], '/') . '/' . $ranks['special'][$user_rank]['rank_image'] . '" alt="' . $ranks['special'][$user_rank]['rank_title'] . '" title="' . $ranks['special'][$user_rank]['rank_title'] . '" />' : '';
      $rank_img_src = (!empty($ranks['special'][$user_rank]['rank_image'])) ? $phpbb_seo->seo_path['phpbb_url']. trim($config['ranks_path'], '/') . '/' . $ranks['special'][$user_rank]['rank_image'] : '';
      // www.phpBB-SEO.com SEO TOOLKIT END


find :
Code: Select all
               $rank_img = (!empty($rank['rank_image'])) ? '<img src="' . $config['ranks_path'] . '/' . $rank['rank_image'] . '" alt="' . $rank['rank_title'] . '" title="' . $rank['rank_title'] . '" />' : '';
               $rank_img_src = (!empty($rank['rank_image'])) ? $config['ranks_path'] . '/' . $rank['rank_image'] : '';


Replace with :

Code: Select all
               // www.phpBB-SEO.com SEO TOOLKIT BEGIN
               $rank_img = (!empty($rank['rank_image'])) ? '<img src="' . $phpbb_seo->seo_path['phpbb_url'] . trim($config['ranks_path'], '/') . '/' . $rank['rank_image'] . '" alt="' . $rank['rank_title'] . '" title="' . $rank['rank_title'] . '" />' : '';
               $rank_img_src = (!empty($rank['rank_image'])) ? $phpbb_seo->seo_path['phpbb_url'] . trim($config['ranks_path'], '/') . '/' . $rank['rank_image'] : '';
               // www.phpBB-SEO.com SEO TOOLKIT END


Find :

Code: Select all
function get_user_avatar($avatar, $avatar_type, $avatar_width, $avatar_height, $alt = 'USER_AVATAR')
{
   global $user, $config, $phpbb_root_path, $phpEx;


After add :
Code: Select all
   // www.phpBB-SEO.com SEO TOOLKIT BEGIN
   global $phpbb_seo;
   // www.phpBB-SEO.com SEO TOOLKIT END


Find :
Code: Select all
      case AVATAR_UPLOAD:
         $avatar_img = $phpbb_root_path . "download.$phpEx?avatar=";
      break;

      case AVATAR_GALLERY:
         $avatar_img = $phpbb_root_path . $config['avatar_gallery_path'] . '/';
      break;


Replace with :
Code: Select all
      // www.phpBB-SEO.com SEO TOOLKIT BEGIN
      case AVATAR_UPLOAD:
         $avatar_img = $phpbb_seo->seo_path['phpbb_url'] . "download.$phpEx?avatar=";
      break;

      case AVATAR_GALLERY:
         $avatar_img = $phpbb_seo->seo_path['phpbb_url'] . $config['avatar_gallery_path'] . '/';
         break;
      // www.phpBB-SEO.com SEO TOOLKIT END


Should be it.

That's what's make the phpBB3 mod rewrite a bit longer to install than the phpBB2's, since we are playing with virtual folders, we need absolute links everywhere, but these are really unlikely to be concerned by any update.

++

[EDIT] Added all the last code changes there.
Last edited by dcz on Sat Jun 09, 2007 11:16 am, edited 1 time in total.
Useful links :
SEO Forum || SEO Directory || SEO phpBB || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Recherche
dcz
Admin
Admin
 
Posts: 21238
Joined: Fri Apr 28, 2006 9:03 pm

Postby tom11011 » Wed Jun 06, 2007 7:54 pm

Hi, it fixed the avatar but my ranks still do not display.

thanks.
tom11011
 
Posts: 9
Joined: Tue Jun 05, 2007 6:28 pm

Postby dcz » Wed Jun 06, 2007 9:26 pm

Ooops, forgot one part on the road, additionnaly find (in the same file) :

Code: Select all
      $rank_img = (!empty($ranks['special'][$user_rank]['rank_image'])) ? '<img src="' . $config['ranks_path'] . '/' . $ranks['special'][$user_rank]['rank_image'] . '" alt="' . $ranks['special'][$user_rank]['rank_title'] . '" title="' . $ranks['special'][$user_rank]['rank_title'] . '" />' : '';
      $rank_img_src = (!empty($ranks['special'][$user_rank]['rank_image'])) ? $config['ranks_path'] . '/' . $ranks['special'][$user_rank]['rank_image'] : '';


Replace with :

Code: Select all
      // www.phpBB-SEO.com SEO TOOLKIT BEGIN
      $rank_img = (!empty($ranks['special'][$user_rank]['rank_image'])) ? '<img src="' . $phpbb_seo->seo_path['phpbb_url']. trim($config['ranks_path'], '/') . $config['ranks_path'] . '/' . $ranks['special'][$user_rank]['rank_image'] . '" alt="' . $ranks['special'][$user_rank]['rank_title'] . '" title="' . $ranks['special'][$user_rank]['rank_title'] . '" />' : '';
      $rank_img_src = (!empty($ranks['special'][$user_rank]['rank_image'])) ? $phpbb_seo->seo_path['phpbb_url']. trim($config['ranks_path'], '/') . '/' . $ranks['special'][$user_rank]['rank_image'] : '';
      // www.phpBB-SEO.com SEO TOOLKIT END


It looks as well that another chage is required, find :

Code: Select all
               $rank_img = (!empty($rank['rank_image'])) ? '<img src="' . $config['ranks_path'] . '/' . $rank['rank_image'] . '" alt="' . $rank['rank_title'] . '" title="' . $rank['rank_title'] . '" />' : '';
               // www.phpBB-SEO.com SEO TOOLKIT BEGIN


Replace with :
Code: Select all
               // www.phpBB-SEO.com SEO TOOLKIT BEGIN
               $rank_img = (!empty($rank['rank_image'])) ? '<img src="' . $phpbb_seo->seo_path['phpbb_url'] . trim($config['ranks_path'], '/') . '/' . $rank['rank_image'] . '" alt="' . $rank['rank_title'] . '" title="' . $rank['rank_title'] . '" />' : '';


should be all good now ;)

++
Useful links :
SEO Forum || SEO Directory || SEO phpBB || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Recherche
dcz
Admin
Admin
 
Posts: 21238
Joined: Fri Apr 28, 2006 9:03 pm

Postby tom11011 » Wed Jun 06, 2007 10:49 pm

Hi, the image was still broken.

Just to be clear, here is how I editted the code:

Code: Select all
//                                      $rank_img = (!empty($rank['rank_image'])) ? '<img src="' . $config['ranks_path'] . '/' . $rank['rank_image'] . '" alt="' . $rank['rank_title'] . '" title="' . $rank['rank_title'] . '" />' : '';
//                                      $rank_img_src = (!empty($rank['rank_image'])) ? $config['ranks_path'] . '/' . $rank['rank_image'] : '';

// www.phpBB-SEO.com SEO TOOLKIT BEGIN
        $rank_img = (!empty($rank['rank_image'])) ? '<img src="' . $phpbb_seo->seo_path['phpbb_url'] . trim($config['ranks_path'], '/') . '/' . $rank['rank_image'] . '" alt="' . $rank['rank_title'] . '" title="' . $rank['rank_title'] . '" />' : '';
       $rank_img = (!empty($ranks['special'][$user_rank]['rank_image'])) ? '<img src="' . $phpbb_seo->seo_path['phpbb_url']. trim($config['ranks_path'], '/') . $config['ranks_path'] . '/' . $ranks['special'][$user_rank]['rank_image'] . '" alt="' . $ranks['special'][$user_rank]['rank_title'] . '" title="' . $ranks['special'][$user_rank]['rank_title'] . '" />' : '';
        $rank_img_src = (!empty($ranks['special'][$user_rank]['rank_image'])) ? $phpbb_seo->seo_path['phpbb_url']. trim($config['ranks_path'], '/') . '/' . $ranks['special'][$user_rank]['rank_image'] : '';
// www.phpBB-SEO.com SEO TOOLKIT END
tom11011
 
Posts: 9
Joined: Tue Jun 05, 2007 6:28 pm

Postby tom11011 » Thu Jun 07, 2007 3:34 pm

any other ideas?
tom11011
 
Posts: 9
Joined: Tue Jun 05, 2007 6:28 pm

Postby dcz » Sat Jun 09, 2007 11:17 am

I just edited my post to put together all the correct code changes, should be ok now.

++
Useful links :
SEO Forum || SEO Directory || SEO phpBB || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Recherche
dcz
Admin
Admin
 
Posts: 21238
Joined: Fri Apr 28, 2006 9:03 pm

Postby tom11011 » Sun Jun 10, 2007 1:14 am

Works! Thanks.
tom11011
 
Posts: 9
Joined: Tue Jun 05, 2007 6:28 pm

Postby Lubor » Fri Jun 15, 2007 8:46 pm

http://pc-war.sk/pre-administratorov-f19/styles/subsilver2/theme/images/logo_phpBB_med.gif
these is do not good and smilies
Lubor
PR0
PR0
 
Posts: 52
Joined: Tue Feb 13, 2007 6:37 pm
Location: Slovakia,Bratislava

Postby Lubor » Fri Jun 15, 2007 9:50 pm

because fro gives pre-administratorov-f19 , after it accordingly isn't .
:shock:
Lubor
PR0
PR0
 
Posts: 52
Joined: Tue Feb 13, 2007 6:37 pm
Location: Slovakia,Bratislava

Postby Lubor » Fri Jun 15, 2007 10:12 pm

Captcha image is addle.
This isn´t possible :? :!: All along are problems with SEO mod :cry:
Lubor
PR0
PR0
 
Posts: 52
Joined: Tue Feb 13, 2007 6:37 pm
Location: Slovakia,Bratislava

Postby dcz » Fri Jun 15, 2007 10:32 pm

Ľubor wrote:Captcha image is addle.
This isn´t possible :? :!: All along are problems with SEO mod :cry:


Well, next time you feel happy, make sure to come here to say hello ;)

I think you are a bit unfair here, because phpBB3 is RC thus not stable and already has quite some known bugs(166 tickets right now). Same with the mod Rewrite, it's RC, not stable.
phpBB3 introduces many new features I'm sure you do not even know about already.
The advanced phpBB3 SEO mod rewrite is at least promising, and far from being the mod that's making it impossible to go online now, if you cannot wait for a stable phpBB3 release.
I already spent some good time to help you, with the czech characters, the hard part being to understand you well and to deal with characters I have never used, you did not even provide with a full list. But I did it, and did I read "thanks you" some where ?
And this character thing was not a bug, just some more handling just for you and the Czech and Slovak who would benefit from it too.

Did I mention this is all done for free ?

So please, if you feel blue, don't blame other, especially when they help you out.

Anyway, I do not have the two bugs you last talked about, I'll look into it, but it's very possible that these two do not come from the mod rewrite.

++
Useful links :
SEO Forum || SEO Directory || SEO phpBB || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Recherche
dcz
Admin
Admin
 
Posts: 21238
Joined: Fri Apr 28, 2006 9:03 pm


Return to Advanced SEO URL

 


  • Related topics
    Replies
    Views
    Last post

Who is online

Users browsing this forum: micvegas and 14 guests