Hi,

first of all - Guys, you rock!!! This premod for Gold phpBB3 is great.

But still... the pagination links don't work when I remove the .html from the URLs. Please, have a look: http://forum.seochat.sk/sem-marketing-pre-vyhladavace/

The pagination link is rewritten well, but the page does not show anything: http://forum.seochat.sk/ludia-zatial-ad ... t4/page10/

Thank you guys and MERRY CHRISTMAS!

You need to generate a new .htaccess after you change the suffixes.

++

Arrrrrr , I forgot to do that

Thanks.

i have this problem too.but only in viewforum
Pagination dont work it give me doent exist error 404. Where can be problem?
bad url cashing, .htaccsess,...?And i have install mod again it wasnt update

So, is it working now ?

Looks like you as well needed to generate a new .htaccess

no it doesnt. I have brand new instalation becuase som problem whit update so i need it install again.Everythinks work perfeckt but only for example here
http://www.phpbb3.sk/forum/phpbb3-podpora.html when you cluick on pagination show 404 error so i dnot know where can be mistake.I have looked again on viewforum code wich i have added but it is ok just like in install guide so that is coreckt is it possible that in installation is error in viewforum pagination?Try this someone else?In viewtopic works good only in viewforum
thx for help and some idea how to fix it

I see, actually, pagination is not rewritten at all.

I think you made some mistake while updating the includes/functions.php and the includes/functions_display.php files (functions generate_pagination and topic_generate_pagination).

Please double check.

++

No everythink looks fine

Code: Select all

#
#-----[ FIND ]------------------------------------------
#

/**
* Generate topic pagination
*/
function topic_generate_pagination($replies, $url)
{
   global $config, $user;

#
#-----[ AFTER, ADD ]------------------------------------------
#

   // www.phpBB-SEO.com SEO TOOLKIT BEGIN
   global $phpbb_seo, $phpEx;
   // www.phpBB-SEO.com SEO TOOLKIT END

and

Code: Select all

#
#-----[ FIND ]------------------------------------------
#

function generate_pagination($base_url, $num_items, $per_page, $start_item, $add_prevnext_text = false, $tpl_prefix = '')
{
   global $template, $user;

#
#-----[ AFTER, ADD]------------------------------------------
#

   // www.phpBB-SEO.com SEO TOOLKIT BEGIN
   global $phpbb_seo, $phpEx;
   // www.phpBB-SEO.com SEO TOOLKIT END

this is coreckt
only here

Code: Select all

#
#-----[ FIND ]------------------------------------------
#

   }
   else
   {
      $pagination = '';
   }

#
#-----[ BEFORE, ADD ]------------------------------------------
#

      // www.phpBB-SEO.com SEO TOOLKIT BEGIN
      if (is_object($phpbb_seo) && strpos($pagination, '.' . $phpEx) === FALSE) {
         static $pagin_find = array( '`(\.[a-z0-9]+)([\w\#$%&~.\-;:=,?@+]*)&start=([0-9]+)`i', '`/([\w\#$%&~.\-;:=,?@+]*)&start=([0-9]+)`i' );
         static $pagin_replace = array();
         if (empty($pagin_replace)) {
            $pagin_replace = array( $phpbb_seo->seo_delim['start'] . '\\3\\1\\2', '/' . $phpbb_seo->seo_static['pagination'] . '\\2' . $phpbb_seo->seo_ext['pagination'] .'\\1' );
         }
         $pagination = str_replace( '&start=0', '', $pagination );
         $pagination = preg_replace( $pagin_find, $pagin_replace, $pagination );
      }
      // www.phpBB-SEO.com SEO TOOLKIT END

if i add it too close to }
else
{ show me error so i added there one line

i have copied files (function and functions_display.php) from your premod pack but it is same.No change.I think mistake must be here in those 2 files but where?DCZ did you try it this situation if is it work?on viewforum?

Grr, this is indeed a bug !!

It was tricky to find out, because it only conserns domains with ".php" in it, such as -www.phpbb3.sk or phpbb3.phpbb-seo.net !

I had not tested pagination on such domains, my fault, sorry.

Anyway, here is the fix, which will lead us to an update very soon :

Code: Select all

#
#-----[ OPEN ]------------------------------------------
#

includes/functions.php

#
#-----[ FIND ]------------------------------------------
#

   // www.phpBB-SEO.com SEO TOOLKIT BEGIN
   $prev =  ($on_page == 1) ? '' : $base_url . "{$url_delim}start=" . (($on_page - 2) * $per_page);
   $next = ($on_page == $total_pages) ? '' : $base_url . "{$url_delim}start=" . ($on_page * $per_page);
   if (is_object($phpbb_seo) && strpos($page_string, '.' . $phpEx) === FALSE) {
      static $pagin_find = array();
      static $pagin_replace = array();
      static $prev_find = array();
      if (empty($pagin_replace)) {
         $pagin_find = array('`(\.[a-z0-9]+)([\w\#$%&~\-;:=,?@+]*)(&|\?)start=([0-9]+)`i', '`/([\w\#$%&~\-;:=,?@+]*)(&|\?)start=([0-9]+)`i' );
         $pagin_replace = array( $phpbb_seo->seo_delim['start'] . '\\4\\1\\2', '/' . $phpbb_seo->seo_static['pagination'] . '\\3' . $phpbb_seo->seo_ext['pagination'] . '\\1' );
         $prev_find = array($phpbb_seo->seo_delim['start'] . '0', $phpbb_seo->seo_static['pagination'] . '0' . $phpbb_seo->seo_ext['pagination']);
      }
      $page_string = str_replace($url_delim . 'start=0', '', $page_string);
      $page_string = preg_replace($pagin_find, $pagin_replace, $page_string);
      $prev = preg_replace($pagin_find, $pagin_replace, $prev);
      $prev = str_replace($prev_find, '', $prev);
      $next = preg_replace( $pagin_find, $pagin_replace, $next);
   }
   $template->assign_vars(array(
      $tpl_prefix . 'BASE_URL'   => $base_url,
      'A_' . $tpl_prefix . 'BASE_URL'   => addslashes($base_url),
      $tpl_prefix . 'PER_PAGE'   => $per_page,
      $tpl_prefix . 'PREVIOUS_PAGE'   => $prev,
      $tpl_prefix . 'NEXT_PAGE'   => $next,
      $tpl_prefix . 'TOTAL_PAGES'   => $total_pages)
   );
   // www.phpBB-SEO.com SEO TOOLKIT END

#
#-----[ REPLACE WITH ]------------------------------------------
#

   // www.phpBB-SEO.com SEO TOOLKIT BEGIN
   $prev =  ($on_page == 1) ? '' : $base_url . "{$url_delim}start=" . (($on_page - 2) * $per_page);
   $next = ($on_page == $total_pages) ? '' : $base_url . "{$url_delim}start=" . ($on_page * $per_page);
   if (is_object($phpbb_seo)) {
      static $pagin_find = array();
      static $pagin_replace = array();
      static $prev_find = array();
      if (empty($pagin_replace)) {
         $pagin_find = array('`(\.(?!' . $phpEx . ')[a-z0-9]+)([\w\#$%&~\-;:=,?@+]*)(&|\?)start=([0-9]+)`i', '`/([\w\#$%&~\-;:=,?@+]*)(&|\?)start=([0-9]+)`i' );
         $pagin_replace = array( $phpbb_seo->seo_delim['start'] . '\\4\\1\\2', '/' . $phpbb_seo->seo_static['pagination'] . '\\3' . $phpbb_seo->seo_ext['pagination'] . '\\1' );
         $prev_find = array($phpbb_seo->seo_delim['start'] . '0', $phpbb_seo->seo_static['pagination'] . '0' . $phpbb_seo->seo_ext['pagination']);
      }
      $page_string = str_replace($url_delim . 'start=0', '', $page_string);
      $page_string = preg_replace($pagin_find, $pagin_replace, $page_string);
      $prev = preg_replace($pagin_find, $pagin_replace, $prev);
      $prev = str_replace($prev_find, '', $prev);
      $next = preg_replace( $pagin_find, $pagin_replace, $next);
   }
   $template->assign_vars(array(
      $tpl_prefix . 'BASE_URL'   => $base_url,
      'A_' . $tpl_prefix . 'BASE_URL'   => addslashes($base_url),
      $tpl_prefix . 'PER_PAGE'   => $per_page,
      $tpl_prefix . 'PREVIOUS_PAGE'   => $prev,
      $tpl_prefix . 'NEXT_PAGE'   => $next,
      $tpl_prefix . 'TOTAL_PAGES'   => $total_pages)
   );
   // www.phpBB-SEO.com SEO TOOLKIT END

#
#-----[ OPEN ]------------------------------------------
#

includes/functions_display.php

#
#-----[ FIND ]------------------------------------------
#

      // www.phpBB-SEO.com SEO TOOLKIT BEGIN
      if (is_object($phpbb_seo) && strpos($pagination, '.' . $phpEx) === FALSE) {
         static $pagin_find = array( '`(\.[a-z0-9]+)([\w\#$%&~.\-;:=,?@+]*)&start=([0-9]+)`i', '`/([\w\#$%&~.\-;:=,?@+]*)&start=([0-9]+)`i' );
         static $pagin_replace = array();
         if (empty($pagin_replace)) {
            $pagin_replace = array( $phpbb_seo->seo_delim['start'] . '\\3\\1\\2', '/' . $phpbb_seo->seo_static['pagination'] . '\\2' . $phpbb_seo->seo_ext['pagination'] .'\\1' );
         }
         $pagination = str_replace( '&start=0', '', $pagination );
         $pagination = preg_replace( $pagin_find, $pagin_replace, $pagination );
      }
      // www.phpBB-SEO.com SEO TOOLKIT END

#
#-----[ REPLACE WITH ]------------------------------------------
#

      // www.phpBB-SEO.com SEO TOOLKIT BEGIN
      if (is_object($phpbb_seo) ) {
         static $pagin_find = array();
         static $pagin_replace = array();
         if (empty($pagin_find)) {
            $pagin_find = array( '`(\.(?!' . $phpEx . ')[a-z0-9]+)([\w\#$%&~\-;:=,?@+]*)&start=([0-9]+)`i', '`/([\w\#$%&~\-;:=,?@+]*)&start=([0-9]+)`i' );
            $pagin_replace = array( $phpbb_seo->seo_delim['start'] . '\\3\\1\\2', '/' . $phpbb_seo->seo_static['pagination'] . '\\2' . $phpbb_seo->seo_ext['pagination'] .'\\1' );
         }
         $pagination = str_replace( '&start=0', '', $pagination );
         $pagination = preg_replace( $pagin_find, $pagin_replace, $pagination );
      }
      // www.phpBB-SEO.com SEO TOOLKIT END

Sorry for that.

++

first:thx for fix that dcz now it is working great it is a such fantastic mod
second:it you have not to excuse to me i found only little bugsik in you great mod and one member show that wasnt work.But it was only little mistake and everythink now look fine

I'm sorry for me too

Many releases to do again

The good thing is, very few domains are concerned (including ".php"), the funny thing is this version could not be used on phpbb.com

++

dcz wrote:
Many releases to do again

sorry for that
and why it wount be use in phpbb.com?why they dont use seo mod?

Was just mentioning they would be among the few to be bugged, since their domain name www.phpbb.com includes ".php".

I kind of understand why they do not do much SEO, because they need to use their script and they want it universal (url rewriting isn't since you need extra server modules).

++