That's the code I've been trying to use. It generates the Undefined index: no_dupe errors.

Oh, just replace :

Code: Select all

'U_LAST_POST'         => $view_topic_url . '&p=' . $row['topic_last_post_id'] . '#p' . $row['topic_last_post_id'],

with :

Code: Select all

'U_LAST_POST'         => append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $forum_id . '&p=' . $row['topic_last_post_id']) . '#p' . $row['topic_last_post_id'],

and keep the code posted above for :

Code: Select all

U_NEWEST_POST

++

hello, you have the changes for the new version 1.0.4, because when I make these changes do I get an error message

IPB_Refugee wrote:Here is my solution that seems to work correctly (I have Advanced Kexword URLs, No Dupe, Zero Dupe,...):

Take a vanilla functions_recenttopics.php.

FIND

Code: Select all

   $topic_id = $row['topic_id'];
   $forum_id = $row['forum_id'];

AFTER, ADD:

Code: Select all

   // www.phpBB-SEO.com SEO TOOLKIT BEGIN
   if ( empty($phpbb_seo->seo_url['topic'][$topic_id]) ) {
      if ($row['topic_type'] == POST_GLOBAL) {
         $phpbb_seo->seo_opt['topic_type'][$topic_id] = POST_GLOBAL;
      }
      $phpbb_seo->seo_url['topic'][$topic_id] = $phpbb_seo->format_url(censor_text($row['topic_title']));
   }
   if ( empty($phpbb_seo->seo_url['forum'][$forum_id]) ) {
      $phpbb_seo->seo_url['forum'][$forum_id] = $phpbb_seo->set_url($row['forum_name'], $forum_id, $phpbb_seo->seo_static['forum']);
   }
   // www.phpBB-SEO.com SEO TOOLKIT END

with this change I get no error message

IPB_Refugee wrote:

Code: Select all

      'U_NEWEST_POST'         => $view_topic_url . '&view=unread#unread',
      'U_LAST_POST'         => $view_topic_url . '&p=' . $row['topic_last_post_id'] . '#p' . $row['topic_last_post_id'],

REPLACE WITH:

Code: Select all

/*      'U_NEWEST_POST'         => $view_topic_url . '&view=unread#unread',
      'U_LAST_POST'         => $view_topic_url . '&p=' . $row['topic_last_post_id'] . '#p' . $row['topic_last_post_id'],
*/
      // www.phpBB-SEO.com SEO TOOLKIT BEGIN
      'U_NEWEST_POST'         => append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $forum_id . '&t=' . $topic_id . '&view=unread') . '#unread',
      // www.phpBB-SEO.com SEO TOOLKIT BEGIN -> no dupe
      'U_LAST_POST'         => $phpbb_seo->seo_opt['no_dupe']['on'] ? append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $forum_id . '&t=' . $topic_id . '&start=' . @intval($phpbb_seo->seo_opt['topic_last_page'][$topic_id])) . '#p' . $row['topic_last_post_id'] : append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $forum_id . '&t=' . $topic_id . '&p=' . $row['topic_last_post_id']) . '#p' . $row['topic_last_post_id'],
      // www.phpBB-SEO.com SEO TOOLKIT BEGIN -> no dupe
      // www.phpBB-SEO.com SEO TOOLKIT END

Second part is phpBB-seo.com's original code taken from viewforum.php.

Regards
Wolfgang

that is my recenttopic.php

Code: Select all

<?php

/**
*
* @package - NV recent topics
* @version $Id: functions_recenttopics.php 187 2008-12-27 02:05:24Z nickvergessen $
* @copyright (c) nickvergessen ( http://www.flying-bits.org/ )
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*
*/

/**
* @ignore
*/
if (!defined('IN_PHPBB'))
{
   exit;
}

if (!function_exists('display_forums'))
{
   include($phpbb_root_path . 'includes/functions_display.' . $phpEx);
}

$user->add_lang('mods/info_acp_recenttopics');

function display_recent_topics($topics_per_page, $num_pages, $excluded_topics)
{
   global $auth, $cache, $config, $db, $template, $user;
   global $phpbb_root_path, $phpEx;


   $spec_forum_id   = request_var('f', 0);
   $start         = request_var('start', 0);
   $excluded_topic_ids = explode(', ', $excluded_topics);
   $total_limit   = $topics_per_page * $num_pages;
   $ga_forum_id   = 0; // Forum id we use for global announcements

   // Get the allowed forums
   $forum_ary = array();
   $forum_read_ary = $auth->acl_getf('f_read');
   foreach ($forum_read_ary as $forum_id => $allowed)
   {
      if ($allowed['f_read'])
      {
         $forum_ary[] = (int) $forum_id;
      }
   }
   $forum_ary = array_unique($forum_ary);
   if (!sizeof($forum_ary))
   {
      return;
   }

   // Only call the query, if we need to
   $spec_forum_ary = array();
   if ($spec_forum_id)
   {
      $spec_forum_ary = array($spec_forum_id);
      $sql = 'SELECT parent_id, forum_id
         FROM ' . FORUMS_TABLE . '
         WHERE ' . $db->sql_in_set('forum_id', $forum_ary) . '
         ORDER BY left_id';
      $result = $db->sql_query($sql);
      while ($row = $db->sql_fetchrow($result))
      {
         if (in_array($row['parent_id'], $spec_forum_ary))
         {
            $spec_forum_ary[] = $row['forum_id'];
         }
      }
      $db->sql_freeresult($result);
   }

   $sql = 'SELECT forum_id
      FROM ' . FORUMS_TABLE . '
      WHERE ' . $db->sql_in_set('forum_id', $forum_ary) . '
         ' . ((sizeof($spec_forum_ary)) ? ' AND ' . $db->sql_in_set('forum_id', $spec_forum_ary) : '') . '
         AND forum_recent_topics = 1';
   $result = $db->sql_query($sql);

   $forum_ids = array();
   while ($row = $db->sql_fetchrow($result))
   {
      $forum_ids[] = $row['forum_id'];
   }
   $db->sql_freeresult($result);

   // No forums with f_view
   if (!sizeof($forum_ids))
   {
      return;
   }

   // Moderator forums
   $m_approve_ids = array();
   $m_approve_ary = $auth->acl_getf('m_approve');
   foreach ($m_approve_ary as $forum_id => $allowed)
   {
      if ($allowed['m_approve'] && in_array($forum_id, $forum_ids))
      {
         $m_approve_ids[] = (int) $forum_id;
      }
   }

   // Get the allowed topics
   $sql = 'SELECT forum_id, topic_id, topic_type
      FROM ' . TOPICS_TABLE . '
      WHERE ((' . $db->sql_in_set('topic_id', $excluded_topic_ids, true) . '
            AND ' . $db->sql_in_set('forum_id', $forum_ids) . ')
         OR topic_type = ' . POST_GLOBAL . ')
         AND topic_status <> ' . ITEM_MOVED . '
         AND (' . $db->sql_in_set('forum_id', $m_approve_ids, false, true) . '
            OR topic_approved = 1)
      ORDER BY topic_last_post_time DESC';
   $result = $db->sql_query_limit($sql, $total_limit);

   $forums = $ga_topic_ids = $topic_ids = array();
   $num_topics = 0;
   while ($row = $db->sql_fetchrow($result))
   {
      $num_topics++;
      if (($num_topics > $start) && ($num_topics <= ($start + $topics_per_page)))
      {
         $topic_ids[] = $row['topic_id'];
         if ($row['topic_type'] == POST_GLOBAL)
         {
            $ga_topic_ids[] = $row['topic_id'];
         }
         else
         {
            $forums[$row['forum_id']][] = $row['topic_id'];
         }
      }
   }
   $db->sql_freeresult($result);

   // No topics to display
   if (!sizeof($topic_ids))
   {
      return;
   }

   // Grab icons
   $icons = $cache->obtain_icons();

   // Now only pull the data of the requested topics
   $sql = 'SELECT t.*, i.icons_url, i.icons_width, i.icons_height, tp.topic_posted, f.forum_name
      FROM ' . TOPICS_TABLE . ' t
      LEFT JOIN ' . TOPICS_POSTED_TABLE . ' tp
         ON (t.topic_id = tp.topic_id
            AND tp.user_id = ' . $user->data['user_id'] . ')
      LEFT JOIN ' . FORUMS_TABLE . ' f
         ON f.forum_id = t.forum_id
      LEFT JOIN ' . ICONS_TABLE . ' i
         ON t.icon_id = i.icons_id
      WHERE ' . $db->sql_in_set('t.topic_id', $topic_ids) . '
      ORDER BY t.topic_last_post_time DESC';
   $result = $db->sql_query_limit($sql, $topics_per_page);

   foreach ($forums as $forum_id => $topic_ids)
   {
      $topic_tracking_info[$forum_id] = get_complete_topic_tracking($forum_id, $topic_ids, $ga_topic_ids);
   }

   $topic_icons = array();
   while ($row = $db->sql_fetchrow($result))
   {
      $topic_id = $row['topic_id'];
      $forum_id = $row['forum_id'];
      
   

      // Cheat for Global Announcements on the unread-link: copied from search.php
      if (!$forum_id && !$ga_forum_id)
      {
         $sql2 = 'SELECT forum_id
            FROM ' . FORUMS_TABLE . '
            WHERE forum_type = ' . FORUM_POST . '
               AND ' . $db->sql_in_set('forum_id', $forum_ary, false, true);
         $result2 = $db->sql_query_limit($sql2, 1);
         $ga_forum_id = (int) $db->sql_fetchfield('forum_id');
         $db->sql_freeresult($result2);
         $forum_id = $ga_forum_id;
      }
      else if (!$forum_id && $ga_forum_id)
      {
         $forum_id = $ga_forum_id;
      }

      $s_type_switch_test = ($row['topic_type'] == POST_ANNOUNCE || $row['topic_type'] == POST_GLOBAL) ? 1 : 0;
      $replies = ($auth->acl_get('m_approve', $forum_id)) ? $row['topic_replies_real'] : $row['topic_replies'];
      $unread_topic = (isset($topic_tracking_info[$forum_id][$topic_id]) && $row['topic_last_post_time'] > $topic_tracking_info[$forum_id][$topic_id]) ? true : false;

      $folder_img = $folder_alt = $topic_type = '';
      switch ($row['topic_type'])
      {
         case POST_GLOBAL:
            $topic_type = $user->lang['VIEW_TOPIC_GLOBAL'];
            $folder_img = (!$unread_topic) ? 'global_read' : 'global_unread';
         break;
         case POST_ANNOUNCE:
            $topic_type = $user->lang['VIEW_TOPIC_ANNOUNCEMENT'];
            $folder_img = (!$unread_topic) ? 'announce_read' : 'announce_unread';
         break;
         case POST_STICKY:
            $topic_type = $user->lang['VIEW_TOPIC_STICKY'];
            $folder_img = (!$unread_topic) ? 'sticky_read' : 'sticky_unread';
         break;
         default:
            $topic_type = '';
            $folder_img = (!$unread_topic) ? 'topic_read' : 'topic_unread';
            if ($config['hot_threshold'] && $replies >= $config['hot_threshold'] && $row['topic_status'] != ITEM_LOCKED)
            {
               $folder_img .= '_hot';
            }
         break;
      }
      if ($row['topic_status'] == ITEM_LOCKED)
      {
         $topic_type = $user->lang['VIEW_TOPIC_LOCKED'];
         $folder_img .= '_locked';
      }
      if ($row['topic_posted'])
      {
         $folder_img .= '_mine';
      }
      if ($row['topic_type'] == POST_GLOBAL)
      {
         $global_announce_list[$row['topic_id']] = true;
      }
      $folder_alt = ($unread_topic) ? 'NEW_POSTS' : (($row['topic_status'] == ITEM_LOCKED) ? 'TOPIC_LOCKED' : 'NO_NEW_POSTS');
      if ($row['poll_start'] && $row['topic_status'] != ITEM_MOVED)
      {
         $topic_type = $user->lang['VIEW_TOPIC_POLL'];
      }

      $view_topic_url = append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $forum_id . '&amp;t=' . $topic_id);
      $view_forum_url = append_sid("{$phpbb_root_path}viewforum.$phpEx", 'f=' . $forum_id);
      $topic_unapproved = (!$row['topic_approved'] && $auth->acl_get('m_approve', $forum_id)) ? true : false;
      $posts_unapproved = ($row['topic_approved'] && $row['topic_replies'] < $row['topic_replies_real'] && $auth->acl_get('m_approve', $forum_id)) ? true : false;
      $u_mcp_queue = ($topic_unapproved || $posts_unapproved) ? append_sid("{$phpbb_root_path}mcp.$phpEx", 'i=queue&amp;mode=' . (($topic_unapproved) ? 'approve_details' : 'unapproved_posts') . "&amp;t=$topic_id", true, $user->session_id) : '';
      $s_type_switch = ($row['topic_type'] == POST_ANNOUNCE || $row['topic_type'] == POST_GLOBAL) ? 1 : 0;
      if (!empty($icons[$row['icon_id']]))
      {
         $topic_icons[] = $topic_id;
      }

      $template->assign_block_vars('recenttopicrow', array(
         'FORUM_ID'               => $forum_id,
         'TOPIC_ID'               => $topic_id,
         'TOPIC_AUTHOR_FULL'         => get_username_string('full', $row['topic_poster'], $row['topic_first_poster_name'], $row['topic_first_poster_colour']),
         'FIRST_POST_TIME'         => $user->format_date($row['topic_time']),

         'LAST_POST_SUBJECT'         => censor_text($row['topic_last_post_subject']),
         'LAST_POST_TIME'         => $user->format_date($row['topic_last_post_time']),
         'LAST_VIEW_TIME'         => $user->format_date($row['topic_last_view_time']),
         'LAST_POST_AUTHOR'         => get_username_string('username', $row['topic_last_poster_id'], $row['topic_last_poster_name'], $row['topic_last_poster_colour']),
         'LAST_POST_AUTHOR_COLOUR'   => get_username_string('colour', $row['topic_last_poster_id'], $row['topic_last_poster_name'], $row['topic_last_poster_colour']),
         'LAST_POST_AUTHOR_FULL'      => get_username_string('full', $row['topic_last_poster_id'], $row['topic_last_poster_name'], $row['topic_last_poster_colour']),

         'PAGINATION'            => topic_generate_pagination($replies, $view_topic_url),
         'REPLIES'               => $replies,
         'VIEWS'                  => $row['topic_views'],
         'TOPIC_TITLE'            => censor_text($row['topic_title']),
         'FORUM_NAME'            => $row['forum_name'],

         'TOPIC_TYPE'         => $topic_type,
         'TOPIC_FOLDER_IMG'      => $user->img($folder_img, $folder_alt),
         'TOPIC_FOLDER_IMG_SRC'   => $user->img($folder_img, $folder_alt, false, '', 'src'),
         'TOPIC_FOLDER_IMG_ALT'   => $user->lang[$folder_alt],
         'NEWEST_POST_IMG'      => $user->img('icon_topic_newest', 'VIEW_NEWEST_POST'),
         'TOPIC_ICON_IMG'      => (!empty($icons[$row['icon_id']])) ? $icons[$row['icon_id']]['img'] : '',
         'TOPIC_ICON_IMG_WIDTH'   => (!empty($icons[$row['icon_id']])) ? $icons[$row['icon_id']]['width'] : '',
         'TOPIC_ICON_IMG_HEIGHT'   => (!empty($icons[$row['icon_id']])) ? $icons[$row['icon_id']]['height'] : '',
         'ATTACH_ICON_IMG'      => ($auth->acl_get('u_download') && $auth->acl_get('f_download', $forum_id) && $row['topic_attachment']) ? $user->img('icon_topic_attach', $user->lang['TOTAL_ATTACHMENTS']) : '',
         'UNAPPROVED_IMG'      => ($topic_unapproved || $posts_unapproved) ? $user->img('icon_topic_unapproved', ($topic_unapproved) ? 'TOPIC_UNAPPROVED' : 'POSTS_UNAPPROVED') : '',
         'REPORTED_IMG'         => ($row['topic_reported'] && $auth->acl_get('m_report', $forum_id)) ? $user->img('icon_topic_reported', 'TOPIC_REPORTED') : '',

         'S_TOPIC_TYPE'         => $row['topic_type'],
         'S_USER_POSTED'         => (isset($row['topic_posted']) && $row['topic_posted']) ? true : false,
         'S_UNREAD_TOPIC'      => $unread_topic,
         'S_TOPIC_REPORTED'      => ($row['topic_reported'] && $auth->acl_get('m_report', $forum_id)) ? true : false,
         'S_TOPIC_UNAPPROVED'   => $topic_unapproved,
         'S_POSTS_UNAPPROVED'   => $posts_unapproved,
         'S_HAS_POLL'         => ($row['poll_start']) ? true : false,
         'S_POST_ANNOUNCE'      => ($row['topic_type'] == POST_ANNOUNCE) ? true : false,
         'S_POST_GLOBAL'         => ($row['topic_type'] == POST_GLOBAL) ? true : false,
         'S_POST_STICKY'         => ($row['topic_type'] == POST_STICKY) ? true : false,
         'S_TOPIC_LOCKED'      => ($row['topic_status'] == ITEM_LOCKED) ? true : false,
         'S_TOPIC_MOVED'         => ($row['topic_status'] == ITEM_MOVED) ? true : false,
         'S_TOPIC_TYPE_SWITCH'   => ($s_type_switch == $s_type_switch_test) ? -1 : $s_type_switch_test,

    /*      'U_NEWEST_POST'         => $view_topic_url . '&amp;view=unread#unread',
          'U_LAST_POST'         => $view_topic_url . '&amp;p=' . $row['topic_last_post_id'] . '#p' . $row['topic_last_post_id'],
    */
          // www.phpBB-SEO.com SEO TOOLKIT BEGIN
          'U_NEWEST_POST'         => append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $forum_id . '&amp;t=' . $topic_id . '&amp;view=unread') . '#unread',
          // www.phpBB-SEO.com SEO TOOLKIT BEGIN -> no dupe
          'U_LAST_POST'         => $phpbb_seo->seo_opt['no_dupe']['on'] ? append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $forum_id . '&amp;t=' . $topic_id . '&amp;start=' . @intval($phpbb_seo->seo_opt['topic_last_page'][$topic_id])) . '#p' . $row['topic_last_post_id'] : append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $forum_id . '&amp;t=' . $topic_id . '&amp;p=' . $row['topic_last_post_id']) . '#p' . $row['topic_last_post_id'],
          // www.phpBB-SEO.com SEO TOOLKIT BEGIN -> no dupe
          // www.phpBB-SEO.com SEO TOOLKIT END
         'U_LAST_POST_AUTHOR'   => get_username_string('profile', $row['topic_last_poster_id'], $row['topic_last_poster_name'], $row['topic_last_poster_colour']),
         'U_TOPIC_AUTHOR'      => get_username_string('profile', $row['topic_poster'], $row['topic_first_poster_name'], $row['topic_first_poster_colour']),
         'U_VIEW_TOPIC'         => $view_topic_url,
         'U_VIEW_FORUM'         => $view_forum_url,
         'U_MCP_REPORT'         => append_sid("{$phpbb_root_path}mcp.$phpEx", 'i=reports&amp;mode=reports&amp;f=' . $forum_id . '&amp;t=' . $topic_id, true, $user->session_id),
         'U_MCP_QUEUE'         => $u_mcp_queue,
      ));
   }
   $db->sql_freeresult($result);

   $template->assign_vars(array(
      'S_TOPIC_ICONS'         => (sizeof($topic_icons)) ? true : false,
      'RT_DISPLAY'         => true,
      'NEWEST_POST_IMG'      => $user->img('icon_topic_newest', 'VIEW_NEWEST_POST'),
      'LAST_POST_IMG'         => $user->img('icon_topic_latest', 'VIEW_LATEST_POST'),
      'RT_PAGE_NUMBER'      => on_page($num_topics, $topics_per_page, $start),
      'RT_PAGINATION'         => generate_pagination(append_sid($phpbb_root_path . $user->page['page_name']), $num_topics, $topics_per_page, $start),
   ));

}


?>

on the picture you can see the (viewtopic.php ..) but I want it to work with seo



Full size: http://www.ressim.net/show.php/82314_cats.jpg.html

sry for my bad english I'm from germany

You may just not use the no duplicate mod, if so, just use the code change above :
Problem with NV Recent Post
For the :

Code: Select all

      'U_LAST_POST'         => $view_topic_url . '&p=' . $row['topic_last_post_id'] . '#p' . $row['topic_last_post_id'],

code change only.

++

With the zero duplicate add-on, this works perfectly. along with this:

FIND:

Code: Select all

    'U_NEWEST_POST'         => $view_topic_url . '&view=unread#unread',
      'U_LAST_POST'         => $view_topic_url . '&p=' . $row['topic_last_post_id'] . '#p' . $row['topic_last_post_id'],

REPLACE WITH

Code: Select all

/*      'U_NEWEST_POST'         => $view_topic_url . '&view=unread#unread',
      'U_LAST_POST'         => $view_topic_url . '&p=' . $row['topic_last_post_id'] . '#p' . $row['topic_last_post_id'],
*/
      // www.phpBB-SEO.com SEO TOOLKIT BEGIN
      'U_NEWEST_POST'         => append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $forum_id . '&t=' . $topic_id . '&view=unread') . '#unread',
      // www.phpBB-SEO.com SEO TOOLKIT BEGIN -> no dupe
      'U_LAST_POST'         => $phpbb_seo->seo_opt['no_dupe']['on'] ? append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $forum_id . '&t=' . $topic_id . '&start=' . @intval($phpbb_seo->seo_opt['topic_last_page'][$topic_id])) . '#p' . $row['topic_last_post_id'] : append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $forum_id . '&t=' . $topic_id . '&p=' . $row['topic_last_post_id']) . '#p' . $row['topic_last_post_id'],
      // www.phpBB-SEO.com SEO TOOLKIT BEGIN -> no dupe
      // www.phpBB-SEO.com SEO TOOLKIT END

Zero dup fixes the problem with a virtual folder missing from the URL on the last post icon URL. i Did not necessarily need to add anything else. with this new version, it seems it was improved a bit and so it cooperates a bit better with dcz's SEO.

I have just installed phpBB SEO premod 3.0.5
Everythink is ok. it's working great. but then i installed NV Recent Post 1.0.4
i choice advanced url rewriting type. Recent topic links are looking simple rewriting.
other forum links are working perfectly.No dub and zero dub are deactive.

For example : Last 2 Recent topic:
Links are like this on my board.
1- phpBB SEO premod 3.0.5 released (Link xxx.com/topic6.html)
2- Manual update ( Link: xxx.com/topic4.html)

but it must be like this
1- phpBB SEO premod 3.0.5 released (Link xxx.com/phpBB-premod-3-0-5-released-t6.html )
2- Manual update ( Link: xxx.com/manual-update-t4.html)

when i activated no dub links are looking same. but it redirect to advanced url.
What is wrong ?
Sorry for english. i hope you understand my problem.

Starting from last update (3.0.5, SEO URL 0.6.0), here are the code change to use :
Find :

Code: Select all

   $topic_id = $row['topic_id'];
   $forum_id = $row['forum_id'];

After add :

Code: Select all

   // www.phpBB-SEO.com SEO TOOLKIT BEGIN
   $phpbb_seo->set_url($row['forum_name'], $forum_id, $phpbb_seo->seo_static['forum']);
   $phpbb_seo->prepare_iurl($row, 'topic', $row['topic_type'] == POST_GLOBAL ? $phpbb_seo->seo_static['global_announce'] : $phpbb_seo->seo_url['forum'][$forum_id]);
   // www.phpBB-SEO.com SEO TOOLKIT END

Other changes remains the same

++

dcz i did it before. i try everything before sending to post here.
when i add this code it gives error
Call to a member function format_url()
i think last nv recent mods create issue. i will try old nv version.
Thank you for help.

--30 min later--

i removed nv recent 1.0.4 then i installed nv recent 1.0.3 (old ver.)
This is my solution.Solved
zero duplicate on, no dub on. it is working.

-- Open -- includes/functions_recenttopics.php

Find :

Code: Select all

$topic_id = $row['topic_id'];
$forum_id = $row['forum_id'];

After ADD (dcz' s code)

Code: Select all

// www.phpBB-SEO.com SEO TOOLKIT BEGIN
       $phpbb_seo->set_url($row['forum_name'], $forum_id, $phpbb_seo->seo_static['forum']);
       $phpbb_seo->prepare_iurl($row, 'topic', $row['topic_type'] == POST_GLOBAL ? $phpbb_seo->seo_static['global_announce'] : $phpbb_seo->seo_url['forum'][$forum_id]);
// www.phpBB-SEO.com SEO TOOLKIT END

Find :

Code: Select all

'U_NEWEST_POST'         => $view_topic_url . '&view=unread#unread',
'U_LAST_POST'         => $view_topic_url . '&p=' . $row['topic_last_post_id'] . '#p' . $row['topic_last_post_id'],

REPLACE it (from viewforum.php)

Code: Select all

'U_NEWEST_POST'         => append_sid("{$phpbb_root_path}viewtopic.$phpEx", $view_topic_url_params . '&view=unread') . '#unread',
// www.phpBB-SEO.com SEO TOOLKIT BEGIN -> no dupe
'U_LAST_POST' => @$phpbb_seo->seo_opt['no_dupe']['on'] ? append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . (($row['forum_id']) ? $row['forum_id'] : $forum_id) . '&t=' . $topic_id . '&start=' . @intval($phpbb_seo->seo_opt['topic_last_page'][$topic_id])) . '#p' . $row['topic_last_post_id'] : append_sid("{$phpbb_root_path}viewtopic.$phpEx", $view_topic_url_params . '&p=' . $row['topic_last_post_id']) . '#p' . $row['topic_last_post_id'],
// www.phpBB-SEO.com SEO TOOLKIT END -> no dupe

I tried to install your modifications, but none of them works correctly, the links are displayed correctly but not the bear to unread post only topic.


my files

Code: Select all

<?php

/**
*
* @package - NV recent topics
* @version $Id: functions_recenttopics.php 201 2009-08-03 08:37:12Z nickvergessen $
* @copyright (c) nickvergessen ( http://www.flying-bits.org/ )
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*
*/

/**
* @ignore
*/
if (!defined('IN_PHPBB'))
{
   exit;
}

if (!function_exists('display_forums'))
{
   include($phpbb_root_path . 'includes/functions_display.' . $phpEx);
}

$user->add_lang('mods/info_acp_recenttopics');

/**
* Since #48835 is a will not fix, we copy the function and make it work, else it is just a simple cut'n'paste
*/
function recent_topics_generate_pagination($base_url, $num_items, $per_page, $start_item, $add_prevnext_text = false, $tpl_prefix = '', $start_item_name = '')
{
   global $template, $user;
   // www.phpBB-SEO.com SEO TOOLKIT BEGIN
   global $phpbb_seo;
   // www.phpBB-SEO.com SEO TOOLKIT END

   // Make sure $per_page is a valid value
   $per_page = ($per_page <= 0) ? 1 : $per_page;

   $seperator = '<span class="page-sep">' . $user->lang['COMMA_SEPARATOR'] . '</span>';
   $total_pages = ceil($num_items / $per_page);

   if ($total_pages == 1 || !$num_items)
   {
      return false;
   }

   $on_page = floor($start_item / $per_page) + 1;
   $url_delim = (strpos($base_url, '?') === false) ? '?' : '&amp;';

   $page_string = ($on_page == 1) ? '<strong>1</strong>' : '<a href="' . $base_url . '">1</a>';

   if ($total_pages > 5)
   {
      $start_cnt = min(max(1, $on_page - 4), $total_pages - 5);
      $end_cnt = max(min($total_pages, $on_page + 4), 6);

      $page_string .= ($start_cnt > 1) ? ' ... ' : $seperator;

      for ($i = $start_cnt + 1; $i < $end_cnt; $i++)
      {
         $page_string .= ($i == $on_page) ? '<strong>' . $i . '</strong>' : '<a href="' . $base_url . "{$url_delim}{$start_item_name}=" . (($i - 1) * $per_page) . '">' . $i . '</a>';
         if ($i < $end_cnt - 1)
         {
            $page_string .= $seperator;
         }
      }

      $page_string .= ($end_cnt < $total_pages) ? ' ... ' : $seperator;
   }
   else
   {
      $page_string .= $seperator;

      for ($i = 2; $i < $total_pages; $i++)
      {
         $page_string .= ($i == $on_page) ? '<strong>' . $i . '</strong>' : '<a href="' . $base_url . "{$url_delim}{$start_item_name}=" . (($i - 1) * $per_page) . '">' . $i . '</a>';
         if ($i < $total_pages)
         {
            $page_string .= $seperator;
         }
      }
   }

   $page_string .= ($on_page == $total_pages) ? '<strong>' . $total_pages . '</strong>' : '<a href="' . $base_url . "{$url_delim}{$start_item_name}=" . (($total_pages - 1) * $per_page) . '">' . $total_pages . '</a>';

   if ($add_prevnext_text)
   {
      if ($on_page != 1)
      {
         $page_string = '<a href="' . $base_url . "{$url_delim}{$start_item_name}=" . (($on_page - 2) * $per_page) . '">' . $user->lang['PREVIOUS'] . '</a>&nbsp;&nbsp;' . $page_string;
      }

      if ($on_page != $total_pages)
      {
         $page_string .= '&nbsp;&nbsp;<a href="' . $base_url . "{$url_delim}{$start_item_name}=" . ($on_page * $per_page) . '">' . $user->lang['NEXT'] . '</a>';
      }
   }

   $template->assign_vars(array(
      $tpl_prefix . 'BASE_URL'      => $base_url,
      'A_' . $tpl_prefix . 'BASE_URL'   => addslashes($base_url),
      $tpl_prefix . 'PER_PAGE'      => $per_page,

      $tpl_prefix . 'PREVIOUS_PAGE'   => ($on_page == 1) ? '' : $base_url . "{$url_delim}{$start_item_name}=" . (($on_page - 2) * $per_page),
      $tpl_prefix . 'NEXT_PAGE'      => ($on_page == $total_pages) ? '' : $base_url . "{$url_delim}{$start_item_name}=" . ($on_page * $per_page),
      $tpl_prefix . 'TOTAL_PAGES'      => $total_pages,
   ));

   return $page_string;
}

function display_recent_topics($topics_per_page, $num_pages, $excluded_topics, $tpl_loopname = 'recenttopicrow', $spec_forum_id = 0, $include_subforums = true)
{
   global $auth, $cache, $config, $db, $template, $user;
   global $phpbb_root_path, $phpEx;
   // www.phpBB-SEO.com SEO TOOLKIT BEGIN
   global $phpbb_seo;
   // www.phpBB-SEO.com SEO TOOLKIT END

   /**
   * Set some internal needed variables
   */
   $start = request_var($tpl_loopname . '_start', 0);
   $excluded_topic_ids = explode(', ', $excluded_topics);
   $total_limit   = $topics_per_page * $num_pages;
   $ga_forum_id   = 0; // Forum id we use for global announcements

   /**
   * Get the forums we take our topics from
   */
   // Get the allowed forums
   $forum_ary = array();
   $forum_read_ary = $auth->acl_getf('f_read');
   foreach ($forum_read_ary as $forum_id => $allowed)
   {
      if ($allowed['f_read'])
      {
         $forum_ary[] = (int) $forum_id;
      }
   }
   $forum_ids = array_unique($forum_ary);

   if (!sizeof($forum_ids))
   {
      // No forums with f_read
      return;
   }

   $spec_forum_ary = array();
   if ($spec_forum_id)
   {
      // Only take a special-forum
      if (!$include_subforums)
      {
         if (!in_array($spec_forum_id, $forum_ids))
         {
            return;
         }
         $forum_ids = array();
         $sql = 'SELECT 1 as display_forum
            FROM ' . FORUMS_TABLE . '
            WHERE forum_id = ' . $spec_forum_id . '
               AND forum_recent_topics = 1';
         $result = $db->sql_query_limit($sql, 1);
         $display_forum = (bool) $db->sql_fetchfield('display_forum');
         $db->sql_freeresult($result);

         if ($display_forum)
         {
            $forum_ids = array($spec_forum_id);
         }
      }
      else
      {
         // ... and it's subforums
         $sql = 'SELECT f2.forum_id
            FROM ' . FORUMS_TABLE . ' f1
            LEFT JOIN ' . FORUMS_TABLE . " f2
               ON (f2.left_id BETWEEN f1.left_id AND f1.right_id
                  AND f2.forum_recent_topics = 1)
            WHERE f1.forum_id = $spec_forum_id
               AND f1.forum_recent_topics = 1
            ORDER BY f2.left_id DESC";
         $result = $db->sql_query($sql);

         while ($row = $db->sql_fetchrow($result))
         {
            $spec_forum_ary[] = $row['forum_id'];
         }
         $db->sql_freeresult($result);

         $forum_ids = array_intersect($forum_ids, $spec_forum_ary);

         if (!sizeof($forum_ids))
         {
            return;
         }
      }
   }
   else
   {
      $sql = 'SELECT forum_id
         FROM ' . FORUMS_TABLE . '
         WHERE ' . $db->sql_in_set('forum_id', $forum_ids) . '
            AND forum_recent_topics = 1';
      $result = $db->sql_query($sql);

      $forum_ids = array();
      while ($row = $db->sql_fetchrow($result))
      {
         $forum_ids[] = $row['forum_id'];
      }
      $db->sql_freeresult($result);
   }

   // No forums with f_read
   if (!sizeof($forum_ids))
   {
      return;
   }

   // Moderator forums
   $m_approve_ids = array();
   $m_approve_ary = $auth->acl_getf('m_approve');
   foreach ($m_approve_ary as $forum_id => $allowed)
   {
      if ($allowed['m_approve'] && in_array($forum_id, $forum_ids))
      {
         $m_approve_ids[] = (int) $forum_id;
      }
   }

   // Get the allowed topics
   $sql = 'SELECT forum_id, topic_id, topic_type
      FROM ' . TOPICS_TABLE . '
      WHERE ((' . $db->sql_in_set('topic_id', $excluded_topic_ids, true) . '
            AND ' . $db->sql_in_set('forum_id', $forum_ids) . ')
         OR topic_type = ' . POST_GLOBAL . ')
         AND topic_status <> ' . ITEM_MOVED . '
         AND (' . $db->sql_in_set('forum_id', $m_approve_ids, false, true) . '
            OR topic_approved = 1)
      ORDER BY topic_last_post_time DESC';
   $result = $db->sql_query_limit($sql, $total_limit);

   $forums = $ga_topic_ids = $topic_ids = array();
   $num_topics = 0;
   while ($row = $db->sql_fetchrow($result))
   {
      $num_topics++;
      if (($num_topics > $start) && ($num_topics <= ($start + $topics_per_page)))
      {
         $topic_ids[] = $row['topic_id'];
         if ($row['topic_type'] == POST_GLOBAL)
         {
            $ga_topic_ids[] = $row['topic_id'];
         }
         else
         {
            $forums[$row['forum_id']][] = $row['topic_id'];
         }
      }
   }
   $db->sql_freeresult($result);

   // No topics to display
   if (!sizeof($topic_ids))
   {
      return;
   }

   // Grab icons
   $icons = $cache->obtain_icons();

   // Now only pull the data of the requested topics
   $sql = 'SELECT t.*, i.icons_url, i.icons_width, i.icons_height, tp.topic_posted, f.forum_name
      FROM ' . TOPICS_TABLE . ' t
      LEFT JOIN ' . TOPICS_POSTED_TABLE . ' tp
         ON (t.topic_id = tp.topic_id
            AND tp.user_id = ' . $user->data['user_id'] . ')
      LEFT JOIN ' . FORUMS_TABLE . ' f
         ON f.forum_id = t.forum_id
      LEFT JOIN ' . ICONS_TABLE . ' i
         ON t.icon_id = i.icons_id
      WHERE ' . $db->sql_in_set('t.topic_id', $topic_ids) . '
      ORDER BY t.topic_last_post_time DESC';
   $result = $db->sql_query_limit($sql, $topics_per_page);

   foreach ($forums as $forum_id => $topic_ids)
   {
      $topic_tracking_info[$forum_id] = get_complete_topic_tracking($forum_id, $topic_ids, $ga_topic_ids);
   }

   $topic_icons = array();
   while ($row = $db->sql_fetchrow($result))
   {
      $topic_id = $row['topic_id'];
      $forum_id = $row['forum_id'];

      // Cheat for Global Announcements on the unread-link: copied from search.php
      if (!$forum_id && !$ga_forum_id)
      {
         $sql2 = 'SELECT forum_id
            FROM ' . FORUMS_TABLE . '
            WHERE forum_type = ' . FORUM_POST . '
               AND ' . $db->sql_in_set('forum_id', $forum_ary, false, true);
         $result2 = $db->sql_query_limit($sql2, 1);
         $ga_forum_id = (int) $db->sql_fetchfield('forum_id');
         $db->sql_freeresult($result2);
         $forum_id = $ga_forum_id;
      }
      else if (!$forum_id && $ga_forum_id)
      {
         $forum_id = $ga_forum_id;
      }

      $s_type_switch_test = ($row['topic_type'] == POST_ANNOUNCE || $row['topic_type'] == POST_GLOBAL) ? 1 : 0;
      $replies = ($auth->acl_get('m_approve', $forum_id)) ? $row['topic_replies_real'] : $row['topic_replies'];
      $unread_topic = (isset($topic_tracking_info[$forum_id][$topic_id]) && $row['topic_last_post_time'] > $topic_tracking_info[$forum_id][$topic_id]) ? true : false;

      $folder_img = $folder_alt = $topic_type = '';
      switch ($row['topic_type'])
      {
         case POST_GLOBAL:
            $topic_type = $user->lang['VIEW_TOPIC_GLOBAL'];
            $folder_img = (!$unread_topic) ? 'global_read' : 'global_unread';
         break;
         case POST_ANNOUNCE:
            $topic_type = $user->lang['VIEW_TOPIC_ANNOUNCEMENT'];
            $folder_img = (!$unread_topic) ? 'announce_read' : 'announce_unread';
         break;
         case POST_STICKY:
            $topic_type = $user->lang['VIEW_TOPIC_STICKY'];
            $folder_img = (!$unread_topic) ? 'sticky_read' : 'sticky_unread';
         break;
         default:
            $topic_type = '';
            $folder_img = (!$unread_topic) ? 'topic_read' : 'topic_unread';
            if ($config['hot_threshold'] && $replies >= $config['hot_threshold'] && $row['topic_status'] != ITEM_LOCKED)
            {
               $folder_img .= '_hot';
            }
         break;
      }
      if ($row['topic_status'] == ITEM_LOCKED)
      {
         $topic_type = $user->lang['VIEW_TOPIC_LOCKED'];
         $folder_img .= '_locked';
      }
      if ($row['topic_posted'])
      {
         $folder_img .= '_mine';
      }
      if ($row['topic_type'] == POST_GLOBAL)
      {
         $global_announce_list[$row['topic_id']] = true;
      }
      $folder_alt = ($unread_topic) ? 'NEW_POSTS' : (($row['topic_status'] == ITEM_LOCKED) ? 'TOPIC_LOCKED' : 'NO_NEW_POSTS');
      if ($row['poll_start'] && $row['topic_status'] != ITEM_MOVED)
      {
         $topic_type = $user->lang['VIEW_TOPIC_POLL'];
      }

      $view_topic_url = append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $forum_id . '&amp;t=' . $topic_id);
      $view_forum_url = append_sid("{$phpbb_root_path}viewforum.$phpEx", 'f=' . $forum_id);
      $topic_unapproved = (!$row['topic_approved'] && $auth->acl_get('m_approve', $forum_id)) ? true : false;
      $posts_unapproved = ($row['topic_approved'] && $row['topic_replies'] < $row['topic_replies_real'] && $auth->acl_get('m_approve', $forum_id)) ? true : false;
      $u_mcp_queue = ($topic_unapproved || $posts_unapproved) ? append_sid("{$phpbb_root_path}mcp.$phpEx", 'i=queue&amp;mode=' . (($topic_unapproved) ? 'approve_details' : 'unapproved_posts') . "&amp;t=$topic_id", true, $user->session_id) : '';
      $s_type_switch = ($row['topic_type'] == POST_ANNOUNCE || $row['topic_type'] == POST_GLOBAL) ? 1 : 0;
      if (!empty($icons[$row['icon_id']]))
      {
         $topic_icons[] = $topic_id;
      }

      $template->assign_block_vars($tpl_loopname, array(
         'FORUM_ID'               => $forum_id,
         'TOPIC_ID'               => $topic_id,
         'TOPIC_AUTHOR_FULL'         => get_username_string('full', $row['topic_poster'], $row['topic_first_poster_name'], $row['topic_first_poster_colour']),
         'FIRST_POST_TIME'         => $user->format_date($row['topic_time']),

         'LAST_POST_SUBJECT'         => censor_text($row['topic_last_post_subject']),
         'LAST_POST_TIME'         => $user->format_date($row['topic_last_post_time']),
         'LAST_VIEW_TIME'         => $user->format_date($row['topic_last_view_time']),
         'LAST_POST_AUTHOR'         => get_username_string('username', $row['topic_last_poster_id'], $row['topic_last_poster_name'], $row['topic_last_poster_colour']),
         'LAST_POST_AUTHOR_COLOUR'   => get_username_string('colour', $row['topic_last_poster_id'], $row['topic_last_poster_name'], $row['topic_last_poster_colour']),
         'LAST_POST_AUTHOR_FULL'      => get_username_string('full', $row['topic_last_poster_id'], $row['topic_last_poster_name'], $row['topic_last_poster_colour']),

         'PAGINATION'            => topic_generate_pagination($replies, $view_topic_url),
         'REPLIES'               => $replies,
         'VIEWS'                  => $row['topic_views'],
         'TOPIC_TITLE'            => censor_text($row['topic_title']),
         'FORUM_NAME'            => $row['forum_name'],

         'TOPIC_TYPE'         => $topic_type,
         'TOPIC_FOLDER_IMG'      => $user->img($folder_img, $folder_alt),
         'TOPIC_FOLDER_IMG_SRC'   => $user->img($folder_img, $folder_alt, false, '', 'src'),
         'TOPIC_FOLDER_IMG_ALT'   => $user->lang[$folder_alt],
         'NEWEST_POST_IMG'      => $user->img('icon_topic_newest', 'VIEW_NEWEST_POST'),
         'TOPIC_ICON_IMG'      => (!empty($icons[$row['icon_id']])) ? $icons[$row['icon_id']]['img'] : '',
         'TOPIC_ICON_IMG_WIDTH'   => (!empty($icons[$row['icon_id']])) ? $icons[$row['icon_id']]['width'] : '',
         'TOPIC_ICON_IMG_HEIGHT'   => (!empty($icons[$row['icon_id']])) ? $icons[$row['icon_id']]['height'] : '',
         'ATTACH_ICON_IMG'      => ($auth->acl_get('u_download') && $auth->acl_get('f_download', $forum_id) && $row['topic_attachment']) ? $user->img('icon_topic_attach', $user->lang['TOTAL_ATTACHMENTS']) : '',
         'UNAPPROVED_IMG'      => ($topic_unapproved || $posts_unapproved) ? $user->img('icon_topic_unapproved', ($topic_unapproved) ? 'TOPIC_UNAPPROVED' : 'POSTS_UNAPPROVED') : '',
         'REPORTED_IMG'         => ($row['topic_reported'] && $auth->acl_get('m_report', $forum_id)) ? $user->img('icon_topic_reported', 'TOPIC_REPORTED') : '',

         'S_TOPIC_TYPE'         => $row['topic_type'],
         'S_USER_POSTED'         => (isset($row['topic_posted']) && $row['topic_posted']) ? true : false,
         'S_UNREAD_TOPIC'      => $unread_topic,
         'S_TOPIC_REPORTED'      => ($row['topic_reported'] && $auth->acl_get('m_report', $forum_id)) ? true : false,
         'S_TOPIC_UNAPPROVED'   => $topic_unapproved,
         'S_POSTS_UNAPPROVED'   => $posts_unapproved,
         'S_HAS_POLL'         => ($row['poll_start']) ? true : false,
         'S_POST_ANNOUNCE'      => ($row['topic_type'] == POST_ANNOUNCE) ? true : false,
         'S_POST_GLOBAL'         => ($row['topic_type'] == POST_GLOBAL) ? true : false,
         'S_POST_STICKY'         => ($row['topic_type'] == POST_STICKY) ? true : false,
         'S_TOPIC_LOCKED'      => ($row['topic_status'] == ITEM_LOCKED) ? true : false,
         'S_TOPIC_MOVED'         => ($row['topic_status'] == ITEM_MOVED) ? true : false,
         'S_TOPIC_TYPE_SWITCH'   => ($s_type_switch == $s_type_switch_test) ? -1 : $s_type_switch_test,

            // www.phpBB-SEO.com SEO TOOLKIT BEGIN
           'U_NEWEST_POST'         => append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $forum_id . '&amp;t=' . $topic_id . '&amp;view=unread') . '#unread',
            // www.phpBB-SEO.com SEO TOOLKIT BEGIN -> no dupe
            'U_LAST_POST'         => !empty($phpbb_seo->seo_opt['no_dupe']['on']) ? append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $forum_id . '&amp;t=' . $topic_id . '&amp;start=' . @intval($phpbb_seo->seo_opt['topic_last_page'][$topic_id])) . '#p' . $row['topic_last_post_id'] : append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $forum_id . '&amp;t=' . $topic_id . '&amp;p=' . $row['topic_last_post_id']) . '#p' . $row['topic_last_post_id'],
            // www.phpBB-SEO.com SEO TOOLKIT BEGIN -> no dupe
            // www.phpBB-SEO.com SEO TOOLKIT END
         'U_LAST_POST_AUTHOR'   => get_username_string('profile', $row['topic_last_poster_id'], $row['topic_last_poster_name'], $row['topic_last_poster_colour']),
         'U_TOPIC_AUTHOR'      => get_username_string('profile', $row['topic_poster'], $row['topic_first_poster_name'], $row['topic_first_poster_colour']),
         'U_VIEW_TOPIC'         => $view_topic_url,
         'U_VIEW_FORUM'         => $view_forum_url,
         'U_MCP_REPORT'         => append_sid("{$phpbb_root_path}mcp.$phpEx", 'i=reports&amp;mode=reports&amp;f=' . $forum_id . '&amp;t=' . $topic_id, true, $user->session_id),
         'U_MCP_QUEUE'         => $u_mcp_queue,
      ));
   }
   $db->sql_freeresult($result);

   // Get URL-parameters for pagination
   $url_params = explode('&', $user->page['query_string']);
   $append_params = false;
   foreach ($url_params as $param)
   {
      if (!$param) continue;
      list($name, $value) = explode('=', $param);
      if ($name != $tpl_loopname . '_start')
      {
         $append_params[$name] = $value;
      }
   }

   $template->assign_vars(array(
      'S_TOPIC_ICONS'         => (sizeof($topic_icons)) ? true : false,
      'NEWEST_POST_IMG'      => $user->img('icon_topic_newest', 'VIEW_NEWEST_POST'),
      'LAST_POST_IMG'         => $user->img('icon_topic_latest', 'VIEW_LATEST_POST'),
      strtoupper($tpl_loopname) . '_DISPLAY'      => true,
      strtoupper($tpl_loopname) . '_PAGE_NUMBER'   => on_page($num_topics, $topics_per_page, $start),
      strtoupper($tpl_loopname) . '_PAGINATION'   => recent_topics_generate_pagination(append_sid($phpbb_root_path . $user->page['page_name'], $append_params), $num_topics, $topics_per_page, $start, false, strtoupper($tpl_loopname), $tpl_loopname . '_start'),
   ));
}

?>

If you mean that unread post links are not rewritten, then it's normal, it would be totally useless since these are in all cases redirected, and bots do not see them.

++

And how to fix the pagination?

Thanks for the help.

I use 3.0.7 version and none of your code works.

Please take a look: http://www.chaoskatzen.de/forum/

If you click on the small image (last post), you will get to: chaoskatzen.de/forum/topic2688.html&p=115504#p115504