Problem viewtopic.php update 0.4.4 --> 0.4.6

phpBB3 SEO Advanced mod Rewrite support forum.
This mods performs URL rewriting for phpBB, injecting forums and topic titles in their URLs.

Moderator: Moderators

Problem viewtopic.php update 0.4.4 --> 0.4.6

Postby fabiomaticus » Fri Nov 28, 2008 6:59 pm

I have update 0.4.4 -- > 0.4.6
I have a problem with file viewtopic.php

I have edited this file but if have apply this:

[ FIND ]------------------------------------------

// www.phpBB-SEO.com SEO TOOLKIT BEGIN
'U_BOOKMARK_TOPIC' => ($user->data['is_registered'] && $config['allow_bookmarks']) ? append_sid("{$phpbb_root_path}viewtopic.$phpEx", "f=$forum_id&t=$topic_id&bookmark=1") : '',
// www.phpBB-SEO.com SEO TOOLKIT END

[ REPLACE WITH ]------------------------------------------

// www.phpBB-SEO.com SEO TOOLKIT BEGIN
'U_BOOKMARK_TOPIC' => ($user->data['is_registered'] && $config['allow_bookmarks']) ? append_sid("{$phpbb_root_path}viewtopic.$phpEx", "f=$forum_id&t=$topic_id&bookmark=1&hash=" . generate_link_hash("topic_$topic_id")) : '',
// www.phpBB-SEO.com SEO TOOLKIT END

If I apply the changes here, I have a blank page.
fabiomaticus
PR0
PR0
 
Posts: 51
Joined: Wed Jun 06, 2007 11:46 am
Location: Taranto - Italy

Advertisement

Postby silent_thunder » Sun Nov 30, 2008 8:04 am

I have similar problem but no one seems to support for this mod
silent_thunder
 
Posts: 13
Joined: Thu Nov 27, 2008 3:09 pm

Postby SeO » Sun Nov 30, 2008 10:04 am

Well you must be doing something wrong, the code is valid and is exactly the same used in te premod's viewtopic.php.

Make sure you do the replacement without adding a typo.

@silent_thunder, 397 topics and 2282 messages in the Advanced SEO URL support forum just shows you're wrong ;)
SeO
Admin
Admin
 
Posts: 6334
Joined: Wed Mar 15, 2006 9:41 pm

Postby fabiomaticus » Sun Nov 30, 2008 1:04 pm

But the version 0.4.6 is compatible with phpbb 3.0.2?
fabiomaticus
PR0
PR0
 
Posts: 51
Joined: Wed Jun 06, 2007 11:46 am
Location: Taranto - Italy

Postby GoBieN » Sun Nov 30, 2008 9:54 pm

fabiomaticus wrote:But the version 0.4.6 is compatible with phpbb 3.0.2?

version 0.4.6 is for 3.0.3 only i think. The line you mention is a change caused by new method for making links in phpBB 3.0.3 !
GoBieN
PR1
PR1
 
Posts: 124
Joined: Mon Mar 10, 2008 7:12 pm
Location: Belgium

Postby quizzical » Sun Dec 14, 2008 7:14 pm

I have the same problem because I have the 3.0.2.
So I edited it this way

Code: Select all
   'U_BOOKMARK_TOPIC'      => ($user->data['is_registered'] && $config['allow_bookmarks']) ? append_sid("{$phpbb_root_path}viewtopic.$phpEx", "f=$forum_id&t=$topic_id&bookmark=1&hash=") : '',


How did you solve?
quizzical
 
Posts: 7
Joined: Sun Dec 14, 2008 4:05 pm

Postby quizzical » Wed Dec 31, 2008 11:15 am

quizzical wrote:I have the same problem because I have the 3.0.2.
So I edited it this way

Code: Select all
   'U_BOOKMARK_TOPIC'      => ($user->data['is_registered'] && $config['allow_bookmarks']) ? append_sid("{$phpbb_root_path}viewtopic.$phpEx", "f=$forum_id&t=$topic_id&bookmark=1&hash=") : '',


How did you solve?


someone can please tell me if this fix i made will give me problems in the future?
quizzical
 
Posts: 7
Joined: Sun Dec 14, 2008 4:05 pm

Postby SeO » Sun Jan 04, 2009 2:08 pm

What will cause trouble in the future is not to have kept phpBB up to date, this fix is good for now, but there is no guarantee it will later or that another fix won't be required.
SeO
Admin
Admin
 
Posts: 6334
Joined: Wed Mar 15, 2006 9:41 pm


Return to Advanced SEO URL

 


  • Related topics
    Replies
    Views
    Last post

Who is online

Users browsing this forum: YandexBot [Bot] and 3 guests