Point 2) could be this : phpBB SEO premod 3.0.6 released!

The issue with post urls looks like a problem with the update, did you install all the required code change in all your styles ?

dcz wrote:Point 2) could be this : phpBB SEO premod 3.0.6 released!

The issue with post urls looks like a problem with the update, did you install all the required code change in all your styles ?

Hey dee cee zee....wat a great relief. I was really wondering where have u gone.

Now lemme tell ma problems.

1) I have solved the point 2 by disabling profile ID removing. Though the problem is solved but I really liked member's profile to be like /admin/ instead of /admin-u2/ [As you said, this can be solved by phpBB SEO premod 3.0.6, I'l think of it]

2) Now, there is a problem with viewing profiles of members having special characters like _, or space or even All Caps. When I try to browse their profiles I just get a blank page. [I have PMed you the details]

3) I have edited everything accordingly as given in install file(s). But the post URLs don't appear right. The topic URL is not injected into the post URL.

4) I have got problem with the styling of Sitemapindex.xml, RSS Feed and Channel List. My skin style and template is not being properly shown in these. This forced me to disable XSLT styling for RSS Feed and Channel List. But you can have a look at sitemapindex. And sorry about the test forum. But yes, sitemapindex was having a perfect skin and styling but here on live forum it is not.

5) I have got problems with attachments. I get this error after the file has been attached[uploaded]:

onclick="var form_name = 'postform';var text_name = 'message';attach_form = document.forms[form_name].elements['attachments']; comm._HTML('[attachment=' + attach_form.value + ']', '[/attachment]',attach_form.options[attach_form.selectedIndex].text);" />

Though the files are successfully attached, but I get this and it also says Attachment error.


PS: After installing your SEO, Google and Yahoo started chasing ma forum so fast. Already 56 results found on Google within one week of installing URL rewrite . Thanks once again.

1) Profile id removing is only handy if you only allow alphanumerical characters for nicknames :

install.xml wrote:NOTE: profile and user messages pages ID removing:
__________________________________________________

phpBB/member/nicknames VS phpBB/nicknames-uxx.html

If you use profile and / or user messages pages ID removing, you should know that a custom urlencode
will be used to circumvent a bug with mod_rewrite.
This imply that some chars like "&", "/", "#" and spaces will always be double encoded.
For example a user named rock&roll will require rock%2526roll (double urlencoded &) to be usable.
( http://www.php.net/urlencode => http://issues.apache.org/bugzilla/show_bug.cgi?id=34602 )

There are other issues with custom characters, like accents, which will add some urlencoded chars in urls.
It's not an SEO issue, since bots knows about urlencoding, but it can end up building pretty long url with multi byte characters.
This does not concern the a-zA-Z0-9 chars, underscore ("_"), hyphen ("-") and dot (".") included.
In phpbb_seo/phpbb_seo_class.php, you will no longer see different methods.

This of course means that the ID removing on profile and user messages pages is more comfy and universally efficient
to use with alphanumeric chars user names (without accents).

If you only allow alphanumeric chars for your user nicknames, then you can make the injection process faster by adding :

return $url;

right after :

function seo_url_encode( $url ) {

Remember that keeping the ID here will always work and that you still can simulate a folder structure for user messages pages.

So this answers to point 2) as well.

3) Post urls are statically rewritten because they are duplicate of topic urls. You can install the zero duplicate mod to make sure that they won't be indexed, and the no duplicate mod to translate most of them to topic urls.
Also, you did not mod your styles/envision/template/forum_fn.js, use prosilver code change for it, as well as all other prosilver code changes from the install on your style.

4) Since your style seems prosilver based, you should try to activate the "load phpBB css" option, should render better. Just make sure you clear gym's cache once done, using the maintenance link in main GYM acp page.

++

Hello,

dcz wrote:1) Profile id removing is only handy if you only allow alphanumerical characters for nicknames :

So this answers to point 2) as well.

I have edited the phpbb_seo/phpbb_seo_class.php file and added return $url; after function seo_url_encode( $url ) {

But even this did not solve my problem. Accessing the profiles of members with usernames having a space, underscores and all caps gives a blank page. [Infact there is a problem with only three usernames while all other usernames profiles open perfectly. Regarding the space in username, a member's username is "Kool Kat" and clicking on it gives a blank page while another username with a space, "Test Dude" opens perfectly]

As said before, if I enable profile ID removing, everything works fine. Even those three usernames profiles also open perfectly but the links on the profile page for Admin tools such as, Administrate User, Banning, etc don't work properly. And if I keep the username links to default /memberxx.html, even this will not help as those three usernames again show a blank page.

Viewing, those three profiles on IE7 gives this:

This error (HTTP 500 Internal Server Error) means that the website you are visiting had a server problem which prevented the webpage from displaying.

dcz wrote:3) Post urls are statically rewritten because they are duplicate of topic urls. You can install the zero duplicate mod to make sure that they won't be indexed, and the no duplicate mod to translate most of them to topic urls.
Also, you did not mod your styles/envision/template/forum_fn.js, use prosilver code change for it, as well as all other prosilver code changes from the install on your style.

I have already installed Zero Duplicate and No Dupe MODs, but still the post URLs don't show the topic title. They just appear as: -http://www.my-forum.com/#p1434 which clicked returns nothing. Infact by default the post URL should have been: -http://www.my-forum.com/post1434.html#p1434

And my style is based on subsilver2. That is why I had not edited the template/forum_fn.js as nothing was mentioned about this edit in subsilver2 xml install file.

dcz wrote:4) Since your style seems prosilver based, you should try to activate the "load phpBB css" option, should render better. Just make sure you clear gym's cache once done, using the maintenance link in main GYM acp page.

Even enabling the load phpBB css option would not make it render properly. And as said above, the style is based on subsilver2.

Also, about the attachment error I had mentioned previously. Can you please tell me what could be wrong?

Thanks.

No one?

If not all problems, but I want the profiles of every member to work properly.

Br33zer wrote:I have edited the phpbb_seo/phpbb_seo_class.php file and added return $url; after function seo_url_encode( $url ) {

It's the opposite, you should only do it if your nickname are limited to a-z0-9_-. characters.
So let's say you do not use profile id removing, can you elaborate about your Admin tools link problem ?

have you tried to activate phpBB debug to see if any error message shows up ?

Br33zer wrote:I have already installed Zero Duplicate and No Dupe MODs, but still the post URLs don't show the topic title. They just appear as: -http://www.my-forum.com/#p1434 which clicked returns nothing. Infact by default the post URL should have been: -http://www.my-forum.com/post1434.html#p1434

And my style is based on subsilver2. That is why I had not edited the template/forum_fn.js as nothing was mentioned about this edit in subsilver2 xml install file.

This is a template implementation issue. Make sure you modded the overall_header.html file properly.

Br33zer wrote:Even enabling the load phpBB css option would not make it render properly. And as said above, the style is based on subsilver2.

Try deleting the .xsl files in subsilver2/template/gym_sitemaps/ and clearing GYM's cache.

Br33zer wrote:Also, about the attachment error I had mentioned previously. Can you please tell me what could be wrong?

One thing at a time please.

++

dcz wrote:It's the opposite, you should only do it if your nickname are limited to a-z0-9_-. characters.
So let's say you do not use profile id removing, can you elaborate about your Admin tools link problem?

have you tried to activate phpBB debug to see if any error message shows up ?

It does not show any error. But the links for the Admin tools or Mod tools are not proper. For example, the Banning link shows:http://www.my-forum.com/mcp.php?i=ban&mode=user&u=0&sid=9e8dfebc9e1411a2cf3354f9a6bd15c4

See the u=0. This is the problem when enabling removing profile IDS. It just take to the default form saying find user. And I get this problem for Administrate User, Test Out User's Permissions and even for Medal award links on user's profile. They all including medal award links, work fine when disabling remove user IDs.

But the links for User notes and Warn user works fine in both cases.

dcz wrote:This is a template implementation issue. Make sure you modded the overall_header.html file properly.

My edits are proper. I have rechecked all of them.

dcz wrote:Try deleting the .xsl files in subsilver2/template/gym_sitemaps/ and clearing GYM's cache.

I have done this. But doesn't help.

Br33zer wrote:It does not show any error. But the links for the Admin tools or Mod tools are not proper. For example, the Banning link shows:http://www.my-forum.com/mcp.php?i=ban&mode=user&u=0&sid=9e8dfebc9e1411a2cf3354f9a6bd15c4

See the u=0.

Oh, this one may just be this : phpBB SEO premod 3.0.6 released!
Have you checked ?

For the templates, a link to your forum would help me to understand, can you post or pm it ?

Br33zer wrote:

dcz wrote:Try deleting the .xsl files in subsilver2/template/gym_sitemaps/ and clearing GYM's cache.

I have done this. But doesn't help.

You should see prosilver style doing so. You may need to fully clear your browser's cache as well to see the result.

++

Hello,

The edits are proper. A part of my includes/functions_content.php looks like this:

Code: Select all

case 'profile':

         // Build correct profile url - only show if not anonymous and permission to view profile if registered user
         // For anonymous the link leads to a login page.
         if ($user_id && $user_id != ANONYMOUS && ($user->data['user_id'] == ANONYMOUS || $auth->acl_get('u_viewprofile')))
         {
            // www.phpBB-SEO.com SEO TOOLKIT BEGIN
            // $profile_url = ($custom_profile_url !== false) ? $custom_profile_url . '&u=' . (int) $user_id : str_replace(array('={USER_ID}', '=%7BUSER_ID%7D'), '=' . (int) $user_id, $_profile_cache['base_url']);
            global $phpbb_seo, $phpbb_root_path, $phpEx;
            $phpbb_seo->set_user_url( $username, $user_id );
            if ($custom_profile_url !== false) {
               $profile_url = reapply_sid($custom_profile_url . (strpos($custom_profile_url, '?') !== false ?  '&' : '?' ) . 'u=' . (int) $user_id);
            } else {
               $profile_url = append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=viewprofile&u=' . (int) $user_id);
            }
            // www.phpBB-SEO.com SEO TOOLKIT END
         }
         else
         {
            $profile_url = '';
         }

         // Return profile
         if ($mode == 'profile')
         {
            return $profile_url;
         }

      // no break;
   }

   if (($mode == 'full' && !$profile_url) || $mode == 'no_profile')
   {
      return str_replace(array('{USERNAME_COLOUR}', '{USERNAME}'), array($username_colour, $username), (!$username_colour) ? $_profile_cache['tpl_noprofile'] : $_profile_cache['tpl_noprofile_colour']);
   }

   return str_replace(array('{PROFILE_URL}', '{USERNAME_COLOUR}', '{USERNAME}'), array($profile_url, $username_colour, $username), (!$username_colour) ? $_profile_cache['tpl_profile'] : $_profile_cache['tpl_profile_colour']);
}

- I will pm you the details now.

Thanks.

Well, I don't have enough privilege with the test account your pmed to view the admin links (though I trust what you report), but you do seem to use the profile id removing option without restricting your username to only "a-z0-9_-." characters, so it's kind of normal that it won't work properly.

For xsl style, did you actually deleted the .xsl file from yourstyle/template/gym_sitemaps ?

Oh I thought you wanted to see the board for the template issue regarding post URLs. Anyhow, I will PM you now.

You can see for yourself:

- Post URLs.

- Admin tools from profiles.

And yes, .xsl files are deleted from the template/gym_sitemaps folder and GYM cache cleared.

Thanks.

Could you check that you have this code in memberlist.php

Code: Select all

         'U_USER_ADMIN'         => ($auth->acl_get('a_user')) ? append_sid("{$phpbb_root_path}adm/index.$phpEx", 'i=users&mode=overview&u=' . $user_id, true, $user->session_id) : '',

And if not, please post the U_USER_ADMIN line you have.
Also, could you check your phpbb_seo_class.php file, comparing it with a fresh one with winmerge for example.
You can also join these two files for me to have a look at them.

++

This is from memberlist.php that I have:

Code: Select all

         'U_USER_ADMIN'         => ($auth->acl_get('a_user')) ? append_sid("{$phpbb_root_path}adm/index.$phpEx", 'i=users&mode=overview&u=' . $user_id, true, $user->session_id) : '',

Please find the two files attached:

Start with replacing :

Code: Select all

   function seo_url_encode( $url ) {
        return $url;

with:

Code: Select all

   function seo_url_encode( $url ) {

in phpbb_seo_class.php, this is again only possible when using profile id removing with user names restricted to only "a-z0-9_-." characters.

Then, your memberlist.php file is outdated, it's not updated to phpBB3.0.6. So please update it. It could fix the issue, though, I'm not sure it will because I did not yet find the cause in these files (it could be some other file no to be up to date, you'll have to make sure).

What is the best method to update from 3.0.5 to 3.0.6 keeping all the MODs intact?

The MODS from here which I already have installed are:

1) GYM SItemaps v2.0.0

2) Zero Dupe v0.6.2

3) No Dupe v0.6.2

4) Related Topics v0.2.0

5) Seo Ultimate URL Rewrite v0.6.2

6) Optimal Title v1.0.8

7) Dynamic Meta Tags v0.4.0

And there other MODs too.