html problem

The GYM Sitemaps & RSS module for phpBB. Sitemaps and RSS feeds for Google Yahoo! and MSN Live, support, add ons etc ...

Moderator: Moderators

html problem

Postby antseo » Fri Sep 25, 2009 5:59 am

my topic contains <h1>,when i view the news,it display <h1> .it is a html encode question,but i don't know how to change it, anyone can help me?
i'm a Chinese,my english is very poor,can you understand my problem?

i think it should be changed in "gym_html.php".
antseo
 
Posts: 6
Joined: Fri Sep 25, 2009 5:44 am

Advertisement

Re: html problem

Postby antseo » Fri Sep 25, 2009 6:35 am

now ,http://www.phpbb-seo.com/en/news/
has this problem.
antseo
 
Posts: 6
Joined: Fri Sep 25, 2009 5:44 am

Re: html problem

Postby Typo » Fri Sep 25, 2009 7:52 am

I looked at http://www.phpbb-seo.com/en/news/ and I do not see the problem you are talking about.

I did a search for h1 h2 h3 and h4 and found nothing on the whole page.

Are you sure this isn't your browser?

Can you provide a link to a page with the problem or an image of the problem?

Typo
User avatar
Typo
phpBB SEO Team
phpBB SEO Team
 
Posts: 346
Joined: Sun Jan 18, 2009 11:33 am

Re: html problem

Postby antseo » Fri Sep 25, 2009 8:11 am

1.jpg

2.jpg


my browser is ie8 ,firefox 3.5.3 still has this problem

the "<h1>" is text,but in news/,it is html label
i hope it appears as text in news/ but not label
Last edited by antseo on Fri Sep 25, 2009 8:24 am, edited 1 time in total.
antseo
 
Posts: 6
Joined: Fri Sep 25, 2009 5:44 am

Re: html problem

Postby Typo » Fri Sep 25, 2009 8:21 am

This seem's to be an issue with your browser.

Image

Exactly what browser (including version) are you running?

Typo
User avatar
Typo
phpBB SEO Team
phpBB SEO Team
 
Posts: 346
Joined: Sun Jan 18, 2009 11:33 am

Re: html problem

Postby antseo » Fri Sep 25, 2009 8:30 am

i test it with internet explorer 8 and Mozilla/5.0 (Windows; U; Windows NT 6.1; zh-CN; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 (.NET CLR 3.5.30729)

3.jpg


the picture is page source of firefox 3.5.3
antseo
 
Posts: 6
Joined: Fri Sep 25, 2009 5:44 am

Re: html problem

Postby Typo » Fri Sep 25, 2009 8:46 am

I will talk with dcz about this.

Get back to you a.s.a.p..

Typo
User avatar
Typo
phpBB SEO Team
phpBB SEO Team
 
Posts: 346
Joined: Sun Jan 18, 2009 11:33 am

Re: html problem

Postby Typo » Fri Sep 25, 2009 8:50 am

This will be fixed in the next release. If the fix is commited before then and I see it, I will post it here.

Typo
User avatar
Typo
phpBB SEO Team
phpBB SEO Team
 
Posts: 346
Joined: Sun Jan 18, 2009 11:33 am

Re: html problem

Postby antseo » Fri Sep 25, 2009 9:09 am

i am very glad you can understand my problem.if "<iframe></iframe>" as html lable output in news/ ,i think it has security risk

i have not test it.

thanks.
antseo
 
Posts: 6
Joined: Fri Sep 25, 2009 5:44 am

Re: html problem

Postby dcz » Fri Sep 25, 2009 9:30 am

That is an issue !

Please replace
Code: Select all
                        if ($_params['html']) {
                           $description = str_replace('&', '&amp;', $description);
                        } else {
                           $description = htmlspecialchars($_params['striptags'] ? strip_tags($description) : $description, ENT_COMPAT, 'UTF-8');
                        }

with :
Code: Select all
                        if (empty($_params['html'])) {
                           $description = htmlspecialchars($_params['striptags'] ? strip_tags($description) : $description, ENT_COMPAT, 'UTF-8');
                        }


And :
Code: Select all
        return html_entity_decode_utf8(htmlspecialchars_decode(trim($out[1])));    

with :
Code: Select all
        return html_entity_decode(trim($out[1]), ENT_COMPAT, 'UTF-8');

in gym_sitemaps/includes/gym_rss_functions.php, that will fix it.

++
Useful links :
SEO Forum || SEO Directory || SEO phpBB || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Recherche
dcz
Admin
Admin
 
Posts: 21291
Joined: Fri Apr 28, 2006 9:03 pm

Re: html problem

Postby antseo » Fri Sep 25, 2009 10:04 am

it is ok.
many thanks
antseo
 
Posts: 6
Joined: Fri Sep 25, 2009 5:44 am


Return to GYM Sitemaps & RSS

 


  • Related topics
    Replies
    Views
    Last post

Who is online

Users browsing this forum: No registered users and 11 guests