Hello. First off, I'm running the latest version of Mixed SEO URL. Today I tried to click on a permalink for a post that was in a global announcement and it gave me a 404. It gave me this URL: http://forums.clubpenguinhq.com/post151118.html&f=92#p151118

The obvious problem is the bold text; html files cannot have PHP variables in them. All other threads (non-global announcements) work fine with post permalinks.

Is this a known bug and/or is there a fix?

Thanks,

Andy

Also, whenever I post a global announcement in one forum it shows as it being posted in another forum.

Oh but yes, there should be something done on this link in viewtopic.php, missed this during the last update.

So replace :

Code: Select all

      'U_MINI_POST'      => append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'p=' . $row['post_id']) . (($topic_data['topic_type'] == POST_GLOBAL) ? '&f=' . $forum_id : '') . '#p' . $row['post_id'],

with :

Code: Select all

      // www.phpBB-SEO.com SEO TOOLKIT BEGIN
      'U_MINI_POST'      => append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'p=' . $row['post_id'] . (($topic_data['topic_type'] == POST_GLOBAL) ? '&f=' . $forum_id : '')) . '#p' . $row['post_id'],
      // www.phpBB-SEO.com SEO TOOLKIT END

The change is minimal, we only make sure that all used var goes through append_sid (as many would think it should in all cases).

++

dcz wrote:Oh but yes, there should be something done on this link in viewtopic.php, missed this during the last update.

So replace :

Code: Select all

      'U_MINI_POST'      => append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'p=' . $row['post_id']) . (($topic_data['topic_type'] == POST_GLOBAL) ? '&f=' . $forum_id : '') . '#p' . $row['post_id'],

with :

Code: Select all

      // www.phpBB-SEO.com SEO TOOLKIT BEGIN
      'U_MINI_POST'      => append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'p=' . $row['post_id'] . (($topic_data['topic_type'] == POST_GLOBAL) ? '&f=' . $forum_id : '')) . '#p' . $row['post_id'],
      // www.phpBB-SEO.com SEO TOOLKIT END

The change is minimal, we only make sure that all used var goes through append_sid (as many would think it should in all cases).

++

Thanks! That worked perfectly