no dupe error

[TomaS]

I have some strings error in no dupe mode it seems to be problem here

Code: Select all

// www.phpBB-SEO.com SEO TOOLKIT BEGIN -> no dupe
         if ($phpbb_seo->seo_opt['no_dupe']['on'] && !$row['forum_password'] && $auth->acl_get('f_read', $row['forum_id_last_post'])) {
            $last_post_url =  append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $row['forum_id_last_post'] . '&t=' . $row['topic_id'] . '&start=' . @intval($phpbb_seo->seo_opt['topic_last_page'][$row['topic_id']]) ) . '#p' . $row['forum_last_post_id'];
            // Limit in chars for the last post link text.
            $char_limit = 25;
            // Limit topic text link to $char_limit, without breacking words
            $topic_text_lilnk = $char_limit > 0 && ( ( $length = utf8_strlen($phpbb_seo->seo_censored[$row['topic_id']]) ) > $char_limit ) ? utf8_strlen($fragment = utf8_substr($phpbb_seo->seo_censored[$row['topic_id']], 0, $char_limit + 1 - 4)) < $length + 1 ? preg_replace('`\s*\S*$`', '', $fragment) . ' ...' : $phpbb_seo->seo_censored[$row['topic_id']] : $phpbb_seo->seo_censored[$row['topic_id']];
            $last_post_link = '<a href="' . append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $row['forum_id_last_post'] . '&amp;t=' . $row['topic_id']) . '" title="' . $phpbb_seo->seo_censored[$row['topic_id']] . ' : ' . $phpbb_seo->seo_opt['topic_forum_name'][$row['topic_id']] . '">' . $topic_text_lilnk . '</a>';
         } else {   
            $last_post_url =  append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $row['forum_id_last_post'] . '&amp;p=' . $row['forum_last_post_id']) . '#p' . $row['forum_last_post_id'];
            $last_post_link = '';
         }
      }
      else
      {
         $last_post_subject = $last_post_time = $last_post_url = $last_post_link = '';
         // www.phpBB-SEO.com SEO TOOLKIT END -> no dupe

whit that last else

i never look on that how is the different between no dupe and zero dupe mod?Zero redirect indexed url to existing if they are not same but dont allow to bots indexed again the same like url whit sids.but waht do no dupe?

[SeO]

Sorry the find / replace was unclear, add :

Code: Select all

      }

after :

Code: Select all

         // www.phpBB-SEO.com SEO TOOLKIT END -> no dupe

in this instruction.

Install files updated in the mod.

[TomaS]

ou i tried add that string but before this $last_post_subject = $last_post_time = $last_post_url = $last_post_link = '';
never mind glad to help you.
And for what it is good?I dont have clear in mod describe ehat is exactly doing.PLs if you have time compare no dupe whit zero dupe thx

[TomaS]

ups still error here again whi last else

Code: Select all

// www.phpBB-SEO.com SEO TOOLKIT BEGIN -> no dupe
         if ($phpbb_seo->seo_opt['no_dupe']['on'] && !$row['forum_password'] && $auth->acl_get('f_read', $row['forum_id_last_post'])) {
            $last_post_url =  append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $row['forum_id_last_post'] . '&t=' . $row['topic_id'] . '&start=' . @intval($phpbb_seo->seo_opt['topic_last_page'][$row['topic_id']]) ) . '#p' . $row['forum_last_post_id'];
            // Limit in chars for the last post link text.
            $char_limit = 25;
            // Limit topic text link to $char_limit, without breacking words
            $topic_text_lilnk = $char_limit > 0 && ( ( $length = utf8_strlen($phpbb_seo->seo_censored[$row['topic_id']]) ) > $char_limit ) ? utf8_strlen($fragment = utf8_substr($phpbb_seo->seo_censored[$row['topic_id']], 0, $char_limit + 1 - 4)) < $length + 1 ? preg_replace('`\s*\S*$`', '', $fragment) . ' ...' : $phpbb_seo->seo_censored[$row['topic_id']] : $phpbb_seo->seo_censored[$row['topic_id']];
            $last_post_link = '<a href="' . append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $row['forum_id_last_post'] . '&amp;t=' . $row['topic_id']) . '" title="' . $phpbb_seo->seo_censored[$row['topic_id']] . ' : ' . $phpbb_seo->seo_opt['topic_forum_name'][$row['topic_id']] . '">' . $topic_text_lilnk . '</a>';
         } else {   
            $last_post_url =  append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $row['forum_id_last_post'] . '&amp;p=' . $row['forum_last_post_id']) . '#p' . $row['forum_last_post_id'];
            $last_post_link = '';
         }
      }
      else
      {
         $last_post_subject = $last_post_time = $last_post_url = $last_post_link = '';
         // www.phpBB-SEO.com SEO TOOLKIT END -> no dupe
      }

and one mistake in seo_clas
Activate The No duplictate:
The No duplicate mod remplaces

[SeO]

Jeeez !

Releasing is a nightmare, and you are unlucky enough to raise all the recent bug

Anyway, the install should now be fully fixed. Install file is actually the hardest part in mods

You'll just need to fix that particular replace again.

Sorry about that.

++

[TomaS]

ok i am ready to try it again for my lucky i need replace only this part for full mod action

and btw i dont know what this mod exactlydoes?i read it replace post url to topic url but i cant magine that
edit// now is it work good and see what it does.But my forum is litle bit biger in lines

[SeO]

Great

So this mod replaces the post links with the corresponding topic links (pagination and html anchor included) in phpBB's page, the zero duplicate can redirect post urls, but it's not altering the links on the page.

It's very efficient for the index to display topic links.
You can easily get rid of the extra link though, and only keep the last post one with the topic url if you prefer.

Thanks for reporting the typo in the language file, will fix it when the mod rewrite will be updated.

[TomaS]

uf,
you are going to make update again?wasnt update today?I am little bit confused.
Ok just two question:for what is this good for seo optimization i think it is good like tweak link quicl jump to topic or not?
and second my forum is now litle bit biger in line it need some grafic edit to looks better or make this mod only in two lines, or delet date(but delet date is not good solution)
now i am going to isntall meta tags mod so be prepare to report it

[SeO]

The language file typo is in the mod rewrite language file, haven't you noticed you did not add any language entry when installing the mod, they where already there

Then, from what I see here : http://www.phpbb3.sk/forum/ the topic links does not seem to be problematic as far as styling. Titles are always shorter than the last post date line, and three line high for a forum row does not seems this much to me, usually, it's even more that that with longer forum description and sub forum listing so ...

The meta tag mod will be ok this time

[TomaS]

Ok i solved it whit some changes in code and now is it perfect
Meta mod works great like every mod from here.I didnt want it on my forum but in Google webmasters tools i read that i have around 310 duplicate meta so this is the right solution for my problem.
thx dcz/SeO