[phpBB.com] phpBB 3.0.5 is released!

[SeO]

phpBB3.0.5 is now released at phpBB.com : http://www.phpbb.com/community/viewtopi ... &t=1625005

We are going to update the SEO premod and then the standalone SEO mod. This should occur by the end of this week

Expect new features

[Typo]

Code: Select all

[01-Jun-2009  08:21:11 -14400] [phpBB Debug] [client 98.232.72.47] [File index.php] PHP Notice: in file /home/computer/public_html/includes/functions_content.php on line 1272 : Undefined variable: cache_key
[01-Jun-2009  08:21:11 -14400] [phpBB Debug] [client 98.232.72.47] [File index.php] PHP Notice: in file /home/computer/public_html/includes/functions_content.php on line 1269 : Undefined variable: phpbb_root_path

Your mod is kicking back errors now due to some now undefined variables that your mod relys on. You say updates should be available by the end of the week but im concerned with what impact this could have on my board until then. I'm assuming its your mod since the only code throwing back errors (so far) is in a block of code from the seo mod but i am going to start researching more.

Do I need to downgrade?

Also, please do the standalone first so those of us that already use and count on this mod can get up to date, fully functional and error free. These errors, by the way, already had filled 1.6 megs in just a few minutes as it is spitting out 37kb in errors to the file every single time the index is visited, the file size will definitely be something I have to watch until this is fixed.

I wanted to post the errors here before I tried looking into fixing them myself in the hopes that making you aware may inspire a temp fix or maybe a proprity towards finishing the standalone first.

Thanks

Typo

[Typo]

Well I think I see the issue. The code in question (in functions_content.php) seems to have caused some other code changes to be skipped. It's odd because I re-ran the installer for 3.0.5 update and it checked all files again and said all edits where done and yet it obviously skipped this one.

I will post if I fix it.

Typo

[Typo]

Ok, it was a complete mess. The updater left a huge section of code behind. So, after looking at the code, I made the following fix.
I had to first remove the:

Code: Select all

   // Profile url - only show if not anonymous and permission to view profile if registered user
   // For anonymous the link leads to a login page.
   if ($user_id && $user_id != ANONYMOUS && ($user->data['user_id'] == ANONYMOUS || $auth->acl_get('u_viewprofile')))
   {
      // www.phpBB-SEO.com SEO TOOLKIT BEGIN
      /*if (empty($_base_profile_url))
      {
         $_base_profile_url = append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=viewprofile&u={USER_ID}');
      }
      $profile_url = ($custom_profile_url !== false) ? $custom_profile_url . '&u=' . (int) $user_id : str_replace('={USER_ID}', '=' . (int) $user_id, $_base_profile_url);*/
      global $phpbb_seo;
      $phpbb_seo->set_user_url( strip_tags($username), $user_id );
      $profile_url = ($custom_profile_url !== false) ? $custom_profile_url . '&u=' . (int) $user_id : append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=viewprofile&u=' . (int) $user_id);
      // www.phpBB-SEO.com SEO TOOLKIT END
      $tpl = (!$username_colour) ? '<a href="{PROFILE_URL}" onmouseover="show_popup(' . $user_id . ')" onmouseout="close_popup()">{USERNAME}</a>' : '<a href="{PROFILE_URL}" style="color: {USERNAME_COLOUR};" class="username-coloured" onmouseover="show_popup(' . $user_id . ')" onmouseout="close_popup()">{USERNAME}</a>';
      $_profile_cache[$cache_key]['full'] = str_replace(array('{PROFILE_URL}', '{USERNAME_COLOUR}', '{USERNAME}'), array($profile_url, $username_colour, $username), $tpl);
   }
   else
   {
      $tpl = (!$username_colour) ? '{USERNAME}' : '<span style="color: {USERNAME_COLOUR};" class="username-coloured">{USERNAME}</span>';
      $_profile_cache[$cache_key]['full'] = str_replace(array('{USERNAME_COLOUR}', '{USERNAME}'), array($username_colour, $username), $tpl);
      $profile_url = '';
   }


Then I had to chage:

Code: Select all

         // Build correct profile url - only show if not anonymous and permission to view profile if registered user
         // For anonymous the link leads to a login page.
         if ($user_id && $user_id != ANONYMOUS && ($user->data['user_id'] == ANONYMOUS || $auth->acl_get('u_viewprofile')))
         {
            $profile_url = ($custom_profile_url !== false) ? $custom_profile_url . '&u=' . (int) $user_id : str_replace(array('={USER_ID}', '=%7BUSER_ID%7D'), '=' . (int) $user_id, $_profile_cache['base_url']);
         }
         else
         {
            $profile_url = '';
         }


To:

Code: Select all

         // Build correct profile url - only show if not anonymous and permission to view profile if registered user
         // For anonymous the link leads to a login page.
         if ($user_id && $user_id != ANONYMOUS && ($user->data['user_id'] == ANONYMOUS || $auth->acl_get('u_viewprofile')))
         {
         // phpBB SEO begin
         //   $profile_url = ($custom_profile_url !== false) ? $custom_profile_url . '&u=' . (int) $user_id : str_replace(array('={USER_ID}', '=%7BUSER_ID%7D'), '=' . (int) $user_id, $_profile_cache['base_url']);
         global $phpbb_seo;
         global $phpbb_root_path, $phpEx;
         $phpbb_seo->set_user_url( strip_tags($username), $user_id );
         $profile_url = ($custom_profile_url !== false) ? $custom_profile_url . '&u=' . (int) $user_id : append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=viewprofile&u=' . (int) $user_id);
         // phpBB SEO end
         }
         else
         {
            $profile_url = '';
         }

The code would look a bit different for other people as there is actually a second mod in there for the AJAX UserInfo mod.

I just figured I should post this, I doubt it will be much help to the masses but perhaps someone will find it useful information.

Typo

[SeO]

If this is the only part causing trouble with the automatic updater, then it's pretty good. This one is due to get_username_string() being updated (again, since it already was in 3.0.4) in functions_content.php. And your fix is very close to the one we already put together.

Though, we're up to quite a major update of the SEO mods (SEO URL and GYM mainly), so unless you are willing to update right now, you should wait until we release them. At least user with fewer coding skills should save themselves the hassle of doing a double update.

[Daku]

When is the new update likely to be released SeO?

Would that be after you have released update for 3.0.5? I am waiting for your release as I have been using SEO version without any issues for almost a year now

[Typo]

I am also very curious on the release date of these. We do ofcourse understand that any date u give is purely an approximate and we promise not to be upset in any way if it happens to take longer.

Mainly just wondering, are we talking days, weeks, months?

Any info is greatly appreciated.

Thanks.

Typo

[Gisher]

Typo

This should occur by the end of this week

[Typo]

Awesome. Keep up the great effort. You guys provide a great set of mods that in my opinion are a must to have. Keep it up.

Give me a holler if you need help testing it.

Typo

[drankur]

wow expect new features is really thrilling, i am waiting keeping fingers crossed

[Typo]

Don't get too excited. I asked and the next release does NOT make coffee. I have been making a request for this feature but it goes unheeded. Do we not all love coffee? Does it not keep us awake on long nights of coding or cruising about the interweb. I envision a cup of coffee served with every url. I think maybe if more of us demand the coffee addon, perhaps, just maybe they will do it.

Typo

[The_Wizard]

^
i like coca cola

i'm waiting the update for premod.

[5942marine]

Question. For the next release, is it going to be a modx install maybe?

[dcz]

I asked and the next release does NOT make coffee.

Too bad, because putting it together really required some

Anyway, here it is : phpBB SEO premod 3.0.5 released!

We're thinking about modx for our mods, but the SEO premod does not really need a modx install file, since it's not really a mod

++

[5942marine]

Yeah, that totally makes sense.

It would be cool though, if your stand alone mods were modx. That way, when it comes time for future upgrades to phpbb3, you just temporarily un-install it, before updating.

Anyways, thanks guys, I love the mods, site would be crap without it.