MODX installation mistake ...

Discussions and support about the different URL Rewriting techniques for phpBB.

Moderator: Moderators

MODX installation mistake ...

Postby LMS » Fri Mar 12, 2010 12:31 pm

After installing thru AutoMOD, the viewtopic_body.html file conten missing some parts. Hier is the fix for the install.xml MODX file (change the whole <open> block, against this):
Code: Select all
                <open src="styles/prosilver/template/viewtopic_body.html">
                        <edit>
                                <find><![CDATA[<a href="#p{postrow.POST_ID}">]]></find>
                                <inline-edit>
                                        <inline-find><![CDATA[<a href="#p{postrow.POST_ID}">]]></inline-find>
                                        <inline-action type="replace-with"><![CDATA[<a href="{U_VIEW_TOPIC}#p{postrow.POST_ID}">]]></inline-action>
                                </inline-edit>
                        </edit>
                        <edit>
                                <find><![CDATA[<a href="#wrap" class="top" title="{L_BACK_TO_TOP}">]]></find>
                                <inline-edit>
                                        <inline-find><![CDATA[<a href="#wrap" class="top" title="{L_BACK_TO_TOP}">]]></inline-find>
                                        <inline-action type="replace-with"><![CDATA[<a href="{U_VIEW_TOPIC}#wrap" class="top" title="{L_BACK_TO_TOP}">]]></inline-action>
                                </inline-edit>
                        </edit>
                </open>

Thx,
Michael
LMS
 
Posts: 4
Joined: Fri Mar 12, 2010 11:54 am

Advertisement

Re: MODX installation mistake ...

Postby dcz » Fri Mar 12, 2010 2:36 pm

Well, the find this replace with that seems to be rather logical since there is no possible confusion, I also wonder why automod would not take it while it seems to accept that you search for something within a line directly (not necessarily the whole line) and then do an in line search in it.
I used a minimalistic approach here to match most of the styles directly.

But if it's the only things that would make this to work with automod, well, let's add it : http://phpbb-seo.coda-cola.net/projects ... visions/41
As you can see : http://phpbb-seo.coda-cola.net/projects ... nstall.xml

I used an in-line-before-add with the hope it will help those with custom style to better understand the operation, should work with automod, but I did not test.

++
Useful links :
SEO Forum || SEO Directory || SEO phpBB || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Recherche
dcz
Admin
Admin
 
Posts: 21219
Joined: Fri Apr 28, 2006 9:03 pm

Re: MODX installation mistake ...

Postby LMS » Fri Mar 12, 2010 3:39 pm

Yes, it's a better solution for moded templates (but maybe it would better to only search for the ankers in the <find>, because they are uniqe ;-).

Thx,
Michael
LMS
 
Posts: 4
Joined: Fri Mar 12, 2010 11:54 am

Re: MODX installation mistake ...

Postby dcz » Fri Mar 12, 2010 4:00 pm

Yes, but doing so would really stop making sense, eg search for something, re search for the same thing in the line (composed of only this string to find at first) ...
Of course, automod may not reach such sophistication in its "understanding", and I am certainly wrong to care about such tautological matters, but ... :roll:
At least this way, the code change is clearly understandable for the target style and does help user to understand what could be done on other styles ;)
Useful links :
SEO Forum || SEO Directory || SEO phpBB || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Recherche
dcz
Admin
Admin
 
Posts: 21219
Joined: Fri Apr 28, 2006 9:03 pm

Re: MODX installation mistake ...

Postby LMS » Sat Mar 13, 2010 8:58 pm

I think, the idea behind this is, that you can search for an specific block and then replace in this block a specific sentence. It allow a better targeting for identical lines of code and allow to find your way through identical codelines to replace your specific codeblock ;-)

Bye,
Michael
LMS
 
Posts: 4
Joined: Fri Mar 12, 2010 11:54 am

Re: MODX installation mistake ...

Postby dcz » Sun Mar 14, 2010 1:04 pm

But of course, this I understand, it's just that the first string to search for is already an in-line find since it's not an entire line.
Perhaps the way to make the most sense would be to first search for the whole line, but I'm afraid that would make it more difficult for custom styles.

Of course, we're here playing with details ;)

++
Useful links :
SEO Forum || SEO Directory || SEO phpBB || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Recherche
dcz
Admin
Admin
 
Posts: 21219
Joined: Fri Apr 28, 2006 9:03 pm


Return to phpBB mod Rewrite

 


  • Related topics
    Replies
    Views
    Last post

Who is online

Users browsing this forum: No registered users and 4 guests


 
cron