Change missing from No Duplicate 0.4.4 => 0.6.0 update

Support for the phpBB3 SEO mods released in the phpBB3 SEO Toolikt forum.

Moderator: Moderators

Change missing from No Duplicate 0.4.4 => 0.6.0 update

Postby zoom123 » Sat Jun 27, 2009 10:48 pm

Hello,

I am currently using No Duplicate 0.4.4 and I downloaded version 0.6.0 to upgrade.
I followed all the instructions in the "0.4.4_0.6.0_No_dupe_Update.txt" file but when I compared the result with the one in "phpBB-SEO-No-Dupe_V_0.6.0.txt" it seems there is a change which is missing.

This:

Code: Select all
   // www.phpBB-SEO.com SEO TOOLKIT BEGIN -> no dupe
   if (@$phpbb_seo->seo_opt['no_dupe']['on']) {
      $sql_array['SELECT'] .= ', t.topic_id, t.topic_title, t.topic_replies, t.topic_replies_real, t.topic_status, t.topic_type, t.topic_moved_id';
      $sql_array['LEFT_JOIN'][] = array(
         'FROM'   => array(TOPICS_TABLE => 't'),
         'ON'   => "t.topic_last_post_id = f.forum_last_post_id"
      );
   }
   // www.phpBB-SEO.com SEO TOOLKIT END -> no dupe


Should be changed to this:

Code: Select all
   // www.phpBB-SEO.com SEO TOOLKIT BEGIN -> no dupe
   if ($phpbb_seo->seo_opt['no_dupe']['on']) {
      $sql_array['SELECT'] .= ', t.topic_id, t.topic_title, t.topic_replies, t.topic_replies_real, t.topic_status, t.topic_type, t.topic_moved_id' . (!empty($phpbb_seo->seo_opt['sql_rewrite']) ? ', t.topic_url ' : ' ');
      $sql_array['LEFT_JOIN'][] = array(
         'FROM'   => array(TOPICS_TABLE => 't'),
         'ON'   => "t.topic_last_post_id = f.forum_last_post_id"
      );
   }
   // www.phpBB-SEO.com SEO TOOLKIT END -> no dupe


But this change is not mentioned in the update file.
zoom123
 
Posts: 11
Joined: Tue Jan 27, 2009 3:44 am

Advertisement

Re: Change missing from No Duplicate 0.4.4 => 0.6.0 update

Postby dcz » Sun Jun 28, 2009 9:24 am

Jeez, this is true, and that's why some experienced some non reproducible bugs !

I'm going to update the packages, thanks for reporting ;)

++
Useful links :
SEO Forum || SEO Directory || SEO phpBB || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Recherche
dcz
Admin
Admin
 
Posts: 21407
Joined: Fri Apr 28, 2006 9:03 pm


Return to phpBB SEO MODS

 


  • Related topics
    Replies
    Views
    Last post

Who is online

Users browsing this forum: No registered users and 8 guests