Hello,

I am currently using No Duplicate 0.4.4 and I downloaded version 0.6.0 to upgrade.
I followed all the instructions in the "0.4.4_0.6.0_No_dupe_Update.txt" file but when I compared the result with the one in "phpBB-SEO-No-Dupe_V_0.6.0.txt" it seems there is a change which is missing.

This:

Code: Select all

   // www.phpBB-SEO.com SEO TOOLKIT BEGIN -> no dupe
   if (@$phpbb_seo->seo_opt['no_dupe']['on']) {
      $sql_array['SELECT'] .= ', t.topic_id, t.topic_title, t.topic_replies, t.topic_replies_real, t.topic_status, t.topic_type, t.topic_moved_id';
      $sql_array['LEFT_JOIN'][] = array(
         'FROM'   => array(TOPICS_TABLE => 't'),
         'ON'   => "t.topic_last_post_id = f.forum_last_post_id"
      );
   }
   // www.phpBB-SEO.com SEO TOOLKIT END -> no dupe


Should be changed to this:

Code: Select all

   // www.phpBB-SEO.com SEO TOOLKIT BEGIN -> no dupe
   if ($phpbb_seo->seo_opt['no_dupe']['on']) {
      $sql_array['SELECT'] .= ', t.topic_id, t.topic_title, t.topic_replies, t.topic_replies_real, t.topic_status, t.topic_type, t.topic_moved_id' . (!empty($phpbb_seo->seo_opt['sql_rewrite']) ? ', t.topic_url ' : ' ');
      $sql_array['LEFT_JOIN'][] = array(
         'FROM'   => array(TOPICS_TABLE => 't'),
         'ON'   => "t.topic_last_post_id = f.forum_last_post_id"
      );
   }
   // www.phpBB-SEO.com SEO TOOLKIT END -> no dupe


But this change is not mentioned in the update file.

Jeez, this is true, and that's why some experienced some non reproducible bugs !

I'm going to update the packages, thanks for reporting

++