[No Dupe] no last_post_link in subcategories with subforums

Support for the phpBB3 SEO mods released in the phpBB3 SEO Toolikt forum.

Moderator: Moderators

[No Dupe] no last_post_link in subcategories with subforums

Postby whocarez » Tue Feb 12, 2013 4:16 pm

Hello,

I've got the following problem with

phpBB SEO No Duplicate V 0.6.6
on phpbb 3.0.11 with phpBB SEO Ultimate SEO URL V 0.7.0.

There is no last_post_link for subforums in subcategories.
The following structure:
[category]
....|___________|____________|
[subforum]..[subcategory1] [subcategory2]
.....................|____________|
.............[7 subforums]....[7 subforums]

so the lastpostlink is shown on the index only for the subforum on the first level, but not from the posts of these second level subforums in the subcategories. There is only the standard phpbb behaviour to show the post_user with the none seo-url (e.g. /viewtopic.php?f=19&t&start#p32096)
If I go a level down, then the posts from the next deeper level are shown up with last_post_link

I several times proved my edits, but I can't find something.
Where to look? Thanks!
whocarez
 
Posts: 16
Joined: Mon Mar 29, 2010 6:36 pm

Advertisement

Re: [No Dupe] no last_post_link in subcategories with subfor

Postby whocarez » Thu Feb 14, 2013 8:37 pm

Maybe the problem is not clear, when I only describe it in my poor English.
So, I made a screenshot, hope that the problem is now more clear and that the mod is not abandoned ... :-)

phpbb-seo.jpg
whocarez
 
Posts: 16
Joined: Mon Mar 29, 2010 6:36 pm

Re: [No Dupe] no last_post_link in subcategories with subfor

Postby whocarez » Thu Feb 14, 2013 9:21 pm

I recognized, that the problem is one of the posts in the second level ...

Code: Select all
$last_post_link = '<a href="' . append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $row['forum_id_last_post'] . '&amp;t=' . $row['topic_id']) . '" title="' . $topic_title . ' : ' . $phpbb_seo->seo_opt['topic_forum_name'][$row['topic_id']] . '">' . $topic_text_lilnk . '</a>';

results in
Code: Select all
<a title=" : test" href="domain/viewtopic.php?f=32&t"></a>


Code: Select all
$last_post_url =  append_sid("{$phpbb_root_path}viewtopic.$phpEx", 'f=' . $row['forum_id_last_post'] . '&amp;t=' . $row['topic_id'] . '&amp;start=' . @intval($phpbb_seo->seo_opt['topic_last_page'][$row['topic_id']]) ) . '#p' . $row['forum_last_post_id'];

results in
Code: Select all
/viewtopic.php?f=32&t&start#p32290


any hint to get the links from subforum or subcategories?
whocarez
 
Posts: 16
Joined: Mon Mar 29, 2010 6:36 pm

Re: [No Dupe] no last_post_link in subcategories with subfor

Postby whocarez » Fri Feb 15, 2013 7:05 am

a workaround is to add
Code: Select all
&& !empty($row['topic_id'])
or
Code: Select all
&& !empty($row['topic_title'])

in the no dupe condition, so at least there are no false links.
Code: Select all
  if (!empty($phpbb_seo->seo_opt['no_dupe']['on']) && !$row['forum_password'] && $auth->acl_get('f_read', $row['forum_id_last_post']) && !empty($row['topic_id']))
whocarez
 
Posts: 16
Joined: Mon Mar 29, 2010 6:36 pm


Return to phpBB SEO MODS

 


  • Related topics
    Replies
    Views
    Last post

Who is online

Users browsing this forum: No registered users and 13 guests