Hi,

installed the pre-mod.

It seems that high lighted text in urls causes an error in redirection somehow...


With urls like:

-t20508.html?hilit=big%20bike#p48352

-t20508.html?hilit=big%20bike


Is there something I can do about this?

regards,

bv

The page isn't redirecting properly

Firefox has detected that the server is redirecting the request for this address in a way that will never complete.

This problem can sometimes be caused by disabling or refusing to accept cookies

It's one of the very few bugs of this release. Actually, it's a tricky matter since part of the problematic is browser dependent (FF will most likely encode accentuated chars in Latin1 when IE and opera will use utff8), but we'll soon come up with a final fix for this.

Until then, you'll find a workaround here : http://www.phpbb-seo.com/boards/advance ... html#14085

Oh, funny characters in user names are not converted to ascii in urls...

Lapré becomes /member/Lapr%25C3%25A9 ....

Otherwise, thanks a lot.....

http://balipod.com/

Oh....

It seems that redirects are not ok if a user wants to display a post that is hidden because of being made by a foe .....

bv wrote:Oh, funny characters in user names are not converted to ascii in urls...

Lapré becomes /member/Lapr%25C3%25A9 ....

Otherwise, thanks a lot.....

http://balipod.com/

This is normal, that's how bad utf8 urlencode looks like, you'll find more about this in the install file, the ID removing for profile really is meant for alphanumeric chars, at least, if you want nice urls.

About the redirected link that shouldn't could you post here the guilty url, before and after the redirect ?

When a a post is blocked becuase the poster being on your foe list, you get a text like this:

This post was made by USER who is currently on your ignore list. Display this post.

And the link points to:

-http://domain.com/viewtopic.php?f=2&t=20650&p=48451&view=show#p48451

When clicked, the page redirects to:

-http://domain.com/forum-f2/topic-title-t20650.html#p48451

and the hidden post is not shown....

Thanks, we really need to update the zero dupe.

so, until then, you can do this :

In viewtopic.php, add :

Code: Select all

   $phpbb_seo->seo_cond( (utf8_strpos($phpbb_seo->seo_path['uri'], 'view=show') === FALSE) );

after :

Code: Select all

   $phpbb_seo->seo_cond( (utf8_strpos($phpbb_seo->seo_path['uri'], 'view=print') === FALSE) );

and add :

Code: Select all

      $phpbb_seo->seo_cond( (utf8_strpos($phpbb_seo->seo_path['uri'], 'view=show') !== FALSE), false, 'do');

after :

Code: Select all

      $phpbb_seo->seo_cond( (utf8_strpos($phpbb_seo->seo_path['uri'], 'view=print') !== FALSE), false, 'do');

should do the trick.

Yes, trick worked, thanks..

Is this already been fixed? Because it is not working on my board and $phpbb_seo->seo_cond doesnt seem to exist anymore

Link example;

viewtopic.php?f=13&t=48362&p=1519652&view=show#p1519652

You seems to have forgotten to add the zero dupe code in the new phpbb_seo_class.php file while updating :

update file wrote:!!!!! YOU WILL HAVE TOO take the new phpbb_seo_class.php file and redo the mod you eventually made there,
Like the zero duplicate or the static and delimiters.
There are many changes in this file so it is faster this way.

Ehrm no I don't... Otherwise a lot more would be broken I guess... Any particular line which is obvious missing?

I searched on "show" and I couldn't find anything so I guess something is not quite right.

The link isn't SEO't, because of the stop var I guess.. But it isnt working... Because... Lets have a look...

[...]

Hey thats funny... In the search results its working.. But not in viewtopic

Anyway view=show#p999999:

viewtopic = 301 moved
search = 200 OK

It shouldn't be 301'ing in viewtopic

I think we confused a bit here, the bug mentioned was fixed long ago, and the zero dupe still uses the phpbb_seo::seo_cond method.

So if you are in the end only talking about the fact that this url is not rewritten, this is done on purpose, because it's a duplicate and as well because bot do not have friends and foes

OK confused a bit indeed...

The link is -not- SEO't / rewritten but it isn't working either. If I click on it, it just reloads the same topic and the post stays hidden.

If I sniff it then it tells me there is a 301 header on it. It shouldn't 301.

However, in the search its working correctly. When clicking the link it shows the post...

search.php?st=180&sk=t&sd=d&author=example&ch=1000&start=0&p=1522808&view=show#p1522808

Is it better to start a thread about it in the zero dupe section?

I used the search but it is not exactly the same problem I realize now.

Ho could be the zero dupe, try to set post redirection to guest, and if not enough, disable strict mod and tell me what you get.

Doesnt have any effect... Can I echo a line er echo something in a function to test if some routine is being done?