little bug at install_phpbb_seo.php

phpBB SEO Premod for phpBB3 support forum.
This premodded version of phpBB3 includes the three different type of URL rewriting for phpBB3 by phpBB SEO. It comes with several other Search Engine Optimization mods installed.

Moderator: Moderators

little bug at install_phpbb_seo.php

Postby hroudel » Thu Nov 27, 2008 11:01 pm

I found a little bug in phpbb SEO premod v3.0.3 at install/install_phpbb_seo.php

Code: Select all
Line 51:
$body = '<p>' . $lang['SEO_PREMOD_LICENCE'] . '</p><br/><hr/>' . implode("<br/>\n", file('./docs/COPYING'));

It should be

$body = '<p>' . $lang['SEO_PREMOD_LICENCE'] . '</p><br/><hr/>' . implode("<br/>\n", file('../phpbb_seo/docs/COPYING'));


Code: Select all
./ means current dir
../ means one level up or parent directory


i hope that phpbb seo premod is still released under RECIPROCAL PUBLIC LICENCE :)
hroudel
 
Posts: 14
Joined: Thu Nov 27, 2008 3:43 pm

Advertisement

Postby dcz » Fri Nov 28, 2008 9:47 am

The path is correct since the phpbb_seo_install.php script must be started from within the phpbb_seo/ dir, so the path to phpbb_seo/docs/ indeed is ./docs/.

You would not be able to see the license otherwise.

And yes our URL rewriting mods are still using RPL, the premod is thus using three licences, GPL for the phpBB code, RPL for the url rewriting code and LGPL for GYM sitemaps & RSS.

++
Useful links :
SEO Forum || SEO Directory || SEO phpBB || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Recherche
dcz
Admin
Admin
 
Posts: 21238
Joined: Fri Apr 28, 2006 9:03 pm

Postby hroudel » Fri Nov 28, 2008 6:28 pm

yap you are right at phpbb_seo/phpbb_seo_install.php file is path correct, but i mean file install_phpbb_seo.php at install dir. This file is started at install dir so path should be
Code: Select all
../phpbb_seo/docs/COPYING


I installed this mod by copying all files from archive and by entering URL of my site to browser. This will redirect me to install dir.

Thanks for this great SEO mod for great phpbb :)
hroudel
 
Posts: 14
Joined: Thu Nov 27, 2008 3:43 pm

Postby dcz » Sat Dec 06, 2008 8:34 am

You're right, the packages was missing the install/doc/ dir :roll:

Packages are now fixed ;)
Useful links :
SEO Forum || SEO Directory || SEO phpBB || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Recherche
dcz
Admin
Admin
 
Posts: 21238
Joined: Fri Apr 28, 2006 9:03 pm


Return to phpBB SEO Premod

Who is online

Users browsing this forum: No registered users and 5 guests