some topic titles are wrong

phpBB SEO Premod for phpBB3 support forum.
This premodded version of phpBB3 includes the three different type of URL rewriting for phpBB3 by phpBB SEO. It comes with several other Search Engine Optimization mods installed.

Moderator: Moderators

some topic titles are wrong

Postby janmyszkier » Mon Dec 15, 2008 7:40 pm

I found out some of my topic titles are badly shown
some are :

some-title-some-other-text-t1234.html

while others:

topic-t1234.html

anyone else has this problem maybe?

Version is 3.0.3
janmyszkier
PR0
PR0
 
Posts: 50
Joined: Fri Oct 12, 2007 11:47 pm
Location: Wroclaw, Poland.

Advertisement

Postby dcz » Sun Dec 21, 2008 9:42 am

This occurs when no title was sent to the phpbb_seo class for url injection.

Where did these links came from (what page) ?
Useful links :
SEO Forum || SEO Directory || SEO phpBB || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Recherche
dcz
Admin
Admin
 
Posts: 21219
Joined: Fri Apr 28, 2006 9:03 pm

Postby janmyszkier » Sun Dec 21, 2008 1:53 pm

it seems they occur everytime when a special character is present in topic title
janmyszkier
PR0
PR0
 
Posts: 50
Joined: Fri Oct 12, 2007 11:47 pm
Location: Wroclaw, Poland.

Postby SeO » Mon Dec 22, 2008 8:39 am

Ho you mean if it is only composed of high bit characters (non latin) ?

It would be normal.

Release thread wrote:Char-sets

    phpBB3 uses UTF-8 as final encoding, and this should be enough to handle all cases.
    UTF-8 is fully supported by this mod.
    This mod rewrite will only inject the ASCII Chars ( after removing all accents ) available in the titles.
    For example : "نرم افزار - Software niño" will be formated prior to injection in the following way : "software-nino".
    It is still possible that some characters only having a decimal HTML/XML entity won't be handled properly at first.
    The method to filter these is simple, please ask for help in our forums.
SeO
Admin
Admin
 
Posts: 6333
Joined: Wed Mar 15, 2006 9:41 pm

Postby janmyszkier » Mon Dec 22, 2008 9:43 am

yeah but funny thing i already added special lines to convert non-latins o latins and inject them. son;t know why that stopped working in 3.0.3 release. guess i'll need to check that out and rewrite my function. but than you for your notes.
janmyszkier
PR0
PR0
 
Posts: 50
Joined: Fri Oct 12, 2007 11:47 pm
Location: Wroclaw, Poland.

Postby SeO » Mon Dec 22, 2008 9:49 am

Well if you did so, you did it in phpbb_seo_class.php and may dropped some of your custom code while updating then.
SeO
Admin
Admin
 
Posts: 6333
Joined: Wed Mar 15, 2006 9:41 pm

Postby janmyszkier » Mon Dec 22, 2008 9:54 pm

indeed, i looked into it just now and found out it was really the problem. thank you for pointing me in the right place!

ah my bad...still nothing,

Code: Select all
$polskiefind = array(
      "\xC4\x85","\xC4\x84", // a,A
        "\xC4\x87","\xC4\x86", // c,C
        "\xC4\x98","\xC4\x99", // e,E
      "\xC5\x82","\xC5\x81", //l, L
      "\xC3\xB3","\xC3\x93", // o, O
      "\xC5\x9B","\xC5\x9A", //s ,S
      "\xC5\xBC","\xC5\xBB", // z,Z
      "\xC5\xBA","\xC5\xB9", //z,Z
      "\xc5\x84","\xc5\x83"  //n,N
      );
      $polskiereplace = array('a', 'A',
     'c', 'C',
     'e', 'E',
     'l', 'L',
     'o', 'O',
     's', 'S',
     'z', 'Z',
     'z', 'Z',
     'n', 'N');
     $url = str_replace($polskiefind, $polskiereplace, $url );


this one is right after:
$url = htmlentities($url, ENT_COMPAT, $this->encoding);
in format_url function, Am I missing something

EDIT:
ok all fixed, i just needed to move my code ABOVE tthis line.
$url = htmlentities($url, ENT_COMPAT, $this->encoding);
janmyszkier
PR0
PR0
 
Posts: 50
Joined: Fri Oct 12, 2007 11:47 pm
Location: Wroclaw, Poland.

Postby dcz » Tue Dec 23, 2008 10:29 am

Since you seems to be using polish, you may find interesting to read this :
http://www.phpbb-seo.com/boards/advance ... html#22647

++
Useful links :
SEO Forum || SEO Directory || SEO phpBB || Search
____________________

Liens Utiles :
Forum référencement || Annuaire référencement || Référencement phpBB || Recherche
dcz
Admin
Admin
 
Posts: 21219
Joined: Fri Apr 28, 2006 9:03 pm


Return to phpBB SEO Premod

 


  • Related topics
    Replies
    Views
    Last post

Who is online

Users browsing this forum: No registered users and 6 guests