Hi All,

2 small questions.
I did the upgrade last night and it went pretty good.
I had 2 small issues.

1) I replaced the htaccess with a new one from acp. After that ucp.php and style.php could not be openend (infinite redirect loop).
I had to disable this line (commented it) for normal operation to return:

# FIX RELATIVE PATHS : FILES
#RewriteRule ^.+/(style\.php|ucp\.php|mcp\.php|faq\.php|download/file.php)$ /phpBB3/$1 [QSA,L,NC,R=301]

Is this line important, and how come i had to disable it ?
I have virtualroot and virtual folder enabled, advanced seo, my installation is in /phpBB3/ dir.
I also adjusted the GYM rules to the correct path and removed the # in front of them, even tough it set could be not enabled on this level ?
Here is my full htaccess:

Code: Select all

ErrorDocument 400 /phpBB3/error.php?mode=400
ErrorDocument 401 /phpBB3/error.php?mode=401
ErrorDocument 403 /phpBB3/error.php?mode=403
ErrorDocument 404 /phpBB3/error.php?mode=404
ErrorDocument 500 /phpBB3/error.php?mode=500

DirectoryIndex index.html index.php

# Lines That should already be in your .htacess
<Files "config.php">
Order Allow,Deny
Deny from All
</Files>
<Files "common.php">
Order Allow,Deny
Deny from All
</Files>

# You may need to un-comment the following lines
# Options +FollowSymlinks
# To make sure that rewritten dir or file (/|.html) will not load dir.php in case it exist
# Options -MultiViews
# REMEBER YOU ONLY NEED TO STARD MOD REWRITE ONCE
RewriteEngine On
# REWRITE BASE
RewriteBase /
# HERE IS A GOOD PLACE TO FORCE CANONICAL DOMAIN
# RewriteCond %{HTTP_HOST} !^www\.camino-tuning\.be$ [NC]
# RewriteRule ^(.*)$ http://www.camino-tuning.be/$1 [QSA,L,R=301]

# DO NOT GO FURTHER IF THE REQUESTED FILE / DIR DOES EXISTS
RewriteCond %{REQUEST_FILENAME} -f
RewriteCond %{REQUEST_FILENAME} -d
RewriteRule . - [L]
#####################################################
# PHPBB SEO REWRITE RULES ALL MODES
#####################################################
# AUTHOR : dcz www.phpbb-seo.com
# STARTED : 01/2006
#################################
# FORUMS PAGES
###############
# FORUM INDEX
RewriteRule ^forum\.html$ /phpBB3/index.php [QSA,L,NC]
# FORUM ALL MODES
RewriteRule ^(forum|[a-z0-9_-]*-f)([0-9]+)/?(page([0-9]+)\.html)?$ /phpBB3/viewforum.php?f=$2&start=$4 [QSA,L,NC]
# TOPIC WITH VIRTUAL FOLDER ALL MODES
RewriteRule ^(forum|[a-z0-9_-]*-f)([0-9]+)/(topic|[a-z0-9_-]*-t)([0-9]+)(-([0-9]+))?\.html$ /phpBB3/viewtopic.php?f=$2&t=$4&start=$6 [QSA,L,NC]
# GLOBAL ANNOUNCES WITH VIRTUAL FOLDER ALL MODES
RewriteRule ^announces/(topic|[a-z0-9_-]*-t)([0-9]+)(-([0-9]+))?\.html$ /phpBB3/viewtopic.php?t=$2&start=$4 [QSA,L,NC]
# TOPIC WITHOUT FORUM ID & DELIM ALL MODES
RewriteRule ^([a-z0-9_-]*)/?(topic|[a-z0-9_-]*-t)([0-9]+)(-([0-9]+))?\.html$ /phpBB3/viewtopic.php?forum_uri=$1&t=$3&start=$5 [QSA,L,NC]
# PHPBB FILES ALL MODES
RewriteRule ^resources/[a-z0-9_-]+/(thumb/)?([0-9]+)$ /phpBB3/download/file.php?id=$2&t=$1 [QSA,L,NC]
# PROFILES ALL MODES WITH ID
RewriteRule ^(member|[a-z0-9_-]*-u)([0-9]+)/$ /phpBB3/memberlist.php?mode=viewprofile&u=$2 [QSA,L,NC]
# USER MESSAGES ALL MODES WITH ID
RewriteRule ^(member|[a-z0-9_-]*-u)([0-9]+)/(topics|posts)/?(page([0-9]+)\.html)?$ /phpBB3/search.php?author_id=$2&sr=$3&start=$5 [QSA,L,NC]
# GROUPS ALL MODES
RewriteRule ^(group|[a-z0-9_-]*-g)([0-9]+)(-([0-9]+))?\.html$ /phpBB3/memberlist.php?mode=group&g=$2&start=$4 [QSA,L,NC]
# POST
RewriteRule ^post([0-9]+)\.html$ /phpBB3/viewtopic.php?p=$1 [QSA,L,NC]
# ACTIVE TOPICS
RewriteRule ^active-topics(-([0-9]+))?\.html$ /phpBB3/search.php?search_id=active_topics&start=$2&sr=topics [QSA,L,NC]
# UNANSWERED TOPICS
RewriteRule ^unanswered(-([0-9]+))?\.html$ /phpBB3/search.php?search_id=unanswered&start=$2&sr=topics [QSA,L,NC]
# NEW POSTS
RewriteRule ^newposts(-([0-9]+))?\.html$ /phpBB3/search.php?search_id=newposts&start=$2&sr=topics [QSA,L,NC]
# THE TEAM
RewriteRule ^the-team\.html$ /phpBB3/memberlist.php?mode=leaders [QSA,L,NC]
# HERE IS A GOOD PLACE TO ADD OTHER PHPBB RELATED REWRITERULES

RewriteRule ^index\.html$ /phpBB3/index.php [QSA,L,R=307]

# HOW-TO
RewriteRule ^howto-manuals/?howto-topic-([0-9]+)?\.html$ /phpBB3/howtos.php?mode=topic&t=$1 [QSA,L,NC]
RewriteRule ^howto-manuals/?howto-vertaal-([0-9]+)?\.html$ /phpBB3/howtos.php?mode=vertaal&t=$1 [QSA,L,NC]
RewriteRule ^howto-manuals/?howto-index.html /phpBB3/howtos.php?mode=list [QSA,L,NC]

#########################################################
# ALBUM REWRITE RULES               #
#########################################################
# AUTHOR : dcz http://www.phpbb-seo.com/
# STARTED : 2009/01/15
########################
# ALBUM INDEX
RewriteRule ^phpBB3/gallery/album.html$ /phpBB3/gallery/index.php [QSA,L,NC]
# ALBUM PERSONAL INDEX
RewriteRule ^phpBB3/gallery/user-albums/?(page([0-9]+)\.html)?$ /phpBB3/gallery/index.php?mode=personal&start=$2 [QSA,L,NC]
# ALBUM
RewriteRule ^phpBB3/gallery/[a-z0-9_-]*-a([0-9]+)/?(page([0-9]+)\.html)?$ /phpBB3/gallery/album.php?album_id=$1&start=$3 [QSA,L,NC]
# PIC PAGE
RewriteRule ^phpBB3/gallery/[a-z0-9_-]*(-a([0-9]+)/)?[a-z0-9_-]*-p([0-9]+)(-([0-9]+))?\.html$ /phpBB3/gallery/image_page.php?album_id=$2&image_id=$3&start=$5 [QSA,L,NC]
# JPG
RewriteRule ^phpBB3/gallery/[a-z0-9_-]*(-a([0-9]+)/)?[a-z0-9_-]*-i([0-9]+)\.jpg$ /phpBB3/gallery/image.php?album_id=$2&image_id=$3 [QSA,L,NC]
# JPG THUMBNAILS
RewriteRule ^phpBB3/gallery/[a-z0-9_-]*(-a([0-9]+)/)?[a-z0-9_-]*-t([0-9]+)\.jpg$ /phpBB3/gallery/image.php?mode=thumbnail&album_id=$2&image_id=$3 [QSA,L,NC]
# JPG MEDIUM
RewriteRule ^phpBB3/gallery/[a-z0-9_-]*(-a([0-9]+)/)?[a-z0-9_-]*-m([0-9]+)\.jpg$ /phpBB3/gallery/image.php?mode=medium&album_id=$2&image_id=$3 [QSA,L,NC]
#########################################################

#####################################################
# GYM Sitemaps & RSS
# Global channels
# NOTE : THE FOLLOWING REWRITERULE IS LEFT COMMENTED BECAUSE IT CANNOT
# BE IMPLEMENTED IN THIS .HTACCESS, BUT RATHER IN AN ABOVE ONE
# WITH PROPER SLASHES AND PATHS
# RewriteRule ^rss(/(news)+)?(/(digest)+)?(/(short|long)+)?/?$ /gymrss.php?channels&$2&$4&$6 [QSA,L,NC]
# HTML Global news & maps
RewriteRule ^phpBB3/(news|maps)/?(page([0-9]+)\.html)?$ /phpBB3/map.php?$1&start=$3 [QSA,L,NC]
# END GYM Sitemaps & RSS
#####################################################

#####################################################
# GYM Sitemaps & RSS
# HTML Module additional modes
RewriteRule ^phpBB3/(news|maps)/([a-z0-9_-]+)(/([a-z0-9_-]+))?/?(page([0-9]+)\.html)?$ /phpBB3/map.php?$2=$4&$1&start=$6 [QSA,L,NC]
# Main feeds & channels
# NOTE : THE FOLLOWING REWRITERULE IS LEFT COMMENTED BECAUSE IT CANNOT
# BE IMPLEMENTED IN THIS .HTACCESS, BUT RATHER IN AN ABOVE ONE
# WITH PROPER SLASHES AND PATHS
RewriteRule ^rss(/(news)+)?(/(digest)+)?(/(short|long)+)?(/([a-z0-9_-]+))?/([a-z0-9_]+)\.xml(\.gz)?$ /phpBB3/gymrss.php?$9=$8&$2&$4&$6&gzip=$10 [QSA,L,NC]
# Module feeds
# NOTE : THE FOLLOWING REWRITERULE IS LEFT COMMENTED BECAUSE IT CANNOT
# BE IMPLEMENTED IN THIS .HTACCESS, BUT RATHER IN AN ABOVE ONE
# WITH PROPER SLASHES AND PATHS
RewriteRule ^[a-z0-9_-]*-[a-z]{1,2}([0-9]+)(/(news)+)?(/(digest)+)?(/(short|long)+)?/([a-z0-9_]+)\.xml(\.gz)?$ /phpBB3/gymrss.php?$8=$1&$3&$5&$7&gzip=$9 [QSA,L,NC]
# Module feeds without ids
# NOTE : THE FOLLOWING REWRITERULE IS LEFT COMMENTED BECAUSE IT CANNOT
# BE IMPLEMENTED IN THIS .HTACCESS, BUT RATHER IN AN ABOVE ONE
# WITH PROPER SLASHES AND PATHS
RewriteRule ^([a-z0-9_-]+)(/(news)+)?(/(digest)+)?(/(short|long)+)?/([a-z0-9_]+)\.xml(\.gz)?$ /phpBB3/gymrss.php?nametoid=$1&$3&$5&$7&modulename=$8&gzip=$9 [QSA,L,NC]
# Google SitemapIndex
# NOTE : THE FOLLOWING REWRITERULE IS LEFT COMMENTED BECAUSE IT CANNOT
# BE IMPLEMENTED IN THIS .HTACCESS, BUT RATHER IN AN ABOVE ONE
# WITH PROPER SLASHES AND PATHS
RewriteRule ^sitemapindex\.xml(\.gz)?$ /phpBB3/sitemap.php?gzip=$1 [QSA,L,NC]
# Module cat sitemaps
# NOTE : THE FOLLOWING REWRITERULE IS LEFT COMMENTED BECAUSE IT CANNOT
# BE IMPLEMENTED IN THIS .HTACCESS, BUT RATHER IN AN ABOVE ONE
# WITH PROPER SLASHES AND PATHS
RewriteRule ^[a-z0-9_-]+-([a-z]{1,2})([0-9]+)\.xml(\.gz)?$ /phpBB3/sitemap.php?module_sep=$1&module_sub=$2&gzip=$3 [QSA,L,NC]
# Module sitemaps
# NOTE : THE FOLLOWING REWRITERULE IS LEFT COMMENTED BECAUSE IT CANNOT
# BE IMPLEMENTED IN THIS .HTACCESS, BUT RATHER IN AN ABOVE ONE
# WITH PROPER SLASHES AND PATHS
RewriteRule ^([a-z0-9_]+)-([a-z0-9_-]+)\.xml(\.gz)?$ /phpBB3/sitemap.php?$1=$2&gzip=$3 [QSA,L,NC]
# END GYM Sitemaps & RSS
#####################################################

# FORUM WITHOUT ID & DELIM ALL MODES (SAME DELIM)
# THESE THREE LINES MUST BE LOCATED AT THE END OF YOUR HTACCESS TO WORK PROPERLY
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule ^([a-z0-9_-]+)/?(page([0-9]+)\.html)?$ /phpBB3/viewforum.php?forum_uri=$1&start=$3 [QSA,L,NC]
# FIX RELATIVE PATHS : FILES
#RewriteRule ^.+/(style\.php|ucp\.php|mcp\.php|faq\.php|download/file.php)$ /phpBB3/$1 [QSA,L,NC,R=301]
# FIX RELATIVE PATHS : IMAGES
RewriteRule ^.+/(styles/.*|images/.*)/$ /phpBB3/$1 [QSA,L,NC,R=301]
# END PHPBB PAGES
#####################################################


2) When going to posting.php i would get an PHP Notice undefined index "conical" for this line in includes/functions.php:

//'SEO_CANONICAL_URL' => $phpbb_seo->seo_path['canonical'],

I commented the line, but perhaps there is a better solution ?

Thanks for your responses

1) The rewriterule is an attempt to circumvent poor clients (mostly bots) unable to deal properly with a base href tag, though, it seems to cause trouble with virtual root.
If you do not experience further issues related to that rewriterule, it's no big deal to stay without.

For GYM, you could move the files to domain's root following the explanations in install file on how to do it, but if everything works like this, it's no big deal either.

2) The phpbb_seo::seo_path['canonical'] is initialized in phpbb_seo/phpbb_seo_class.php and should always be set, so make sure you've properly updated this file.

++

Thanks for the answers.
I did a compare of the phpbb_seo_class file and altough the version and timestamp were good, there was 1 part missing. The canonical part.
Seems the auto updater missed that for me. Thanks for the advice, i'll uncomment it now in functions.php

The GYM redirects all seem to work fine when adding the /phpBB3/ to the location of the php files in the rule.
I forgot to remove the #sign and adjust path at the news rule and now that works too, i tested news map and sitemap aswell.

So, conclusion: Excellent work and thanks for clearing these 2 small issues for me.

I've been investigating a bit, try :

Code: Select all

RewriteRule ^.+/phpBB3/(style\.php|ucp\.php|mcp\.php|faq\.php|download/file.php)$ /phpBB3/$1 [QSA,L,NC,R=301]

instead of :

Code: Select all

RewriteRule ^.+/(style\.php|ucp\.php|mcp\.php|faq\.php|download/file.php)$ /phpBB3/$1 [QSA,L,NC,R=301]

Seems that this is required for the virtual root case. And even if not very important, it should lower the 404 caused by dumb web clients

Your new rule works fine. Thanks !