PHPBB Mixed Mod Rewrite Forum Title Able2know Addon

[sceltic]

PHPBB Mixed Mod Rewrite Forum Title Able2know Addon


Hi Now what I would be interested in is the mixed mod rewrite for phpbb, add ons to compliment the existing able2know hack (which looks like it is not going to be no longer developed)

I also have the simple sub forums and currently no conflicts.

[dcz]

So for the sub forum mod, if it is the simple sub forum mod originaly developped by cyber alien, then try this :

Code: Select all

#
#-----[ OPEN ]------------------------------------------
#


index.php

#
#-----[ FIND ]------------------------------------------
#

      // Append new entry
      $data[] = array(
#
#-----[ BEFORE, ADD ]------------------------------------------
#

         // phpBB-SEO.com SEO TOOLKIT BEGIN
         $seo_forum_name = $forum_data['forum_name'];
         // phpBB-SEO.com SEO TOOLKIT END




#
#-----[ OPEN ]------------------------------------------
#
#

viewforum.php

#
#-----[ FIND ]------------------------------------------
#

      if( $all_forums[$i]['forum_id'] == $parent_id )
      {

#
#-----[ AFTER, ADD ]------------------------------------------
#

         // phpBB-SEO.com SEO TOOLKIT BEGIN
         $seo_forum_name = $all_forums[$i]['forum_name'];
         // phpBB-SEO.com SEO TOOLKIT END


#
#-----[ SAVE/CLOSE ALL FILES ]------------------------------------------
#
# EoM

++

[sceltic]

I am still working through tests locally.


A few problems and wonders


I had loaded up the the simple sub forums mod as made by phpbb styles

the structure as you look at it on viewforum is not like your beta test at pixelistes

the sub forums layout I have is as phpbbstyles

When you Click the primary forum on index, The sub forums are present in a seperate container to the primary posts which are underneath (or this can be over if you change it in the template but still seperate) in a seperate layout contained

And the problem seems to be using the simple sub forums of phpbb styles, is- the titles of the sub forums are not working well with this mod as now.

example of problem

on the index page the sub forum might be called sub forum a of primary. all good the url forum title works on index

but if you click the primary
the sub forum becomes primary2

Double url same content??



I await your thoughts

[dcz]

So, The code changes I proposed her are for the phpbbstyle sub forum, last version.

I know pixeliste is using the pesudo sub forum instead and it works nicelly.

Should not be that much of a big deal to have it work for you.

The phpBBstyles sub forum is the one being used here.

Then, with this mod there are some issues if forums are empty.

Please try to give me more precises example, I think you mean the sub forum listing does not work in the viewforum ?

Please check if your forums aren't empty and tell me more.

++

[sceltic]

Good Morning

empty forums aha there are no posts so let me look at that and report back.

[dcz]

Yes, I did not want to implement a check for this since, forum should not be empty, and such check would be perfomrmed upon every forum url, which is useless most of the time (again used forum should not be empty).

But empty forum with no empty sub forum inside of it is ok.

++

[sceltic]

Still the problem


I think it may be because on index the forums are showing as

title-vf1.html

yours here are showing

title/

[SeO]

Do you confirm it's ok for the viewforum view ?

Then for the index, please try this instead of the pervious :


Find :

Code: Select all

for( $i = 0; $i < count($subforums_list); $i++ )
{
   $forum_data = $subforums_list[$i]['forum_data'];
   $parent_id = $forum_data['forum_parent'];

After Add :

Code: Select all

         // phpBB-SEO.com SEO TOOLKIT BEGIN
         $seo_forum_name = $forum_data['forum_name'];
         // phpBB-SEO.com SEO TOOLKIT END

And don't worry, it's going to work, we just need to figure out where is the proper place to catch the proper forum title.

++

[sceltic]

The problem is on Viewforum

But maybe index as well


Your forums here are showing on the index as

title/


but the rules above are making my forums on index title-vf1.html

[dcz]

Please on thing at a time,

yes this site does not use this mod, it is true, you did not noticed ?

This site's code has been massively rewrited, a lot more than just the forum url will be different from any other.

This is experimental, and is not really releasable, way to many code changes.

The phpBB SEO mod tend to be an easy to use and install working solution for all, it's doing just slightly differents things.

If you want to really compare things, http://phpbb2.phpbb-seo.net/ is actually using the same exact code as you will in a very short while, as soon as we'll have discover what is wrong with the subforum mod.


It's a pity you cannot post links for me to actually see what's happening cause I am still not sure I understood well what is wrong (you did not make it more clear sorry).

So can you tel me precisely on which page what is and is not working as links : 1) does the links appears rewrited in the code's page + example and 2) are they usable.

Don't worry we'll find this patch.

++

[sceltic]

OK I will try

On index all is good!


it is on viewforum where the title of the sub forum changes to the parent

[dcz]

OK I will try

On index all is good!


it is on viewforum where the title of the sub forum changes to the parent

Yes, I see, but, are those forum empty (the one having the same titles as the first on ?

Cause if so, it's normal, you have to post at least one in each sub forum for the sub forum to properly work.

[sceltic]

No it is not empty it has a post in it, it is the only subforum and is still showing on viewforum as the title of the parent which also has a post in??

[dcz]

Lol, I think I got it now

http://boards.phpbb-seo.com/phpbb-mod-r ... -vt41.html

And in the end it should be just fine

I had just missed half the sub forum mod while writing down this patch

[sceltic]

Yes it certainly does. thank you

I am now going to find more questions