Hi dear dcz,
great work but i had a problem with url rewriting in my sitemap.
I use Advanced Mod Rewrite so i configured my Google Sitemaps settings for this, but it doesn't work.
As you can see here:

http://forum.fuoriditesta.it/sitemaps.xml

and here

http://forum.fuoriditesta.it/off-topic-gf19.xml

Categories names seems to be okay, but topics url is not dinamic.

Another trouble i have is that this mod seems doesn't work good with subcategories (i use Simple Subforum Mod). For example i don't see in my sitemaps index this category http://forum.fuoriditesta.it/immagini-d ... -vf55.html and other ones.

Well it's working pretty well, have you tried turning XSLT styling on ?

The topic url issue is strange though.

Have you upgraded to the advanced mod rewrite 0.2.0 as well ?


For the forum listed, only public ones are, and it's not the case for the one you showed as example.

++

Hi, i updated Advanced Mod Rewrite to 0.2.0 and it works good on http://forum.fuoriditesta.it

It's strange it doesn't work in my Google Sitemap because rss seems to work good http://forum.fuoriditesta.it/rss.php instead of http://forum.fuoriditesta.it/il-confessionale-gf57.xml that can't rewrite urls of topics.

I also tryed to turn on XSL styles on but is the same for Google SM. Only categories are correctly rewrited, not topic titles.

I think my configuration is correct but mod seems that can't use correctly Advanced Mod Rewrite for Google Sitemap:

Really strange.

Because it looks like $topic['topic_title'] is empty just for the forum sitemaps, and it's not the case for rss feeds.

As well, I never saw this issue before.

So we'll have to experiment a bit on this one to find out where is the problem.

Please try to open mx_ggsitemaps/includes/google_forum.php and find :

Code: Select all

               $topic_url = $this->path_config['phpbb_url'] . (($this->mod_r_config['topic_pre'] !='') ? $this->mod_r_config['topic_pre'] . $topic['topic_id'] : $phpbb_seo->format_url($topic['topic_title'], $phpbb_seo->seo_static['topic']) . $phpbb_seo->seo_delim['topic'] .  $topic['topic_id']);

Replace it with :

Code: Select all

               $topic_url = $this->path_config['phpbb_url'] .  $phpbb_seo->format_url($topic['topic_title'], $phpbb_seo->seo_static['topic']) . $phpbb_seo->seo_delim['topic'] .  $topic['topic_id'];

Just to make sure it's not coming from above.

Then, we'll try other things, and we'll find out about this one

Replaced this code, but it seems to be the same...

php and Apache version ?

I am sorry, the exact same code does work on my test servers.

So we need to try several things.

Until the sitemaps works fully, unsubscribe it at Google, you'll resubmit when we'll have fixed this.

So could you try replacing, still in the same file :

Code: Select all

               $topic_url = $this->path_config['phpbb_url'] . (($this->mod_r_config['topic_pre'] !='') ? $this->mod_r_config['topic_pre'] . $topic['topic_id'] : $phpbb_seo->format_url($topic['topic_title'], $phpbb_seo->seo_static['topic']) . $phpbb_seo->seo_delim['topic'] .  $topic['topic_id']);

with :

Code: Select all

               $topic_url = $this->path_config['phpbb_url'] .  $phpbb_seo->format_url($topic['topic_title']) . $phpbb_seo->seo_delim['topic'] .  $topic['topic_id'];

this time.

I'm still trying to find the possible causes for this.

Could you tell me if you see any change when you select mixed mod rewrite in GYM acp's (it should not as the phpBB SEO mod rewrite should override the GYM settings).

As well, could it be possible for you to install a fresh phpBB on you server, so we can test several things without perturbing your website ?

It's not luck for you I know, as this bug is quite odd.

The module is worth some debug

++

Hi, i tryied to replace this code but it is still the same.

I have Apache 1.3.37, PHP 4.4.2 and MySQL 4.1.11-

Nothing happens if i select Mixed or Simple mode in GYM acp's

I made what you said and i installed the same mods (Advanced Rewrite Mod, Zero Dupe and GYM sitemaps mod) in a fresh phpbb located in my same server. Website is http://www.parlare.org and as you can see it works all good http://www.parlare.org/sitemaps.xml

Maybe some other mod make troubles?

Is this part of phpbb_seo_class.php okay?

Code: Select all

// --> DOMAIN SETTING <-- //
// NOTE : If you add already declared a PHPBB_URL constant in common.php,
// you should get rid of it and let this part do it instead.
// You can hard-code the data to save process.
$server_protocol = ($board_config['cookie_secure']) ? 'https://' : 'http://';
$server_name = preg_replace('#^\/?(.*?)\/?$#', '\1', trim($board_config['server_name']));
$server_port = ($board_config['server_port'] <> 80) ? ':' . trim($board_config['server_port']) : '';
$script_name = preg_replace('#^\/?(.*?)\/?$#', '\1', trim($board_config['script_path']));
$script_name = ($script_name == '') ? '' : $script_name . '/';
// Domain URL
define ('ROOT_URL', $server_protocol . $server_name . $server_port . '/');
// PHPBB_SCRIPT should be = '' if phpbb is installed in the domain's root
// 'phpbb/' in case it's installed in the phpbb/ folder.
define ('', $script_name);
define ('PHPBB_URL', ROOT_URL . PHPBB_SCRIPT);

I deleted define ('PHPBB_URL'... etc. in my common.php file (i used old version of Zero Dupe mod, but i updated it to latest version) and i leaved only this one. I make a lot of tryies but it is always the same...

Jeeez I have found it, a real bug

It deals with phpBB censoring, the module was actually returning an empty var in case censoring is activated, wrong editing sorry.
The kind of things that's making this RC1

SO the fix is easy, open google_forum.php and find :

Code: Select all

               $topic['topic_title'] = (count($orig_word)) ? preg_replace($orig_word, $replacement_word, $post_subject) : $topic['topic_title'];

Replace with :

Code: Select all

               $topic['topic_title'] = (count($orig_word)) ? preg_replace($orig_word, $replacement_word, $topic['topic_title']) : $topic['topic_title'];

GRR

You're great!
Now it is okay...

hehe, thanks

So how much do you like GYM sitemaps now ?

Now i'ts great
Only one thing, is normal that

<lastmod>2007-01-27T11:48:36+00:00</lastmod>

is one hour ahead than board time?

Well, I just not spend to much time on Time shifts.

The module is actually building up lastmods with the real lastmods time catched on the boards (last post time in forum or thread), but there is no switching GMT +/- and some lastmods are as well calculated using time() eg server settings that can as well be different from the forum one.

So all this is not really important SEO wise, I mean to end up being GMT +0 instead of GMT+1, what really matters, is that the time base is the same for all items, allowing Google to find what's newer what's updated etc very accurately.

Same as before on this. What really matters is relativity, not to use GMT or GMT +1 time in these.

++

Okay

Another question, is my RSS feed working good?
http://forum.fuoriditesta.it/rss.xml

Is normal i can't see Messages text also if i activate it in GYM acp?

The proper url for rss.xml with images is http://forum.fuoriditesta.it/rss-m.xml (or -http://forum.fuoriditesta.it/rss.php?m )

But it must be allowed in the module's acp to work.
It looks like it's not the case now.

Here it's like http://www.phpbb-seo.com/rss-m.xml

Have you tried to activate XSLt styling ?

++

dcz wrote:The proper url for rss.xml with images is http://forum.fuoriditesta.it/rss-m.xml (or -http://forum.fuoriditesta.it/rss.php?m )

But it must be allowed in the module's acp to work.
It looks like it's not the case now.

Here it's like http://www.phpbb-seo.com/rss-m.xml

Have you tried to activate XSLt styling ?

++

Yes, i activated it and now it is okay. I also tried to activate XSL styling and it works pretty good