I decided to update my version of MX_Sitemaps after updating to the newer mixed mod re-write and the newer zero-dupe mod.

I'm getting the following error...

All URLS associcated with the new mxsitemaps mod are having "PHPBB_URL" inserted in front of them. This is breaking the mx_sitemaps page.

Even the images on the sitemaps page are broken, due to PHPBB_URL being inserted... examples:

/PHPBB_URLsitemaps.html
/PHPBB_URLtemplates/AdInfinitum/images/nav_explorer.gif

I assume this has something to do with the new zero dupe mod??

Not sure where I went wrong.


-Steve

I thought this would be compatible directly with the new Zero Dupe mod version, but it's not.

After reading that PHPBB_URL is supposed to be substituted in code elsewhere, I went and substituted it in the sitemaps.php code for the 3 instances of PHPBB_URL and it works now.

0.2.0 => 0.2.x update :

The update as well gets rid of the PHPBB_URL constant, which can cause some trouble if you are using it elswhere.
You shoudl now use :
Quote:
$phpbb_seo->seo_path['phpbb_script'] instead of PHPBB_SCRIPT
$phpbb_seo->seo_path['root_url'] instead of ROOT_URL
$phpbb_seo->seo_path['phpbb_url'] instead of PHPBB_URL

Meant to work with the phpBB SEO advanced mod rewrite 0.2.2 and above

I guess the MX Sitemaps package needs to be updated.

I'm surprised I couldn't find this mentioned yet when searching this forum.


-Steve

Scratch that... it's BETTER, but not totally fixed.

The links for Sitemap Index and Forum Index are still messed up
at the top and bottom of the Sitemap Index

I can't find where the code change needs to be made for these links.

Scratch that again... I looked at sitemaps.php once more and I missed substitution on one of the PHPBB_URL terms.

bah.

All set now.


-Steve

Sorry if you felt alone on this one, I just found out about this thread right now

Anyway, yes, this one will soon be updated, time time time ...

++

No problem... I figured it out. It was easy enough.

At least the thread is here for those that look for the same info in the near future.


Now the issues I'm having with the new RSS feeds.. that's another story.

hopster wrote:Scratch that... it's BETTER, but not totally fixed.

The links for Sitemap Index and Forum Index are still messed up
at the top and bottom of the Sitemap Index

I can't find where the code change needs to be made for these links.

Hi
thanX hopster , for your helpful topic I've same problem and fix it by your trick but about this part of your problem (as me) I can't fix it up by your way.
i modified the codes thus:

Code: Select all

$phpbb_seo->seo_path['phpbb_url'] = "/forum/";
$phpbb_seo->seo_path['root_url'] = "/forum/";

INSTED OF :

Code: Select all

$phpbb_url = PHPBB_URL;
$root_url = PHPBB_URL;

which forum is my boards folder.
it's working perfect.

Actually, the bug is coming from the phpbb_seo_class.php file in phpbb_seo/. It deals with paths handling, when append_sid() is called with a folder in the url, for example :

Code: Select all

append_sid("forum/viewtopic.$phpEx?t=$topic_id");

vs :

Code: Select all

append_sid("viewtopic.$phpEx?t=$topic_id");

The next version will solve the issue, and will be soon released, allowing us to use append_sid() from outside the phpBB folder, where you need to add paths this way.

Until then you can open phpbb_seo/phpbb_seo_class.php and replace :

Code: Select all

      $this->path = (!empty($this->path)) ? $this->path . '/' : '';

With :

Code: Select all

       $this->path = (!empty($this->path)) ? ( ( $this->path . '/' == $this->seo_path['phpbb_script']) ? $this->seo_path['phpbb_url'] : $this->path . '/' ) : '';

thanks for your advise.
but any problem with my statict path routes ? it's working perfect with my new config.

Had you seen the mx sitemaps module went updated to 0.2.2 ?