Hmm, it is strange because I just installed it here, and I am using the same exact code as the first patch to retrieve the correct forum name.

Actually, I am wondering if you should not just go back to this code.

If not enough, please send me the viewforum.php file again

++

thanks

its my viewforum.php

-http://rapidshare.de/files/29335859/viewforum.zip.html

if you want i can send my full package will all seo mods

hmm, now this is strange, isn't it working with $forum_row['forum_name'] ?
This because it seemed the forum name was displayed ok, but not the URL.

Then, we'd probably have to take care of the empty case with the utf-8 set up.
As said, I'll dev something to make is simpler here, but you should just proceed as always for now:

Code: Select all

$forum_url_ok = format_url($forum_row['forum_name']);
$forum_url_ok = ($forum_url_ok != 'empty') ? $forum_url_ok : 'froum';

And then use $forum_url_ok instead of format_url($forum_row['forum_name']) in the original code.

That is :

Code: Select all

   $forum_url_ok = format_url($forum_row['forum_name']);
   $forum_url_ok = ($forum_url_ok != 'empty') ? $forum_url_ok : 'froum';
   $mx_link_tmp = append_sid($root_url . $forum_url_ok . '-fmp' .$mx_forum_id . '.html');

If not enough, I guess I'll need to test your site running to figure it out, but I don't see no reason why $forum_row['forum_name'] would no be the correct forum name as I do use the same code with simple sub-forum.

++

excuse me i coudn't understand

in which file i must add this lines ?

Well, page_tail.php.

Actually, all I am suggesting here is to use the first suggested code, I just added the empty utf-8 case.

So it's this one then, the patch, and then my last one.

++

ok

i added that three line to my page_tail.php
see this part of code

Code: Select all

//Begin mx_Sitemaps Auto link Add On http://www.phpbb-seo.com/
$mx_forum_id =( isset($HTTP_GET_VARS[POST_FORUM_URL]) )? intval($HTTP_GET_VARS[POST_FORUM_URL]) : 0;
$root_url = './';
if ( $mx_forum_id != 0 )
{
    // ADDED for advance rewrite mod UTF-8 version
   $forum_url_ok = format_url($forum_row['forum_name']);
   $forum_url_ok = ($forum_url_ok != 'empty') ? $forum_url_ok : 'froum';
   $mx_link_tmp = append_sid($root_url . $forum_url_ok . '-fmp' .$mx_forum_id . '.html');
   // END
   $link_title = $forum_row['forum_name'].' - Map';
   $mx_sitemap_link = '<a href="'.$mx_link_tmp.'" class="copyright" title="'.$link_title.'">'.$link_title.'</a>';
   $mx_sitemap_link .= '<br /><a href="'.append_sid($root_url . 'forum-map.html').'" class="copyright" title="Forum Map">Forum Map</a>';
   $mx_sitemap_link .= '&nbsp;- <a href="'.append_sid($root_url . 'sitemaps.html').'" class="copyright" title="'.$board_config['sitename'].' : Site Map">Site Map</a>';
}
else
{
   $mx_sitemap_link = '<a href="'.append_sid($root_url . 'forum-map.html').'" class="copyright" title="Forum Map">Forum Map</a>';
   $mx_sitemap_link .= '&nbsp;- <a href="'.append_sid($root_url . 'sitemaps.html').'" class="copyright" title="'.$board_config['sitename'].' : Site Map">Site Map</a>';
}
//End mx_Sitemaps Auto link Add On http://www.phpbb-seo.com/

now it works without problem
is it correct ?

Yes, and it means there is nothing to change using simple sub forum.

By the way have you checked the update on the simple sub forum add on ?

Could have been it too, depending on additional modding on your set up.

++

Are the auto-links supposed to link to generic .xml sitemaps for SE's or to a user-friendly graphic sitemaps for visitors.

I installed your MOD, and mine link to the former, but on your site I see they link to the latter -- did I miss something?

Well yes, if you apply the code changes suggested you'll see links to html sitemaps build by the mx sitemaps module (by the way as well SEO orientated).

++

I'm using mx_google_sitemaps (not mx_sitemaps); is that what you're referring to? If so, can you give me a link to the code that creates the graphic sitemap -- I must have missed that.

Thanks.

This mod, the one released on this thread is intended for mx sitemaps, not for mx Google sitemaps.

++

Are you saying I shouldn't use the auto-links add-on with mx_google_sitemap MOD?

Also, I thought I read somewhere that you recommend mx_google_sitemap over mx_sitemap -- is that right? I hope I didn't install the wrong MOD?!!

Both are useful actually.

And, you should not add too many links to your Google sitemaps, because there is no caching in this version, it's only meant for Google to crawl.

The next version will come with an even better auto linking module, be patient things are moving

++

dcz wrote:Both are useful actually.

I assume you mean that mx_google_sitemap is good for SE's and mx_sitemap is good for users -- is that right. And I can install both MODs without conflict?

And what about using auto-links add-on with google_sitemap? Won't that help SE's that visit my site, even if I haven't submitted the sitemap to them?

They both are useful for SEO. mx Google sitemaps will help out a lot to be fully indexed, and mx sitemaps, since it's html, will help out for PageRank Transmission, it's one more backlink per page for the forum.

Then, the current version of mx Google sitemaps does not have any type of cache implemented, so you don't want 2000 visits a day on a 2000 topic list.

The next one will

++