You're welcome

vitok wrote:

dcz wrote:these two are most likely already knew at this stage in the regular code

It seems to me they are not.

Just keep the way it is now then, and you could then replace :

Code: Select all

   if ($_GET['topicdays'] == 0  || $_POST['topicdays'] == 0 ) {
      $topicday_redir = TRUE;
   }

with :

Code: Select all

   if (_read('topicdays', TYPE_INT) == 0 ) {
      $topicday_redir = TRUE;
   }

vitok wrote:I've finally uploaded everything on www.osvic.ru
I'm not just looking happy, I am happy!!

All right

You did a pretty good job

could you post or PM the final code for the zero dupe ? just for the ppage var, the one for the particular forum browsed, as I did not know which var to use for it

++

dcz wrote:could you post or PM the final code for the zero dupe ? just for the ppage var, the one for the particular forum browsed, as I did not know which var to use for it

In fact I do not use different topics ppages for my forums, nor I allow users to change this parameter. So for me $board_config['topics_per_page'] is optimal, I guess. Still in class_topics.php we have

Code: Select all

'ppage' => array($forums->data[$this->forum_id]['forum_topics_ppage'], isset($user->data['user_topics_ppage']) ? $user->data['user_topics_ppage'] : $config->data['topics_per_page'], $config->data['topics_per_page'], 50),

so probably it's better to define topics per page this way. The problem is now it's necessary to put

Code: Select all

// read forums
$forums = new forums();
$forums->read();
//

before the seo block. And I'm not sure it's the right idea when we'll probably be redirected. What do you think?

Well, it depends.

On phpBB (without ch) we eventually do the redirection just after we know the forum title in viewforum.php, otherwise we could not check injected titles.

So according to how CH is built up, you could either move the query doing this before the redir (or the redir after) as long as you can manage to do it after only the viewed forum info are known (not all the output) without adding queries.

It's for sure a bit less interesting with the simple mod rewrite but is required for others and for the ppage param.

++