mm, I hadn't looked at the source in a while and ... well, I'm wondering where phpBB is going now. A bounch of meat balls in Tagliatelle (spaghetti are too slim in that case).
I wonder if anyone benchmarked the ship, but adding events and keeping hooks in append_sid looks like a lot of meat to me. The source is more or less twice the size as before, and this comes after phpBB3 already increased it by a lot (but with tons of new features), I whish good luck to anyone not running an opcode cache, I mean :
phpBB3.1 index.php wrote:Time : 0.234s | 11 Queries | GZIP : Off | Peak Memory Usage: 7.14 MiB
phpBB3.0 index.php wrote:Time : 0.062s | 10 Queries | GZIP : Off | Memory Usage: 2.12 MiB
This is fresh install compare (no phpBB SEO code) on my local xampp without apc, and the box is an 2600kI7 ...
I'm quite disappointed to see that they didn't really choose between becoming an actual framework and actually using one that exists. It's right in between, and worst, it's also in between the old, some said heavy but understandable logic and something new we can't really tell what it is, but really different, this is for sure.
I have to admit I am not such a big fan of symfony, but I was keeping the hope that phpBB would be the occasion for me to finally dive deep enough into it to go beyond that feeling. Well, sorry, but what I read is even worst that symfony. So much more code to achieve ... pretty much the same forum with most of 3.0 code still there.
I'm sure they have good reasons, like "we needed to stay close to the current source", with also modders in mind I guess, "we wanted so bad to use symfony", "rewriting everything is for v4", but I can't understand why this, they would better have worked on something entirely new IMHO.
I even feel sad because if this is close to what we should expect for 3.1, then everything that have always been said about phpBB being heavy with poor design will become very hard to contradict.
The whole things looks like someone is hacking phpBB3.0 to add php 5.3 and symfony in it. I talked about meat balls, here, have one from index.php :
- Code: Select all
$page_title = $user->lang['INDEX'];
* You can use this event to modify the page title and load data for the index
* @event core.index_modify_page_title
* @var string page_title Title of the index page
* @since 3.1-A1
$vars = array('page_title');
I mean, come on, is this the final summit of useless complexity ? I'm sure we can do better.
First one to untangle the full Tagliatella behind this wins a cookie. Hint : this allow developers (not you obviously, at least right now) to change the index page title, Mein Gut !
I'm sure you also appreciate the "register global logic" touch added by extract and compact, it was a while since I last so those, refreshing.
If this results in allowing you to set a custom page tile for index page from somewhere in the acp, it's handy, but could be replaced with a call to a config key, if not, well, do we really need classes to set this ? Cause I'm not so sure it's handy for users, since editing the 'INDEX' key in language array already was too much for many.
Anyway, this whole thing confuses me. It does not seems that the url handling changed that much (except we would be bypassing both event and hooks in append_sid), so I guess a phpBB SEO version is feasible. Let's see how this goes when we start seeing betas and more user reactions.