Hi, after adding the code to album_showpage.php it's no more possible to add comments to a picture, actually I'm using the mod without these lines of code and obviously it doesn't work without it...
in that file:

Code: Select all

// www.phpBB-SEO.com SEO TOOLKIT BEGIN
if ( $show_template == 'album_showpage_body.tpl') {
   $uri = $phpbb_seo->seo_req_uri();
   $phpbb_seo->seo_cond(!$userdata['session_logged_in'] && (strpos($uri, "sid=" ) !== FALSE ));
   $start = (isset($_GET['start'])) ? intval($_GET['start']) : ( (isset($_POST['start'])) ? intval($_POST['start']) : 0 );
   $phpbb_seo->seo_start( $start, $board_config['posts_per_page'] );
   $phpbb_seo->page_url = $phpbb_seo->seo_url['smrtpic'][$pic_id] . $phpbb_seo->seo_delim['smrtpic'] . $pic_id . $phpbb_seo->start . ( (!empty($full_size_param)) ? '-full' : '') . $phpbb_seo->seo_ext['smrtpic'];
   if ( $phpbb_seo->do_redir || ( strpos($uri, $phpbb_seo->page_url) === FALSE ) ) {
      $phpbb_seo->seo_redirect( $phpbb_seo->seo_path['smrt_url'] . $phpbb_seo->page_url );
   }
}
// Mozilla navigation bar
$nav_links['up'] = array(
   'url' => append_sid($phpbb_seo->seo_path['smrt_url'] . $phpbb_seo->seo_static['smrtindex']),
   'title' => $lang['Album'],
);
// www.phpBB-SEO.com SEO TOOLKIT END

it's only this part of the zero duplicate to cause problem with comments. It will be fixed, but, phpBB3 is for now taking all of our efforts.

You can skip this code, and it will work without the zero dupe on comment, which, since we are at it, I do not recommend to use (server load mostly).
I find it better to use the forum for the comments, since you are sure you'll be able to convert these to phpBB3.

I hope you understand, we'll fix this.

Well SEO, as I already written elsewhere, it's not a problem for me if it's working or not, but I don't understand why you keep the file on download without write clearly, at least in the install file, that it won't work. I passed half the saturday recoding all the files till finding that the problem was not a typo error made by me but that the mod is not working...

So I simply asked to remove this file till the problem is fixed, or write somewhere that it won't work...

It's impossible to write comments in the forum for a picture in the album, or I would have used the attachments instead ...

For Phpbb3 I'm not converting anything for 2 or 3 years, till all the mods that I've installed in the site (mainly the album) will be converted and when the first already modded phpBBs will show off... So actually , as a final user, I'm not interested...

I understand your concern and I'm sorry if you waisted some time, actually all this is all a matter of free time.
I know a warning would be a good thing, but, every time I start thinking about it, I'm frustrated we did not have time to fix this, and I start looking at it, but, I need a working FAP install to test, and I currently do not have any, so this implies more time spent and etc ...

The good thing is, your post here is a good warning

If you're interested, and since you seem to have some coding skill, we can try to find a quick fix.

Could you tell me what is the url of a comment ? the unrewritten one to be redirected ?

It's just a matter of adding the GET var used to the zero dupe filters.

What I know is that the problem is in the code of the file album_showpage.php

Could you paste here the url of the guilty link ? Usually, you can copy the url with a right click on the link.

My apologise for not releasing this publicly. I had found a quick 'fix' that works for my album. After making the comment, the confirmation URL will not be SEO'd and the redircting link will not be SEO'd either, but the zero dupe takes care of this after being redirected.

In album_showpage.php comment line:
//$phpbb_seo->seo_redirect( $phpbb_seo->seo_path['smrt_url'] . $phpbb_seo->page_url );

Peter77 wrote:album_showpage.php is the culprit with:

Okay I commented this line:

Code: Select all

//$phpbb_seo->seo_redirect( $phpbb_seo->seo_path['smrt_url'] . $phpbb_seo->page_url );

And I am able to comment although album_showpage.php is not 100% SEO'd but it does redirect to it's SEO URL when I am redirected back to the commented picture.

Also, please note this fix to Personal Albums not opening.

Thank you but...

Commenting that line is exactly the same as not installing the whole mod at all... Not only is not SEO'd but it simply doesn't work at all.

If I've a link with the format -http://...album_showpage.php?pic_id=xxx
after commenting that line I go that exact url without rewriting anything, so I've two page with the same content as it was before.

On my portal I've two blocks with the most recent and the random pictures from the album, that is, I think the most common situation where this NO DUPE mod should have a sense in the smartor's album (apart old links). that's why I tried to install this mod

Not working for a link is not exactly the same as not working at all.

Anyway, try replacing :

Code: Select all

   if ( $phpbb_seo->do_redir || ( strpos($uri, $phpbb_seo->page_url) === FALSE ) ) {

with :

Code: Select all

   if ( ($phpbb_seo->do_redir || ( strpos($uri, $phpbb_seo->page_url) === FALSE )) && !isset($_POST['comment']) && !isset($_POST['rating']) ) {

in album_shopage.php (zero dupe code change).

Yep, problem solved ! (thumbs up)

Thank you !
.
.
.
.
.
.

Well how about that. Much better... glad you brought it up then.

Glad your problem was resolved.

oh, sorry for the link, didn't want to steal anything (rofl)

Oops...


Yeah I'm interested in this too actually