wwwmaster - Posts

Return to advanced search

Small bug in GYM Sitemaps module

Hello, I have fixed a bug in the GYM Sitemaps module's HTML sitemap mode. The bug caused invalid 301 redirects for sitemap pages with pagination, that is URLs like this: -http://www.example.com/forum/news/forum/sivu10.html (sivu is the Finnish translation for page). Now, I have zero duplicates enabl...
by wwwmaster
Sat Dec 11, 2010 12:37 am
 
Forum: GYM Sitemaps & RSS
Topic: Small bug in GYM Sitemaps module
Replies: 1
Views: 3314

Re: [ToolKit] External links in new window

Then again, the problem with Prime Link is that it cannot doesn't "magic links" in existing posts on the board, as it requires modifying the posts' text in database. The solution presented above affects all links, existing and new links.

Anyway, Prime Link looks like a nice MOD.
by wwwmaster
Sat Sep 19, 2009 1:53 am
 
Forum: phpBB SEO TooLKit
Topic: [ToolKit] External links in new window
Replies: 19
Views: 17331

Re: [ToolKit] External links in new window

The problem in phpBB3 is that you have to make several non-trivial modifications in order to add that rel="external" to the links.
by wwwmaster
Thu Sep 17, 2009 6:07 pm
 
Forum: phpBB SEO TooLKit
Topic: [ToolKit] External links in new window
Replies: 19
Views: 17331

Re: [ToolKit] External links in new window

I think it is better to match on those a tags that use the postlink or postlink-local class. This works on styles that use postlink or postlink-local as the class for links. This code is more accurate on targetting the specific links: // http://www.phpBB-SEO.com SEO TOOLKIT BEGIN // Open external li...
by wwwmaster
Thu Sep 17, 2009 7:16 am
 
Forum: phpBB SEO TooLKit
Topic: [ToolKit] External links in new window
Replies: 19
Views: 17331

You're right about the s option, so : $reg_exp = '`<(\w+)[^>]*>(.*)</\1>`Usi'; should be our final answer ;) That doesn't work either.. The only one that works for me until now is the solution I presented above. Do you have any data about the memory limit attained ? Because usually ...
by wwwmaster
Sat Jan 10, 2009 8:40 am
 
Forum: GYM Sitemaps & RSS
Topic: A bug in google_xml.php file
Replies: 13
Views: 1407

Thinking about it a bit more, I think that the correct reg ex should rather be : $reg_exp = '`<(\w+)[^>]*>(.*)</\1>`Ui'; "U" stands for ungreedy, meaning that the first matching closing tag will be used, it's actually better than the "s" option, which is only ask...
by wwwmaster
Mon Jan 05, 2009 11:56 pm
 
Forum: GYM Sitemaps & RSS
Topic: A bug in google_xml.php file
Replies: 13
Views: 1407

This is a replacement for the xml2array() -function which works correctly for me: function xml2array($text, $inner=0) { if ($inner) { $reg_exp = '`<(\w+)[^>]*>(.*?)</\1>`s'; } else { $reg_exp = '`<(\w+)[^>]*>(.*)</\1>`s'; } pre...
by wwwmaster
Sun Jan 04, 2009 8:17 pm
 
Forum: GYM Sitemaps & RSS
Topic: A bug in google_xml.php file
Replies: 13
Views: 1407

Actually the problem isn't yet solved..

The urlset -tag contains attributes, and now the xml2array() -function doesn't parse the starting urlset -tag..

I'll keep digging :)
by wwwmaster
Sun Jan 04, 2009 6:36 pm
 
Forum: GYM Sitemaps & RSS
Topic: A bug in google_xml.php file
Replies: 13
Views: 1407

I found the problem.. My sitemap contains line feeds, and for some reason the original regexp doesn't work with it. However, if I use this regexp, the backreferences and the code work: $reg_exp = '#<(\w+)>(.*?)</\\1>#s'; That is, I remove the part designed to match tag attributes. In this case it sh...
by wwwmaster
Sun Jan 04, 2009 6:26 pm
 
Forum: GYM Sitemaps & RSS
Topic: A bug in google_xml.php file
Replies: 13
Views: 1407

And even with \\1 as the backreference, it fails.
by wwwmaster
Sun Jan 04, 2009 5:01 pm
 
Forum: GYM Sitemaps & RSS
Topic: A bug in google_xml.php file
Replies: 13
Views: 1407

Yes, I am using a real sitemap, at http://www.pokeri.com/sitemap.xml I have tested the regexp, and if it is like this: $reg_exp = '#<(\w+)[^>]*>(.*?)</\1>#s'; It does not work, it matches zero times. However, if I remove the backreference: $reg_exp = '#<(\w+)[^>]*>(.*?)</url>#s'; It matches the data...
by wwwmaster
Sun Jan 04, 2009 4:51 pm
 
Forum: GYM Sitemaps & RSS
Topic: A bug in google_xml.php file
Replies: 13
Views: 1407

I also tried to use it with the Last modification setting turned on, but then the code failed to parse the XML document. The included xml2array() function doesn't return anything for the sitemap, which is perfectly fine according to Google. Perhaps you should use PHP's integrated XML parser class an...
by wwwmaster
Sun Jan 04, 2009 5:52 am
 
Forum: GYM Sitemaps & RSS
Topic: A bug in google_xml.php file
Replies: 13
Views: 1407

A bug in google_xml.php file

Hello, I want to first thank you for the truly wonderful package of code you have implemented in this GYM sitemaps package. And the other phpBB SEO packages aren't bad either. Anyway, I found two bugs in google_xml.php in 2.0RC3 version. On line 88 you test if the site map to be loaded is a local fi...
by wwwmaster
Sun Jan 04, 2009 4:08 am
 
Forum: GYM Sitemaps & RSS
Topic: A bug in google_xml.php file
Replies: 13
Views: 1407

No, the mod does not change the phpBB DB besides adding an entry in the acp module list for the phpBB SEO acp. So you need to rebuild search table every time you change the search_ignore_words.php. Then, words listed there should not show up in the topic metas, the only one to play with these exclu...
by wwwmaster
Fri Aug 22, 2008 6:44 pm
 
Forum: phpBB SEO MODS
Topic: phpbb3 search_ignore_words.php and Dynamic Meta Tags
Replies: 6
Views: 2738

Three issues here.. First, as far as I know, when using MySQL Fulltext indexing, the stopwords have to be listed in MySQL configuration. Therefore the stopwords listed in stopwords file have no effect. Second, dynamic meta tags MOD depends on Fulltext native indexing, it doesn't access the MySQL ind...
by wwwmaster
Tue Jul 22, 2008 11:25 am
 
Forum: phpBB SEO MODS
Topic: [meta] Dynamic Meta Tags and search stop words...
Replies: 8
Views: 2759
Next

Return to advanced search